[Impala-ASF-CR] IMPALA-3348: Avoid per-slot check vector size in KuduScanner

2016-10-14 Thread Internal Jenkins (Code Review) 
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner
..


IMPALA-3348: Avoid per-slot check vector size in KuduScanner

Fixes a small perf issue by avoiding extra calls to check
a vector size on every slot.

Testing: Ran EE tests.

Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Reviewed-on: http://gerrit.cloudera.org:8080/4688
Reviewed-by: Matthew Jacobs 
Tested-by: Internal Jenkins
---
M be/src/exec/kudu-scanner.cc
M be/src/exec/kudu-scanner.h
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Matthew Jacobs: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mostafa Mokhtar

[Impala-ASF-CR] IMPALA-3348: Avoid per-slot check vector size in KuduScanner

2016-10-14 Thread Internal Jenkins (Code Review) 
Internal Jenkins has posted comments on this change.

Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner
..


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3348: Avoid per-slot check vector size in KuduScanner

2016-10-14 Thread Matthew Jacobs (Code Review) 
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner
..


Patch Set 2: Code-Review+2

rebase and carrying +2

-- 
To view, visit http://gerrit.cloudera.org:8080/4688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3348: Avoid per-slot check vector size in KuduScanner

2016-10-14 Thread Internal Jenkins (Code Review) 
Internal Jenkins has posted comments on this change.

Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner
..


Patch Set 1: Verified-1

Build failed: 
http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/295/

-- 
To view, visit http://gerrit.cloudera.org:8080/4688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3348: Avoid per-slot check vector size in KuduScanner

2016-10-14 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change.

Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner
..


Patch Set 1: Code-Review+2

Trivial change, I feel comfortable giving +2

-- 
To view, visit http://gerrit.cloudera.org:8080/4688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3348: Avoid per-slot check vector size in KuduScanner

2016-10-11 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change.

Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3348: Avoid per-slot check vector size in KuduScanner

2016-10-11 Thread Matthew Jacobs (Code Review) 
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4688/1/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

Line 241:   for (int i = 0; i < num_string_slots_; ++i) {
> Wouldn't storing the size here have the same effect, i.e.:
Not exactly the same - it still has to be called for every tuple. That's 
probably fine, but let's ask Mostafa since he found this issue in his tests. 
This may go away soon if the tuple layout changes make it in.


-- 
To view, visit http://gerrit.cloudera.org:8080/4688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3348: Avoid per-slot check vector size in KuduScanner

2016-10-11 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change.

Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4688/1/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

Line 241:   for (int i = 0; i < num_string_slots_; ++i) {
Wouldn't storing the size here have the same effect, i.e.:
Seems simpler.

int num_string_slots = string_slots_.size();
for (int i = 0; i < num_string_slots; ++i) {
...


-- 
To view, visit http://gerrit.cloudera.org:8080/4688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs 
Gerrit-Reviewer: Alex Behm 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3348: Avoid per-slot check vector size in KuduScanner

2016-10-11 Thread Matthew Jacobs (Code Review) 
Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4688

Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner
..

IMPALA-3348: Avoid per-slot check vector size in KuduScanner

Fixes a small perf issue by avoiding extra calls to check
a vector size on every slot.

Testing: Ran EE tests.

Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
---
M be/src/exec/kudu-scanner.cc
M be/src/exec/kudu-scanner.h
2 files changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/4688/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs