[Impala-ASF-CR] IMPALA-3894: Changed the behavior parsing 2-digit year values

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3894: Changed the behavior parsing 2-digit year values .. Patch Set 4: (8 comments) Looks pretty good. No major concerns, we just need some tests and a

[Impala-ASF-CR] IMPALA-3894: Changed the behavior parsing 2-digit year values

2017-07-27 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-3894: Changed the behavior parsing 2-digit year values .. Patch Set 4: IIRC that's the calculation SimpleDateFormat uses for two digit years and likely

[Impala-ASF-CR] IMPALA-3894: Changed the behavior parsing 2-digit year values

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3894: Changed the behavior parsing 2-digit year values .. Patch Set 4: Greg, you've got a lot of experience looking at date/time functions. What do you

[Impala-ASF-CR] IMPALA-3894: Changed the behavior parsing 2-digit year values

2017-07-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7530 Change subject: IMPALA-3894: Changed the behavior parsing 2-digit year values .. IMPALA-3894: Changed the behavior parsing 2-digit year