[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4116: Remove 'cdh' from version string again .. IMPALA-4116: Remove 'cdh' from version string again The rebase of another change went wrong and undid the change of I7754538a23e73dcdebc6e3df509f357cbe03198c so we need to do this one again. Previous review was at http://gerrit.cloudera.org:8080/4421 . Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f Reviewed-on: http://gerrit.cloudera.org:8080/4439 Reviewed-by: Sailesh Mukil Reviewed-by: Lars Volker Reviewed-by: Jim Apple Tested-by: Sailesh Mukil --- M bin/save-version.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jim Apple: Looks good to me, approved Lars Volker: Looks good to me, but someone else must approve Sailesh Mukil: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Lars Volker has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string again .. Patch Set 1: As a non-committer I cannot submit this. Can one of you please submit and push it to the asf repo? Thanks a lot. -- To view, visit http://gerrit.cloudera.org:8080/4439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string again .. Patch Set 1: Verified+1 > Since this already passed GVO, I think it's OK to commit without > doing that again. Manually verifying as it already went through GVO once before. -- To view, visit http://gerrit.cloudera.org:8080/4439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Jim Apple has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string again .. Patch Set 1: Code-Review+2 Since this already passed GVO, I think it's OK to commit without doing that again. -- To view, visit http://gerrit.cloudera.org:8080/4439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Lars Volker has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string again .. Patch Set 1: Code-Review+1 No worries. I think we should merge this right away. The previous attempt was done after full GVO so I don't see why anything could be wrong now. -- To view, visit http://gerrit.cloudera.org:8080/4439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string again .. Patch Set 1: Code-Review+2 > Uploaded patch set 1. Really sorry about this. This patch and my patch got committed together and I reverted this on rebase by mistake. -- To view, visit http://gerrit.cloudera.org:8080/4439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string again
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4439 Change subject: IMPALA-4116: Remove 'cdh' from version string again .. IMPALA-4116: Remove 'cdh' from version string again The rebase of another change went wrong and undid the change of I7754538a23e73dcdebc6e3df509f357cbe03198c so we need to do this one again. Previous review was at http://gerrit.cloudera.org:8080/4421 . Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f --- M bin/save-version.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/4439/1 -- To view, visit http://gerrit.cloudera.org:8080/4439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie386d25f2006e2dcebcbfd3d6ae88f70d65efb0f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4116: Remove 'cdh' from version string .. IMPALA-4116: Remove 'cdh' from version string Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c Reviewed-on: http://gerrit.cloudera.org:8080/4421 Reviewed-by: Jim Apple Tested-by: Internal Jenkins --- M bin/save-version.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jim Apple: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 2: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/203/ -- To view, visit http://gerrit.cloudera.org:8080/4421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string
Jim Apple has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 2: Code-Review+2 I've rethought it and I'm convinced this has a very low probability of causing issues. -- To view, visit http://gerrit.cloudera.org:8080/4421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string
Jim Apple has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 2: Code-Review+1 I'd like another +1 on this, just for another pair of eyes. Once this is done, I'll cherry pick it to the 2.7.0 branch. When 2.7.0. is out the door, I'll patch master to have a version string of 2.8.0 -- To view, visit http://gerrit.cloudera.org:8080/4421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string
Lars Volker has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4421/1/bin/save-version.sh File bin/save-version.sh: PS1, Line 24: > We probably should not put the rc in the version string, because an RC can That make sense, I removed it. -- To view, visit http://gerrit.cloudera.org:8080/4421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4116: Remove 'cdh' from version string .. IMPALA-4116: Remove 'cdh' from version string Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c --- M bin/save-version.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/4421/2 -- To view, visit http://gerrit.cloudera.org:8080/4421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string
Jim Apple has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4421/1/bin/save-version.sh File bin/save-version.sh: PS1, Line 24: rc2 We probably should not put the rc in the version string, because an RC can go straigt to being a release and needs to have the same (signed) tarball. -- To view, visit http://gerrit.cloudera.org:8080/4421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4421 Change subject: IMPALA-4116: Remove 'cdh' from version string .. IMPALA-4116: Remove 'cdh' from version string Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c --- M bin/save-version.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/4421/1 -- To view, visit http://gerrit.cloudera.org:8080/4421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker