[Impala-ASF-CR] IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node.
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5340c2eda813afc032ba72203bd59eb3f2c4f482 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node.
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. .. IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. There was a missing break in a switch statement leading to bad fallthrough. An existing test already expected incorrect results. The bug is covered by expecting correct results. Change-Id: I5340c2eda813afc032ba72203bd59eb3f2c4f482 Reviewed-on: http://gerrit.cloudera.org:8080/4585 Reviewed-by: Alex Behm Tested-by: Internal Jenkins --- M be/src/exec/data-source-scan-node.cc M testdata/workloads/functional-query/queries/QueryTest/data-source-tables.test 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5340c2eda813afc032ba72203bd59eb3f2c4f482 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node.
Alex Behm has posted comments on this change. Change subject: IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5340c2eda813afc032ba72203bd59eb3f2c4f482 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node.
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5340c2eda813afc032ba72203bd59eb3f2c4f482 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node.
Alex Behm has posted comments on this change. Change subject: IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. .. Patch Set 1: Code-Review+1 I found this bug while experimenting with a different tuple mem layout. -- To view, visit http://gerrit.cloudera.org:8080/4585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5340c2eda813afc032ba72203bd59eb3f2c4f482 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node.
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. .. Patch Set 1: Code-Review+1 Wow, nice catch. How'd you find this? The good news is that I don't think anyone is using this code path. -- To view, visit http://gerrit.cloudera.org:8080/4585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5340c2eda813afc032ba72203bd59eb3f2c4f482 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node.
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4585/1/testdata/workloads/functional-query/queries/QueryTest/data-source-tables.test File testdata/workloads/functional-query/queries/QueryTest/data-source-tables.test: PS1, Line 11: :( -- To view, visit http://gerrit.cloudera.org:8080/4585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5340c2eda813afc032ba72203bd59eb3f2c4f482 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node.
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4585 Change subject: IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. .. IMPALA-4237: Fix materialization of 4 byte decimals in data source scan node. There was a missing break in a switch statement leading to bad fallthrough. An existing test already expected incorrect results. The bug is covered by expecting correct results. Change-Id: I5340c2eda813afc032ba72203bd59eb3f2c4f482 --- M be/src/exec/data-source-scan-node.cc M testdata/workloads/functional-query/queries/QueryTest/data-source-tables.test 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/4585/1 -- To view, visit http://gerrit.cloudera.org:8080/4585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5340c2eda813afc032ba72203bd59eb3f2c4f482 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm
