[Impala-ASF-CR] IMPALA-4294: Make check-schema-diff.sh executable from anywhere.
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4294: Make check-schema-diff.sh executable from anywhere. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32e0dce2c10c443763a038aa3b64b1c123ed62ad Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4294: Make check-schema-diff.sh executable from anywhere.
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4294: Make check-schema-diff.sh executable from anywhere. .. IMPALA-4294: Make check-schema-diff.sh executable from anywhere. Fixes a regression in the data load process that had been introduced by commit 75a857c. To making check-schema-diff.sh work from anywhere. we need to specify the git-dir and work-tree arguments everywhere we call git. Change-Id: I32e0dce2c10c443763a038aa3b64b1c123ed62ad Reviewed-on: http://gerrit.cloudera.org:8080/4726 Reviewed-by: Taras Bobrovytsky Tested-by: Internal Jenkins --- M testdata/bin/check-schema-diff.sh 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Taras Bobrovytsky: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32e0dce2c10c443763a038aa3b64b1c123ed62ad Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4294: Make check-schema-diff.sh executable from anywhere.
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4294: Make check-schema-diff.sh executable from anywhere. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32e0dce2c10c443763a038aa3b64b1c123ed62ad Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4294: Make check-schema-diff.sh executable from anywhere.
David Knupp has posted comments on this change. Change subject: IMPALA-4294: Make check-schema-diff.sh executable from anywhere. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4726/2/buildall.sh File buildall.sh: PS2, Line 431: load_test_data : fi : : if [[ $TESTS_ACTION -eq 1 ]]; then : run_ > Ok, it turns out work tree must be specified as well Done -- To view, visit http://gerrit.cloudera.org:8080/4726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32e0dce2c10c443763a038aa3b64b1c123ed62ad Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4294: Make check-schema-diff.sh executable from anywhere.
David Knupp has uploaded a new patch set (#3). Change subject: IMPALA-4294: Make check-schema-diff.sh executable from anywhere. .. IMPALA-4294: Make check-schema-diff.sh executable from anywhere. Fixes a regression in the data load process that had been introduced by commit 75a857c. To making check-schema-diff.sh work from anywhere. we need to specify the git-dir and work-tree arguments everywhere we call git. Change-Id: I32e0dce2c10c443763a038aa3b64b1c123ed62ad --- M testdata/bin/check-schema-diff.sh 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/4726/3 -- To view, visit http://gerrit.cloudera.org:8080/4726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I32e0dce2c10c443763a038aa3b64b1c123ed62ad Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong
