[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-13 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..


Patch Set 4: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-13 Thread Sailesh Mukil (Code Review) 
Hello Impala Public Jenkins, Dimitris Tsirogiannis,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5972

to look at the new patch set (#4).

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..

IMPALA-4897: AnalysisException: specified cache pool does not exist

A few tests were added with IMPALA-1670 that made use of HDFS caching.
This patch moves these tests to a new file and only executes them
when the default filesystem is HDFS.

There was also a bug where the tests used absolute locations instead
of locations relative to the table they were in which could easily
collide with locations of other tables if they raced. That has been
fixed too.

Also added a testcase for testing alter table ADD multiple PARTITIONS
for non-HDFS filesystems.

Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
---
A 
testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M tests/metadata/test_ddl.py
3 files changed, 129 insertions(+), 66 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/5972/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-13 Thread Sailesh Mukil (Code Review) 
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..


Patch Set 4: Code-Review+2

(1 comment)

Carry +2.

http://gerrit.cloudera.org:8080/#/c/5972/3/testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test
File 
testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test:

PS3, Line 1: # This test file covers alter table statements that add multiple 
partitions and use hdfs caching
   : 
> Can you change the description to something like "This test file covers alt
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-13 Thread Sailesh Mukil (Code Review) 
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..


Patch Set 2:

> Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/264/

This test failed because while running the test, one of the partitions ended up 
having 2 files in it while it should have only 1.

This test passes locally always. I'll try to figure out why and where this 
extra file came from.

-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-12 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..


Patch Set 2: Verified-1

Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/264/

-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-12 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..


Patch Set 2:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/264/

-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-12 Thread Sailesh Mukil (Code Review) 
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..


Patch Set 2: Code-Review+2

(1 comment)

Carry +2.

http://gerrit.cloudera.org:8080/#/c/5972/1/testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test
File 
testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test:

PS1, Line 1: # IM
> Can you add a comment to describe at a high level what this test file is al
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-12 Thread Sailesh Mukil (Code Review) 
Hello Dimitris Tsirogiannis,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5972

to look at the new patch set (#2).

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..

IMPALA-4897: AnalysisException: specified cache pool does not exist

A few tests were added with IMPALA-1670 that made use of HDFS caching.
This patch moves these tests to a new file and only executes them
when the default filesystem is HDFS.

Also added a testcase for testing alter table ADD multiple PARTITIONS
for non-HDFS filesystems.

Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
---
A 
testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M tests/metadata/test_ddl.py
3 files changed, 124 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/5972/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Sailesh Mukil

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-12 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5972/1/testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test
File 
testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test:

PS1, Line 1: 
Can you add a comment to describe at a high level what this test file is all 
about?


-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-10 Thread Sailesh Mukil (Code Review) 
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5972/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

PS1, Line 258: if IS_HDFS:
 :   self.run_test_case('QueryTest/alter-table-hdfs-caching', 
vector,
 :   use_db=unique_database, 
multiple_impalad=self._use_multiple_impalad(vector))
> I think it may be best to put it in test_hdfs_caching.py? What do you think
I thought about that but the goal of this test is to test an ALTER TABLE 
functionality and the hdfs caching part is not the core of the test, which is 
why I left it here instead.


-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-10 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5972/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

PS1, Line 258: if IS_HDFS:
 :   self.run_test_case('QueryTest/alter-table-hdfs-caching', 
vector,
 :   use_db=unique_database, 
multiple_impalad=self._use_multiple_impalad(vector))
I think it may be best to put it in test_hdfs_caching.py? What do you think?


-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-10 Thread Sailesh Mukil (Code Review) 
Sailesh Mukil has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5972

Change subject: IMPALA-4897: AnalysisException: specified cache pool does not 
exist
..

IMPALA-4897: AnalysisException: specified cache pool does not exist

A few tests were added with IMPALA-1670 that made use of HDFS caching.
This patch moves these tests to a new file and only executes them
when the default filesystem is HDFS.

Also added a testcase for testing alter table ADD multiple PARTITIONS
for non-HDFS filesystems.

Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
---
A 
testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M tests/metadata/test_ddl.py
3 files changed, 123 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/5972/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefe61556bc28ae320f3f41fdc930d37b258d970a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil