[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-11-01 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8419 )

Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536
..

IMPALA-5541: Reject BATCH_SIZE greater than 65536

Setting a very large value could cause strange behaviour like crashing,
hanging, excessive memory usage, spinning etc. This patch rejects values
out of the range [0,65536].

Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
Reviewed-on: http://gerrit.cloudera.org:8080/8419
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
2 files changed, 12 insertions(+), 3 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
Gerrit-Change-Number: 8419
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-11-01 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8419 )

Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
Gerrit-Change-Number: 8419
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 02 Nov 2017 00:45:09 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-11-01 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8419 )

Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1423/


--
To view, visit http://gerrit.cloudera.org:8080/8419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
Gerrit-Change-Number: 8419
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 01 Nov 2017 20:54:14 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-11-01 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8419 )

Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
Gerrit-Change-Number: 8419
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 01 Nov 2017 20:54:06 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-10-30 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8419 )

Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536
..


Patch Set 1: Code-Review+2

I'll wait until Lars gives the all-clear for merging things


--
To view, visit http://gerrit.cloudera.org:8080/8419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
Gerrit-Change-Number: 8419
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 31 Oct 2017 00:05:53 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-10-30 Thread Mostafa Mokhtar (Code Review) 
Mostafa Mokhtar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8419 )

Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536
..


Patch Set 1:

65K should be fine for experimentation.


--
To view, visit http://gerrit.cloudera.org:8080/8419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
Gerrit-Change-Number: 8419
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 30 Oct 2017 23:51:07 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-10-30 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8419 )

Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536
..


Patch Set 1:

Mostafa, can you think of any reason we'd want to set this to a higher value? 
(If it's for an experiment we can always increase the limit with a code change 
if we want to).


--
To view, visit http://gerrit.cloudera.org:8080/8419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
Gerrit-Change-Number: 8419
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 30 Oct 2017 22:18:14 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-10-30 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8419 )

Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/8419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
Gerrit-Change-Number: 8419
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 30 Oct 2017 22:17:10 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-10-30 Thread Tianyi Wang (Code Review) 
Tianyi Wang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8419


Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536
..

IMPALA-5541: Reject BATCH_SIZE greater than 65536

Setting a very large value could cause strange behaviour like crashing,
hanging, excessive memory usage, spinning etc. This patch rejects values
out of the range [0,65536].

Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
---
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
2 files changed, 12 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/8419/1
--
To view, visit http://gerrit.cloudera.org:8080/8419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd5a2490a73b6915224160d7604b4badc72c1d97
Gerrit-Change-Number: 8419
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang