[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. IMPALA-5572: Timestamp codegen for text scanner Currently codegen is disabled when scanning

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1013/ -- To view,

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1007/ -- To view,

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: It looks like you're hitting a known-flaky test:

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: I will test the rebased version again. -- To view, visit http://gerrit.cloudera.org:8080/7556 To

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1002/ --

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1002/ -- To view,

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Code-Review+2 rebase. -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe,

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 4: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/997/ -- To view,

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/997/ -- To view,

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/991/ -- To

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/991/ -- To view,

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 4: > (1 comment) Done -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Tianyi Wang (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7556 to look at the new patch set (#4). Change subject: IMPALA-5572: Timestamp codegen for text scanner

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7556/3/be/src/exec/text-converter.cc File

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/986/ -- To

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/986/ -- To view,

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-03 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 3: Rebase done -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 2: Code-Review+2 Looks great. I can start the merge after you rebase onto the latest master. --

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-03 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7556/1//COMMIT_MSG Commit Message: Line 14: >

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-03 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5572: Timestamp codegen for text scanner .. IMPALA-5572: Timestamp codegen for text scanner Currently codegen is disabled when scanning text tables with

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5572: Timestamp codegen for text scanner .. IMPALA-5572: Timestamp codegen for text scanner Currently codegen is disabled when scanning text tables with

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7556/1/be/src/exec/hdfs-scanner-ir.cc File

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7556/1/be/src/exec/hdfs-scanner-ir.cc File

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 1: (6 comments) Nice! No major concerns, mostly comments about comments.

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7556 Change subject: IMPALA-5572: Timestamp codegen for text scanner .. IMPALA-5572: Timestamp codegen for text scanner Currently codegen is