[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If65fee3e6a4b759d0d18e30a1c30bd48db0f2a54 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur The buffer pool changes reduced the memory requirement for the sort, which seems to have been enough to get the query to execute without spilling on S3. Reduce the limit in the test to force it to spill. Testing: Ran in a loop locally for an hour. Ran custom cluster tests on S3. Change-Id: If65fee3e6a4b759d0d18e30a1c30bd48db0f2a54 Reviewed-on: http://gerrit.cloudera.org:8080/7615 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M tests/custom_cluster/test_scratch_disk.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65fee3e6a4b759d0d18e30a1c30bd48db0f2a54 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. Patch Set 2: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/7615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If65fee3e6a4b759d0d18e30a1c30bd48db0f2a54 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1020/ -- To view, visit http://gerrit.cloudera.org:8080/7615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If65fee3e6a4b759d0d18e30a1c30bd48db0f2a54 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. Patch Set 1: Code-Review+2 This is good validation for the buffer pool changes! -- To view, visit http://gerrit.cloudera.org:8080/7615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If65fee3e6a4b759d0d18e30a1c30bd48db0f2a54 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7615 Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur The buffer pool changes reduced the memory requirement for the sort, which seems to have been enough to get the query to execute without spilling on S3. Reduce the limit in the test to force it to spill. Testing: Ran in a loop locally for an hour. Ran custom cluster tests on S3. Change-Id: If65fee3e6a4b759d0d18e30a1c30bd48db0f2a54 --- M tests/custom_cluster/test_scratch_disk.py 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/7615/1 -- To view, visit http://gerrit.cloudera.org:8080/7615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If65fee3e6a4b759d0d18e30a1c30bd48db0f2a54 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong
