[Impala-ASF-CR] IMPALA-6106: handle comments before set in test parser

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8384 )

Change subject: IMPALA-6106: handle comments before set in test parser
..

IMPALA-6106: handle comments before set in test parser

The tpcds-q22a.test test file has a comment before a "set" command.
The regex used to match "set" commands does not handle preceding
comments, which are part of the query statement.

Testing:
Ran the test with the below command and confirmed that DECIMAL_V2 was
automatically set back to 0.

  impala-py.test tests/query_test/test_tpcds_queries.py -k 22a \
  --capture=no

Change-Id: Id549dd3369dd163f3b3c8fe5685a52e0e6b2d134
Reviewed-on: http://gerrit.cloudera.org:8080/8384
Reviewed-by: Michael Brown 
Tested-by: Impala Public Jenkins
---
M tests/common/impala_test_suite.py
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Michael Brown: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id549dd3369dd163f3b3c8fe5685a52e0e6b2d134
Gerrit-Change-Number: 8384
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown 

[Impala-ASF-CR] IMPALA-6106: handle comments before set in test parser

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8384 )

Change subject: IMPALA-6106: handle comments before set in test parser
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id549dd3369dd163f3b3c8fe5685a52e0e6b2d134
Gerrit-Change-Number: 8384
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown 
Gerrit-Comment-Date: Thu, 26 Oct 2017 00:35:38 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6106: handle comments before set in test parser

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8384 )

Change subject: IMPALA-6106: handle comments before set in test parser
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1390/


--
To view, visit http://gerrit.cloudera.org:8080/8384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id549dd3369dd163f3b3c8fe5685a52e0e6b2d134
Gerrit-Change-Number: 8384
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown 
Gerrit-Comment-Date: Wed, 25 Oct 2017 21:08:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6106: handle comments before set in test parser

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8384 )

Change subject: IMPALA-6106: handle comments before set in test parser
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id549dd3369dd163f3b3c8fe5685a52e0e6b2d134
Gerrit-Change-Number: 8384
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Michael Brown 
Gerrit-Comment-Date: Wed, 25 Oct 2017 21:05:52 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6106: handle comments before set in test parser

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8384


Change subject: IMPALA-6106: handle comments before set in test parser
..

IMPALA-6106: handle comments before set in test parser

The tpcds-q22a.test test file has a comment before a "set" command.
The regex used to match "set" commands does not handle preceding
comments, which are part of the query statement.

Testing:
Ran the test with the below command and confirmed that DECIMAL_V2 was
automatically set back to 0.

  impala-py.test tests/query_test/test_tpcds_queries.py -k 22a \
  --capture=no

Change-Id: Id549dd3369dd163f3b3c8fe5685a52e0e6b2d134
---
M tests/common/impala_test_suite.py
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/8384/1
--
To view, visit http://gerrit.cloudera.org:8080/8384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id549dd3369dd163f3b3c8fe5685a52e0e6b2d134
Gerrit-Change-Number: 8384
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong