[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Fri, 10 Nov 2017 04:27:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..

IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

TestAlwaysFalseFilter gets the query profile without fetching all the
rows, resulting in a stale query profile and failing the test. With
this patch all the rows are fetched before getting the query profile.
This is enough to get the final profile because the query profile
finalization is performed in Coordinator::GetNext after we hit eos.
A bug in Base64Decode related to query profile decoding is also fixed.
Currently Base64Decode may produce incorrect output length if the output
parameter is not initialized with 0.

Testing: TestAlwaysFalseFilter is run and passes 1000 times. It doesn't
pass 1000 times consecutively without this patch.

Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Reviewed-on: http://gerrit.cloudera.org:8080/8498
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins
---
M be/src/util/coding-util.cc
M tests/custom_cluster/test_always_false_filter.py
2 files changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1458/


--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Fri, 10 Nov 2017 01:15:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Fri, 10 Nov 2017 01:14:47 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Tianyi Wang (Code Review) 
Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 4:

The change in base64 decoding broke a test because a variable was not 
initialized. It's now fixed.


--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Fri, 10 Nov 2017 00:33:04 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Tianyi Wang (Code Review) 
Hello Sailesh Mukil, Alex Behm, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8498

to look at the new patch set (#4).

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..

IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

TestAlwaysFalseFilter gets the query profile without fetching all the
rows, resulting in a stale query profile and failing the test. With
this patch all the rows are fetched before getting the query profile.
This is enough to get the final profile because the query profile
finalization is performed in Coordinator::GetNext after we hit eos.
A bug in Base64Decode related to query profile decoding is also fixed.
Currently Base64Decode may produce incorrect output length if the output
parameter is not initialized with 0.

Testing: TestAlwaysFalseFilter is run and passes 1000 times. It doesn't
pass 1000 times consecutively without this patch.

Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
---
M be/src/util/coding-util.cc
M tests/custom_cluster/test_always_false_filter.py
2 files changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/8498/4
--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1451/


--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Thu, 09 Nov 2017 04:17:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1450/


--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Thu, 09 Nov 2017 00:44:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1451/


--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Thu, 09 Nov 2017 00:44:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Thu, 09 Nov 2017 00:29:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Tianyi Wang (Code Review) 
Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8498/2/tests/custom_cluster/test_always_false_filter.py
File tests/custom_cluster/test_always_false_filter.py:

http://gerrit.cloudera.org:8080/#/c/8498/2/tests/custom_cluster/test_always_false_filter.py@45
PS2, Line 45:   # Fetch all rows to finalize the query profile.
> comment why we need to fetchall here
Done



--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Thu, 09 Nov 2017 00:25:51 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Tianyi Wang (Code Review) 
Hello Sailesh Mukil, Alex Behm,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8498

to look at the new patch set (#3).

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..

IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

TestAlwaysFalseFilter gets the query profile without fetching all the
rows, resulting in a stale query profile and failing the test. With
this patch all the rows are fetched before getting the query profile.
This is enough to get the final profile because the query profile
finalization is performed in Coordinator::GetNext after we hit eos.
A bug in Base64Decode related to query profile decoding is also fixed.
Currently Base64Decode may produce incorrect output length if the output
parameter is not initialized with 0.

Testing: TestAlwaysFalseFilter is run and passes 1000 times. It doesn't
pass 1000 times consecutively without this patch.

Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
---
M be/src/util/coding-util.cc
M tests/custom_cluster/test_always_false_filter.py
2 files changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/8498/3
--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8498/2/tests/custom_cluster/test_always_false_filter.py
File tests/custom_cluster/test_always_false_filter.py:

http://gerrit.cloudera.org:8080/#/c/8498/2/tests/custom_cluster/test_always_false_filter.py@45
PS2, Line 45:   cursor.fetchall()
comment why we need to fetchall here



--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Thu, 09 Nov 2017 00:23:41 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Tianyi Wang (Code Review) 
Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8498/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8498/1//COMMIT_MSG@13
PS1, Line 13: finalization is performed in Coordinator::GetNext after we hit 
eos.
> nit: Add "after we hit 'eos'"
Done


http://gerrit.cloudera.org:8080/#/c/8498/1//COMMIT_MSG@13
PS1, Line 13: fter we hit eos.
: A bug in Base64Decode related to quer
> Could you briefly mention what the noticeable implications were of this bug
Done



--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Thu, 09 Nov 2017 00:20:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Tianyi Wang (Code Review) 
Hello Sailesh Mukil,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8498

to look at the new patch set (#2).

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..

IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

TestAlwaysFalseFilter gets the query profile without fetching all the
rows, resulting in a stale query profile and failing the test. With
this patch all the rows are fetched before getting the query profile.
This is enough to get the final profile because the query profile
finalization is performed in Coordinator::GetNext after we hit eos.
A bug in Base64Decode related to query profile decoding is also fixed.
Currently Base64Decode may produce incorrect output length if the output
parameter is not initialized with 0.

Testing: TestAlwaysFalseFilter is run and passes 1000 times. It doesn't
pass 1000 times consecutively without this patch.

Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
---
M be/src/util/coding-util.cc
M tests/custom_cluster/test_always_false_filter.py
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/8498/2
--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Sailesh Mukil

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Sailesh Mukil (Code Review) 
Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8498/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8498/1//COMMIT_MSG@13
PS1, Line 13: finalization is performed in Coordinator::GetNext. A bug related 
to
nit: Add "after we hit 'eos'"


http://gerrit.cloudera.org:8080/#/c/8498/1//COMMIT_MSG@13
PS1, Line 13: A bug related to
: decoding query profile is also fixed.
Could you briefly mention what the noticeable implications were of this bug? It 
will be good for future reference.



--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Wed, 08 Nov 2017 23:12:02 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Tianyi Wang (Code Review) 
Tianyi Wang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8498


Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
..

IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

TestAlwaysFalseFilter gets the query profile without fetching all the
rows, resulting in a stale query profile and failing the test. With
this patch all the rows are fetched before getting the query profile.
This is enough to get the final profile because the query profile
finalization is performed in Coordinator::GetNext. A bug related to
decoding query profile is also fixed.

Testing: TestAlwaysFalseFilter is run and passes 1000 times. It doesn't
pass 1000 times consecutively without this patch.

Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
---
M be/src/util/coding-util.cc
M tests/custom_cluster/test_always_false_filter.py
2 files changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/8498/1
--
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang