[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-20 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8336 )

Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint
..

IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint

Add some boilerplate wording and reuse the same text
in several likely spots where readers might expect it
(under the pages for performance tuning with joins, hints,
views, and subqueries).

Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
Reviewed-on: http://gerrit.cloudera.org:8080/8336
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_perf_joins.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_views.xml
5 files changed, 17 insertions(+), 0 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
Gerrit-Change-Number: 8336
Gerrit-PatchSet: 5
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Mala Chikka Kempanna

[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-20 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8336 )

Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
Gerrit-Change-Number: 8336
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Mala Chikka Kempanna 
Gerrit-Comment-Date: Sat, 21 Oct 2017 00:06:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-20 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8336 )

Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/169/


--
To view, visit http://gerrit.cloudera.org:8080/8336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
Gerrit-Change-Number: 8336
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Mala Chikka Kempanna 
Gerrit-Comment-Date: Fri, 20 Oct 2017 23:58:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-20 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8336 )

Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint
..


Patch Set 4: Code-Review+2

Thanks!


--
To view, visit http://gerrit.cloudera.org:8080/8336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
Gerrit-Change-Number: 8336
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Mala Chikka Kempanna 
Gerrit-Comment-Date: Fri, 20 Oct 2017 23:55:23 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-20 Thread John Russell (Code Review) 
Hello Alex Behm, Mala Chikka Kempanna,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8336

to look at the new patch set (#4).

Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint
..

IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint

Add some boilerplate wording and reuse the same text
in several likely spots where readers might expect it
(under the pages for performance tuning with joins, hints,
views, and subqueries).

Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_perf_joins.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_views.xml
5 files changed, 17 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/8336/4
--
To view, visit http://gerrit.cloudera.org:8080/8336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
Gerrit-Change-Number: 8336
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Mala Chikka Kempanna

[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-20 Thread John Russell (Code Review) 
John Russell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8336 )

Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8336/3/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/8336/3/docs/shared/impala_common.xml@2869
PS3, Line 2869: in the query block containing the hint. It does not 
affect the join order
> I suggest removing the "nested within those table references part" because
Done



--
To view, visit http://gerrit.cloudera.org:8080/8336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
Gerrit-Change-Number: 8336
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Mala Chikka Kempanna 
Gerrit-Comment-Date: Fri, 20 Oct 2017 20:13:34 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-20 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8336 )

Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8336/3/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/8336/3/docs/shared/impala_common.xml@2869
PS3, Line 2869: in the query block containing the hint. It does not 
affect the join order
I suggest removing the "nested within those table references part" because 
WHERE-clause subqueries do not belong to "those table references"


Phrasing:
It does not affect the join order of any nested queries, such as views, inline 
views or WHERE-clause subqueries.



--
To view, visit http://gerrit.cloudera.org:8080/8336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
Gerrit-Change-Number: 8336
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Mala Chikka Kempanna 
Gerrit-Comment-Date: Fri, 20 Oct 2017 16:27:26 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint

2017-10-19 Thread John Russell (Code Review) 
Hello Alex Behm, Mala Chikka Kempanna,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8336

to look at the new patch set (#3).

Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint
..

IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint

Add some boilerplate wording and reuse the same text
in several likely spots where readers might expect it
(under the pages for performance tuning with joins, hints,
views, and subqueries).

Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_perf_joins.xml
M docs/topics/impala_subqueries.xml
M docs/topics/impala_views.xml
5 files changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/8336/3
--
To view, visit http://gerrit.cloudera.org:8080/8336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f
Gerrit-Change-Number: 8336
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Mala Chikka Kempanna