Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson
Huh, the GVO failed when the same job passed just fine when run manually.
Looks possibly like the machine had trouble, but looking into it.

On 19 September 2016 at 19:43, Internal Jenkins (Code Review) <
ger...@cloudera.org> wrote:

> Internal Jenkins has posted comments on this change.
>
> Change subject: IMPALA-4160: Remove Llama support.
> ..
>
>
> Patch Set 5: Verified-1
>
> Build failed: http://sandbox.jenkins.cloudera.com/job/impala-
> external-gerrit-verify-merge-ASF/216/
>
> --
> To view, visit http://gerrit.cloudera.org:8080/4445
> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef
> Gerrit-PatchSet: 5
> Gerrit-Project: Impala-ASF
> Gerrit-Branch: master
> Gerrit-Owner: Henry Robinson 
> Gerrit-Reviewer: Henry Robinson 
> Gerrit-Reviewer: Internal Jenkins
> Gerrit-Reviewer: Marcel Kornacker 
> Gerrit-Reviewer: Matthew Jacobs 
> Gerrit-Reviewer: Taras Bobrovytsky 
> Gerrit-HasComments: No
>



-- 
Henry Robinson
Software Engineer
Cloudera
415-994-6679


Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Matthew Jacobs
Yup, sure thing

On Mon, Sep 19, 2016 at 4:54 PM, Henry Robinson  wrote:
> Sounds good - if it's ok by you, will do in a separate commit since the
> first one is well into GVO-land...
>
> On 19 September 2016 at 16:19, Matthew Jacobs (Code Review)
>  wrote:
>>
>> Matthew Jacobs has posted comments on this change.
>>
>> Change subject: IMPALA-4160: Remove Llama support.
>> ..
>>
>>
>> Patch Set 5:
>>
>> (3 comments)
>>
>> a few more small things to remove
>>
>> http://gerrit.cloudera.org:8080/#/c/4445/5/testdata/cluster/admin
>> File testdata/cluster/admin:
>>
>> PS5, Line 82: export LLAMA_WEBUI_PORT=1501  # same as default
>> remove
>>
>>
>> PS5, Line 262: # Escape the first : to workaround
>> https://jira.cloudera.com/browse/CDH-16840
>>  :
>> LLAMA_PORT_MAPPINGS+="$HADOOP_HOSTNAME\\:$DATANODE_PORT="
>>  :
>> LLAMA_PORT_MAPPINGS+="$HADOOP_HOSTNAME:$NODEMANAGER_PORT
>> We can probably remove these
>>
>>
>> PS5, Line 266: LLAMA_PORT_MAPPINGS
>> this too
>>
>>
>> --
>> To view, visit http://gerrit.cloudera.org:8080/4445
>> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
>>
>> Gerrit-MessageType: comment
>> Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef
>> Gerrit-PatchSet: 5
>> Gerrit-Project: Impala-ASF
>> Gerrit-Branch: master
>> Gerrit-Owner: Henry Robinson 
>> Gerrit-Reviewer: Henry Robinson 
>> Gerrit-Reviewer: Marcel Kornacker 
>> Gerrit-Reviewer: Matthew Jacobs 
>> Gerrit-Reviewer: Taras Bobrovytsky 
>> Gerrit-HasComments: Yes
>
>
>
>
> --
> Henry Robinson
> Software Engineer
> Cloudera
> 415-994-6679


Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-19 Thread Henry Robinson
Sounds good - if it's ok by you, will do in a separate commit since the
first one is well into GVO-land...

On 19 September 2016 at 16:19, Matthew Jacobs (Code Review) <
ger...@cloudera.org> wrote:

> Matthew Jacobs has posted comments on this change.
>
> Change subject: IMPALA-4160: Remove Llama support.
> ..
>
>
> Patch Set 5:
>
> (3 comments)
>
> a few more small things to remove
>
> http://gerrit.cloudera.org:8080/#/c/4445/5/testdata/cluster/admin
> File testdata/cluster/admin:
>
> PS5, Line 82: export LLAMA_WEBUI_PORT=1501  # same as default
> remove
>
>
> PS5, Line 262: # Escape the first : to workaround
> https://jira.cloudera.com/browse/CDH-16840
>  : LLAMA_PORT_MAPPINGS+="$HADOOP_
> HOSTNAME\\:$DATANODE_PORT="
>  : LLAMA_PORT_MAPPINGS+="$HADOOP_
> HOSTNAME:$NODEMANAGER_PORT
> We can probably remove these
>
>
> PS5, Line 266: LLAMA_PORT_MAPPINGS
> this too
>
>
> --
> To view, visit http://gerrit.cloudera.org:8080/4445
> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef
> Gerrit-PatchSet: 5
> Gerrit-Project: Impala-ASF
> Gerrit-Branch: master
> Gerrit-Owner: Henry Robinson 
> Gerrit-Reviewer: Henry Robinson 
> Gerrit-Reviewer: Marcel Kornacker 
> Gerrit-Reviewer: Matthew Jacobs 
> Gerrit-Reviewer: Taras Bobrovytsky 
> Gerrit-HasComments: Yes
>



-- 
Henry Robinson
Software Engineer
Cloudera
415-994-6679