[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #445: generate cpp, go, and python thrift files under service-rpc

2019-10-11 Thread GitBox
jixuan1989 opened a new pull request #445: generate cpp, go, and python thrift files under service-rpc URL: https://github.com/apache/incubator-iotdb/pull/445 after run `mvn generate-sources`, you can find cpp, python, go apis under service-rpc/target/generated-source-{language}. So

[GitHub] [incubator-iotdb] samperson1997 commented on issue #417: [IOTDB-234] Refactor TsFile storage on HDFS

2019-10-11 Thread GitBox
samperson1997 commented on issue #417: [IOTDB-234] Refactor TsFile storage on HDFS URL: https://github.com/apache/incubator-iotdb/pull/417#issuecomment-540955410 > I think using reflection every time is too heavy and slow when all you want to do is to get a new Object. To put it simply, re

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #444: Add python client example in user guide

2019-10-11 Thread GitBox
qiaojialin commented on a change in pull request #444: Add python client example in user guide URL: https://github.com/apache/incubator-iotdb/pull/444#discussion_r333896921 ## File path: docs/Documentation-CHN/OtherMaterial-Examples.md ## @@ -81,3 +81,172 @@ public class I

[GitHub] [incubator-iotdb] LeiRui commented on issue #434: [IOTDB-244]fix bug when querying with duplicated columns

2019-10-11 Thread GitBox
LeiRui commented on issue #434: [IOTDB-244]fix bug when querying with duplicated columns URL: https://github.com/apache/incubator-iotdb/pull/434#issuecomment-541269319 In the original code, the client side IoTDBQueryResultSet assumes that the server returns deduplicated query results. Howe

[GitHub] [incubator-iotdb] LeiRui removed a comment on issue #434: [IOTDB-244]fix bug when querying with duplicated columns

2019-10-11 Thread GitBox
LeiRui removed a comment on issue #434: [IOTDB-244]fix bug when querying with duplicated columns URL: https://github.com/apache/incubator-iotdb/pull/434#issuecomment-541269319 In the original code, the client side IoTDBQueryResultSet assumes that the server returns deduplicated query resul

[GitHub] [incubator-iotdb] LeiRui edited a comment on issue #433: [IOTDB-203]add "group by device" function for narrow table display

2019-10-11 Thread GitBox
LeiRui edited a comment on issue #433: [IOTDB-203]add "group by device" function for narrow table display URL: https://github.com/apache/incubator-iotdb/pull/433#issuecomment-538706069 For the development document please see discussion in the email thread named "Re: A new result set format

[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #446: exclude .mvn/wrapper/maven-wrapper.jar

2019-10-11 Thread GitBox
qiaojialin opened a new pull request #446: exclude .mvn/wrapper/maven-wrapper.jar URL: https://github.com/apache/incubator-iotdb/pull/446 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #447: [IOTDB-250] exclude .mvn/wrapper/maven-wrapper.jar

2019-10-11 Thread GitBox
qiaojialin opened a new pull request #447: [IOTDB-250] exclude .mvn/wrapper/maven-wrapper.jar URL: https://github.com/apache/incubator-iotdb/pull/447 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-iotdb] qiaojialin closed pull request #446: exclude .mvn/wrapper/maven-wrapper.jar

2019-10-11 Thread GitBox
qiaojialin closed pull request #446: exclude .mvn/wrapper/maven-wrapper.jar URL: https://github.com/apache/incubator-iotdb/pull/446 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #433: [IOTDB-203]add "group by device" function for narrow table display

2019-10-11 Thread GitBox
LeiRui commented on a change in pull request #433: [IOTDB-203]add "group by device" function for narrow table display URL: https://github.com/apache/incubator-iotdb/pull/433#discussion_r334216526 ## File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.j

[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #433: [IOTDB-203]add "group by device" function for narrow table display

2019-10-11 Thread GitBox
LeiRui commented on a change in pull request #433: [IOTDB-203]add "group by device" function for narrow table display URL: https://github.com/apache/incubator-iotdb/pull/433#discussion_r334216535 ## File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.j

[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #433: [IOTDB-203]add "group by device" function for narrow table display

2019-10-11 Thread GitBox
LeiRui commented on a change in pull request #433: [IOTDB-203]add "group by device" function for narrow table display URL: https://github.com/apache/incubator-iotdb/pull/433#discussion_r334216535 ## File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.j

[GitHub] [incubator-iotdb] justinmclean commented on issue #447: [IOTDB-250] exclude .mvn/wrapper/maven-wrapper.jar

2019-10-11 Thread GitBox
justinmclean commented on issue #447: [IOTDB-250] exclude .mvn/wrapper/maven-wrapper.jar URL: https://github.com/apache/incubator-iotdb/pull/447#issuecomment-541276184 Not sure this fixes anything This is an automated message

[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #443: [IOTDB-240] fix unknown time series in where clause

2019-10-11 Thread GitBox
LeiRui commented on a change in pull request #443: [IOTDB-240] fix unknown time series in where clause URL: https://github.com/apache/incubator-iotdb/pull/443#discussion_r334215980 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -512,8 +512

[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #443: [IOTDB-240] fix unknown time series in where clause

2019-10-11 Thread GitBox
LeiRui commented on a change in pull request #443: [IOTDB-240] fix unknown time series in where clause URL: https://github.com/apache/incubator-iotdb/pull/443#discussion_r334217063 ## File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/optimizer/ConcatPathOptimizer.java

[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #443: [IOTDB-240] fix unknown time series in where clause

2019-10-11 Thread GitBox
LeiRui commented on a change in pull request #443: [IOTDB-240] fix unknown time series in where clause URL: https://github.com/apache/incubator-iotdb/pull/443#discussion_r334217520 ## File path: server/src/test/java/org/apache/iotdb/db/integration/IoTDBMultiSeriesIT.java #

[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #443: [IOTDB-240] fix unknown time series in where clause

2019-10-11 Thread GitBox
LeiRui commented on a change in pull request #443: [IOTDB-240] fix unknown time series in where clause URL: https://github.com/apache/incubator-iotdb/pull/443#discussion_r334215980 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -512,8 +512

[GitHub] [incubator-iotdb] LeiRui commented on issue #441: fix release tools

2019-10-11 Thread GitBox
LeiRui commented on issue #441: fix release tools URL: https://github.com/apache/incubator-iotdb/pull/441#issuecomment-541278127 > I would appreciate it if you give a detailed description of the problems (better with screenshots) and its root cause, the best if you issue it. As I hav

[GitHub] [incubator-iotdb] LeiRui commented on issue #441: fix release tools

2019-10-11 Thread GitBox
LeiRui commented on issue #441: fix release tools URL: https://github.com/apache/incubator-iotdb/pull/441#issuecomment-541278398 > I would appreciate it if you give a detailed description of the problems (better with screenshots) and its root cause, the best if you issue it. I propos

[GitHub] [incubator-iotdb] jixuan1989 commented on issue #447: [IOTDB-250] exclude .mvn/wrapper/maven-wrapper.jar

2019-10-11 Thread GitBox
jixuan1989 commented on issue #447: [IOTDB-250] exclude .mvn/wrapper/maven-wrapper.jar URL: https://github.com/apache/incubator-iotdb/pull/447#issuecomment-541291438 > Not sure this fixes anything I think this is just for avoiding someone upload the file to the repo... No help for f

[GitHub] [incubator-iotdb] Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance

2019-10-11 Thread GitBox
Ring-k commented on a change in pull request #440: reconstruct antlrv3 grammar to improve performance URL: https://github.com/apache/incubator-iotdb/pull/440#discussion_r334224374 ## File path: server/src/main/antlr3/org/apache/iotdb/db/sql/parse/TqlParser.g ## @@ -0,0 +1,