[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1452: Fix logic of creating MTree snapshot

sonarcloud[bot] commented on pull request #1452: URL: https://github.com/apache/incubator-iotdb/pull/1452#issuecomment-652993552 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=BUG)

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1451: [IOTDB-787] set thrift and antlr as two independent module

qiaojialin commented on a change in pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#discussion_r448978462 ## File path: jdbc/src/test/java/org/apache/iotdb/jdbc/manualtest/CompleteFutureTest.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1451: [IOTDB-787] set thrift and antlr as two independent module

sonarcloud[bot] removed a comment on pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#issuecomment-652885518 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1451: [IOTDB-787] set thrift and antlr as two independent module

sonarcloud[bot] commented on pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#issuecomment-652989109 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk

sonarcloud[bot] commented on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-652983061 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk

sonarcloud[bot] removed a comment on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-652403428 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1453: [IoTDB-786]refactor the thrift rpc service to reduce duplicate codes of RPC and Sync module

sonarcloud[bot] commented on pull request #1453: URL: https://github.com/apache/incubator-iotdb/pull/1453#issuecomment-653008693 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG)

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1451: [IOTDB-787] set thrift and antlr as two independent module

jixuan1989 commented on a change in pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#discussion_r449023058 ## File path: jdbc/src/test/java/org/apache/iotdb/jdbc/manualtest/JDBCRegisterManyTimeSeries.java ## @@ -0,0 +1,75 @@ +/* + * Licensed to the

[GitHub] [incubator-iotdb] SilverNarcissus commented on a change in pull request #1448: [IOTDB-716] add lZ4 compress method

SilverNarcissus commented on a change in pull request #1448: URL: https://github.com/apache/incubator-iotdb/pull/1448#discussion_r449116645 ## File path: tsfile/pom.xml ## @@ -53,6 +53,11 @@ commons-io commons-io + +

[GitHub] [incubator-iotdb] LebronAl opened a new pull request #1454: [Distributed] fix thrift_max_frame_size bug && add thrift_init_buffer_size config

LebronAl opened a new pull request #1454: URL: https://github.com/apache/incubator-iotdb/pull/1454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1451: [IOTDB-787] set thrift and antlr as two independent module

sonarcloud[bot] removed a comment on pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#issuecomment-652989109 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1451: [IOTDB-787] set thrift and antlr as two independent module

sonarcloud[bot] commented on pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#issuecomment-653093422 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1453: [IoTDB-786]refactor the thrift rpc service to reduce duplicate codes of RPC and Sync module

sonarcloud[bot] commented on pull request #1453: URL: https://github.com/apache/incubator-iotdb/pull/1453#issuecomment-653272694 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1453: [IoTDB-786]refactor the thrift rpc service to reduce duplicate codes of RPC and Sync module

sonarcloud[bot] removed a comment on pull request #1453: URL: https://github.com/apache/incubator-iotdb/pull/1453#issuecomment-653008693 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-652924550 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-653308979 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-653320476 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-653308979 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] Ring-k opened a new pull request #1457: delete timeseries when path is not found

Ring-k opened a new pull request #1457: URL: https://github.com/apache/incubator-iotdb/pull/1457 Problem >>> If the DeleteTimeseriesPlan is routed globally and the metadata is removed, and the other node needs to retrieve the full paths, then the metadata is nowhere to be found.

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-653361804 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-653320476 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] SailVR opened a new pull request #1455: [IOTDB-774]Fix "show timeseries" OOM problem

SailVR opened a new pull request #1455: URL: https://github.com/apache/incubator-iotdb/pull/1455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] SailVR closed pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem

SailVR closed pull request #1443: URL: https://github.com/apache/incubator-iotdb/pull/1443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-iotdb] qiaojialin merged pull request #1451: [IOTDB-787] set thrift and antlr as two independent module

qiaojialin merged pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] HTHou opened a new pull request #1456: Fix a stop upgrade service bug

HTHou opened a new pull request #1456: URL: https://github.com/apache/incubator-iotdb/pull/1456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1456: Fix a stop upgrade service bug

sonarcloud[bot] commented on pull request #1456: URL: https://github.com/apache/incubator-iotdb/pull/1456#issuecomment-653325983 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1457: delete timeseries when path is not found

sonarcloud[bot] commented on pull request #1457: URL: https://github.com/apache/incubator-iotdb/pull/1457#issuecomment-653336478 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=BUG)

[GitHub] [incubator-iotdb] JackieTien97 merged pull request #1455: [IOTDB-774]Fix "show timeseries" OOM problem

JackieTien97 merged pull request #1455: URL: https://github.com/apache/incubator-iotdb/pull/1455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] jt2594838 merged pull request #1454: [Distributed] fix thrift_max_frame_size bug && add thrift_init_buffer_size config && fix instanceof insertplan

jt2594838 merged pull request #1454: URL: https://github.com/apache/incubator-iotdb/pull/1454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1326: premerge for the distributed version

sonarcloud[bot] removed a comment on pull request #1326: URL: https://github.com/apache/incubator-iotdb/pull/1326#issuecomment-652774640 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1326: premerge for the distributed version

sonarcloud[bot] commented on pull request #1326: URL: https://github.com/apache/incubator-iotdb/pull/1326#issuecomment-653298176 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-652924550 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-651717783 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG)

[GitHub] [incubator-iotdb] SailVR edited a comment on pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem

SailVR edited a comment on pull request #1443: URL: https://github.com/apache/incubator-iotdb/pull/1443#issuecomment-652152738 > > Good job. > > However, what will happen if the user defined limit is larger than the fetch size? It seems that you didn't deal with this case in your code.

[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1450: add insertStringRecord rpc method

qiaojialin opened a new pull request #1450: URL: https://github.com/apache/incubator-iotdb/pull/1450 Remove inferType in RPC and extract insertStringRecord from insertRecord This is an automated message from the Apache Git

[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #1451: [IOTDB-787] set thrift and antlr as two independent module

jixuan1989 opened a new pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451 As discussed in https://lists.apache.org/thread.html/rd776647235c16c67db732e104a7eedda8e7b654d2d368462e586adf6%40%3Cdev.iotdb.apache.org%3E We will extract the thrift.thrift and

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1448: [IOTDB-716] add lZ4 compress method

HTHou commented on a change in pull request #1448: URL: https://github.com/apache/incubator-iotdb/pull/1448#discussion_r448808695 ## File path: tsfile/pom.xml ## @@ -53,6 +53,11 @@ commons-io commons-io + +net.jpountz.lz4

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1448: [IOTDB-716] add lZ4 compress method

HTHou commented on a change in pull request #1448: URL: https://github.com/apache/incubator-iotdb/pull/1448#discussion_r448808695 ## File path: tsfile/pom.xml ## @@ -53,6 +53,11 @@ commons-io commons-io + +net.jpountz.lz4

[GitHub] [incubator-iotdb] jt2594838 merged pull request #1441: [distributed] change log to asynchronous & add thrift max frame size & fix the InterruptedException bug

jt2594838 merged pull request #1441: URL: https://github.com/apache/incubator-iotdb/pull/1441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #1453: [IoTDB-786]refactor the thrift rpc service to reduce duplicate codes of RPC and Sync module

jixuan1989 opened a new pull request #1453: URL: https://github.com/apache/incubator-iotdb/pull/1453 In this case, we do not need to maintain the two modules separately (to reduce the probability that one is fine but the other has bugs).

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1400: [IOTDB-627]Support range deletion for timeseries

qiaojialin commented on a change in pull request #1400: URL: https://github.com/apache/incubator-iotdb/pull/1400#discussion_r448842280 ## File path: server/src/main/java/org/apache/iotdb/db/engine/modification/io/LocalTextModificationAccessor.java ## @@ -124,28 +124,42 @@

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1452: Fix logic of creating MTree snapshot

samperson1997 commented on a change in pull request #1452: URL: https://github.com/apache/incubator-iotdb/pull/1452#discussion_r448900901 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java ## @@ -1785,27 +1785,25 @@ private void checkMTreeModified()

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1452: Fix logic of creating MTree snapshot

samperson1997 commented on a change in pull request #1452: URL: https://github.com/apache/incubator-iotdb/pull/1452#discussion_r448900856 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java ## @@ -1785,27 +1785,25 @@ private void checkMTreeModified()

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1452: Fix logic of creating MTree snapshot

jixuan1989 commented on a change in pull request #1452: URL: https://github.com/apache/incubator-iotdb/pull/1452#discussion_r448898298 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java ## @@ -1785,27 +1785,25 @@ private void checkMTreeModified() {

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1450: add insertStringRecord rpc method

sonarcloud[bot] commented on pull request #1450: URL: https://github.com/apache/incubator-iotdb/pull/1450#issuecomment-652871934 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=BUG)

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1337: [IOTDB-746] Add async insertion interfaces in Session and SessionPool

HTHou commented on a change in pull request #1337: URL: https://github.com/apache/incubator-iotdb/pull/1337#discussion_r448860998 ## File path: docs/UserGuide/Client/Programming - Native API.md ## @@ -136,11 +145,11 @@ Here we show the commonly used interfaces and their

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1337: [IOTDB-746] Add async insertion interfaces in Session and SessionPool

HTHou commented on a change in pull request #1337: URL: https://github.com/apache/incubator-iotdb/pull/1337#discussion_r448861261 ## File path: docs/UserGuide/Client/Programming - Native API.md ## @@ -150,6 +159,38 @@ Here we show the commonly used interfaces and their

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1451: [IOTDB-787] set thrift and antlr as two independent module

sonarcloud[bot] commented on pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#issuecomment-652885518 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG)

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1400: [IOTDB-627]Support range deletion for timeseries

jt2594838 commented on a change in pull request #1400: URL: https://github.com/apache/incubator-iotdb/pull/1400#discussion_r448861552 ## File path: server/src/test/java/org/apache/iotdb/db/engine/merge/MergeTaskTest.java ## @@ -218,7 +218,7 @@ public void testPartialMerge3()

[GitHub] [incubator-iotdb] samperson1997 opened a new pull request #1452: Fix logic of creating MTree snapshot

samperson1997 opened a new pull request #1452: URL: https://github.com/apache/incubator-iotdb/pull/1452 Fix logic of creating MTree snapshot. The snapshot should only be created when `System.currentTimeMillis() - logFile.lastModified() >= mtreeSnapshotThresholdTime` AND

[GitHub] [incubator-iotdb] qiaojialin merged pull request #1450: add insertStringRecord rpc method

qiaojialin merged pull request #1450: URL: https://github.com/apache/incubator-iotdb/pull/1450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL