[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1821: [IOTDB-926] Support reconnection of Session

2020-10-19 Thread GitBox
sonarcloud[bot] commented on pull request #1821: URL: https://github.com/apache/iotdb/pull/1821#issuecomment-711789835 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1821=false=BUG)

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1821: [IOTDB-926] Support reconnection of Session

2020-10-19 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1821: URL: https://github.com/apache/iotdb/pull/1821#issuecomment-707067166 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1821=false=BUG)

[GitHub] [iotdb] Alima777 commented on a change in pull request #1824: [IOTDB-942] Optimization of query with long time unsequence page

2020-10-19 Thread GitBox
Alima777 commented on a change in pull request #1824: URL: https://github.com/apache/iotdb/pull/1824#discussion_r507544971 ## File path: server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java ## @@ -407,11 +409,15 @@ boolean hasNextPage() throws

[GitHub] [iotdb] Alima777 commented on a change in pull request #1824: [IOTDB-942] Optimization of query with long time unsequence page

2020-10-19 Thread GitBox
Alima777 commented on a change in pull request #1824: URL: https://github.com/apache/iotdb/pull/1824#discussion_r507544732 ## File path: server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java ## @@ -870,12 +963,31 @@ public TsFileResource

[GitHub] [iotdb] samperson1997 commented on a change in pull request #1824: [IOTDB-942] Optimization of query with long time unsequence page

2020-10-19 Thread GitBox
samperson1997 commented on a change in pull request #1824: URL: https://github.com/apache/iotdb/pull/1824#discussion_r507483827 ## File path: server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java ## @@ -931,11 +1043,31 @@ public TsFileResource

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-10-19 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/iotdb/pull/1524#issuecomment-711586015 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG)

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-10-19 Thread GitBox
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/iotdb/pull/1524#issuecomment-711655977 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG)

[GitHub] [iotdb] Alima777 commented on a change in pull request #1824: [IOTDB-942] Optimization of query with long time unsequence page

2020-10-19 Thread GitBox
Alima777 commented on a change in pull request #1824: URL: https://github.com/apache/iotdb/pull/1824#discussion_r507545531 ## File path: server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java ## @@ -381,19 +383,19 @@ boolean hasNextPage() throws

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-10-19 Thread GitBox
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/iotdb/pull/1524#issuecomment-711753901 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG)

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-10-19 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/iotdb/pull/1524#issuecomment-711655977 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG)

[GitHub] [iotdb] neuyilan commented on a change in pull request #1821: [IOTDB-926] Support reconnection of Session

2020-10-19 Thread GitBox
neuyilan commented on a change in pull request #1821: URL: https://github.com/apache/iotdb/pull/1821#discussion_r507503528 ## File path: session/src/main/java/org/apache/iotdb/session/Session.java ## @@ -239,7 +244,15 @@ public void insertTablet(Tablet tablet, boolean sorted)

[GitHub] [iotdb] qiaojialin merged pull request #1832: [IOTDB-947] Fix error when counting node with wildcard

2020-10-19 Thread GitBox
qiaojialin merged pull request #1832: URL: https://github.com/apache/iotdb/pull/1832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1821: [IOTDB-926] Support reconnection of Session

2020-10-19 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1821: URL: https://github.com/apache/iotdb/pull/1821#issuecomment-711789835 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1821=false=BUG)

[GitHub] [iotdb] qiaojialin merged pull request #1784: [IOTDB-921] Solve the statement twice call bug

2020-10-19 Thread GitBox
qiaojialin merged pull request #1784: URL: https://github.com/apache/iotdb/pull/1784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [iotdb] Alima777 commented on a change in pull request #1824: [IOTDB-942] Optimization of query with long time unsequence page

2020-10-19 Thread GitBox
Alima777 commented on a change in pull request #1824: URL: https://github.com/apache/iotdb/pull/1824#discussion_r507684846 ## File path: server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java ## @@ -816,8 +901,16 @@ boolean isModified() {

[GitHub] [iotdb] tieredblocks commented on issue #1804: Small recommendation in IoTDBConnection

2020-10-19 Thread GitBox
tieredblocks commented on issue #1804: URL: https://github.com/apache/iotdb/issues/1804#issuecomment-712106477 Sure, will do this and upload the forked code This is an automated message from the Apache Git Service. To

[GitHub] [iotdb] JackieTien97 commented on a change in pull request #1821: [IOTDB-926] Support reconnection of Session

2020-10-19 Thread GitBox
JackieTien97 commented on a change in pull request #1821: URL: https://github.com/apache/iotdb/pull/1821#discussion_r507696974 ## File path: session/src/main/java/org/apache/iotdb/session/Config.java ## @@ -24,5 +24,6 @@ public static final String DEFAULT_PASSWORD =

[GitHub] [iotdb] samperson1997 commented on a change in pull request #1824: [IOTDB-942] Optimization of query with long time unsequence page

2020-10-19 Thread GitBox
samperson1997 commented on a change in pull request #1824: URL: https://github.com/apache/iotdb/pull/1824#discussion_r507679196 ## File path: server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java ## @@ -816,8 +901,16 @@ boolean isModified() {

[GitHub] [iotdb] JulianFeinauer commented on a change in pull request #1793: IOTDB-932 Removed (wrong and redundant) Verification of Paths in Sess…

2020-10-19 Thread GitBox
JulianFeinauer commented on a change in pull request #1793: URL: https://github.com/apache/iotdb/pull/1793#discussion_r507632599 ## File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java ## @@ -1649,15 +1632,6 @@ protected TSStatus

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-10-19 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/iotdb/pull/1524#issuecomment-711753901 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG)

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

2020-10-19 Thread GitBox
sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/iotdb/pull/1524#issuecomment-712019150 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1524=false=BUG)

[GitHub] [iotdb] samperson1997 opened a new pull request #1834: [Sonar Test] add device chunk point cache

2020-10-19 Thread GitBox
samperson1997 opened a new pull request #1834: URL: https://github.com/apache/iotdb/pull/1834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [iotdb] qiaojialin merged pull request #1785: [IOTDB-928] Make ENCODING optional in create time series sentence

2020-10-19 Thread GitBox
qiaojialin merged pull request #1785: URL: https://github.com/apache/iotdb/pull/1785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [iotdb] qiaojialin commented on pull request #1765: Add readChunksInDevice method to TsFileSequenceReader

2020-10-19 Thread GitBox
qiaojialin commented on pull request #1765: URL: https://github.com/apache/iotdb/pull/1765#issuecomment-712162152 please add some test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [iotdb] SteveYurongSu commented on pull request #1765: Add readChunksInDevice method to TsFileSequenceReader

2020-10-19 Thread GitBox
SteveYurongSu commented on pull request #1765: URL: https://github.com/apache/iotdb/pull/1765#issuecomment-712299284 > please add some test added :D This is an automated message from the Apache Git Service. To respond

[GitHub] [iotdb] samperson1997 commented on a change in pull request #1758: add device chunk point cache

2020-10-19 Thread GitBox
samperson1997 commented on a change in pull request #1758: URL: https://github.com/apache/iotdb/pull/1758#discussion_r507688530 ## File path: server/src/main/java/org/apache/iotdb/db/engine/tsfilemanagement/level/LevelTsFileManagement.java ## @@ -31,29 +31,36 @@ import

[GitHub] [iotdb] samperson1997 closed pull request #1834: [Sonar Test] add device chunk point cache

2020-10-19 Thread GitBox
samperson1997 closed pull request #1834: URL: https://github.com/apache/iotdb/pull/1834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [iotdb] yhwangBonc opened a new pull request #1835: rm update in md

2020-10-19 Thread GitBox
yhwangBonc opened a new pull request #1835: URL: https://github.com/apache/iotdb/pull/1835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [iotdb] Alima777 commented on a change in pull request #1367: [IOTDB-749] Handle select * from root OOM

2020-10-19 Thread GitBox
Alima777 commented on a change in pull request #1367: URL: https://github.com/apache/iotdb/pull/1367#discussion_r508169315 ## File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/optimizer/ConcatPathOptimizer.java ## @@ -180,34 +192,26 @@ private void

[GitHub] [iotdb] neuyilan commented on pull request #1835: rm update in md

2020-10-19 Thread GitBox
neuyilan commented on pull request #1835: URL: https://github.com/apache/iotdb/pull/1835#issuecomment-712551192 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [iotdb] neuyilan edited a comment on pull request #1835: rm update in md

2020-10-19 Thread GitBox
neuyilan edited a comment on pull request #1835: URL: https://github.com/apache/iotdb/pull/1835#issuecomment-712551192 LGTM, It would be nice to delete the corresponding code as well, but this can be done by the next PR.

[GitHub] [iotdb] SteveYurongSu commented on pull request #1828: [IOTDB-944] Support UDTF (User-defined Timeseries Generating Function)

2020-10-19 Thread GitBox
SteveYurongSu commented on pull request #1828: URL: https://github.com/apache/iotdb/pull/1828#issuecomment-712554101 Product Requirement Doc (Chinese): https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=165221503 Design Doc (Chinese):

[GitHub] [iotdb] neuyilan opened a new pull request #1836: [IOTDB-948] Use binary search when checking the follower's match index when catchup

2020-10-19 Thread GitBox
neuyilan opened a new pull request #1836: URL: https://github.com/apache/iotdb/pull/1836 Now, when the follower lags behind the leader a lot, one catchup task will be triggered. When catchup, it will judge whether a certain log saved in the leader's memory is consistent with the follower.

[GitHub] [iotdb] HTHou merged pull request #1835: rm update in md

2020-10-19 Thread GitBox
HTHou merged pull request #1835: URL: https://github.com/apache/iotdb/pull/1835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [iotdb] yhwangBonc commented on pull request #1835: rm update in md

2020-10-19 Thread GitBox
yhwangBonc commented on pull request #1835: URL: https://github.com/apache/iotdb/pull/1835#issuecomment-712564196 > LGTM, It would be nice to delete the corresponding code as well, but this can be done by the next PR. Ok, I got it.

[GitHub] [iotdb] jixuan1989 commented on a change in pull request #1796: [IOTDB-886]fix float loss precision

2020-10-19 Thread GitBox
jixuan1989 commented on a change in pull request #1796: URL: https://github.com/apache/iotdb/pull/1796#discussion_r508130935 ## File path: server/src/main/java/org/apache/iotdb/db/utils/TypeInferenceUtils.java ## @@ -63,6 +69,9 @@ public static TSDataType

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #1367: [IOTDB-749] Handle select * from root OOM

2020-10-19 Thread GitBox
sonarcloud[bot] removed a comment on pull request #1367: URL: https://github.com/apache/iotdb/pull/1367#issuecomment-707554673 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1367=false=BUG)

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #1367: [IOTDB-749] Handle select * from root OOM

2020-10-19 Thread GitBox
sonarcloud[bot] commented on pull request #1367: URL: https://github.com/apache/iotdb/pull/1367#issuecomment-712530919 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1367=false=BUG)