[GitHub] Beyyes commented on a change in pull request #31: Fix sonar

2019-01-27 Thread GitBox
Beyyes commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251306760 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineExecutorWithoutTimeGenerator.java ## @@ -71,33 +71,50 @@

[GitHub] Beyyes commented on a change in pull request #33: Fix sonar problems

2019-01-27 Thread GitBox
Beyyes commented on a change in pull request #33: Fix sonar problems URL: https://github.com/apache/incubator-iotdb/pull/33#discussion_r251302827 ## File path: iotdb/src/main/java/org/apache/iotdb/db/auth/authorizer/BasicAuthorizer.java ## @@ -238,6 +240,7 @@ public void

[GitHub] Beyyes commented on a change in pull request #33: Fix sonar problems

2019-01-28 Thread GitBox
Beyyes commented on a change in pull request #33: Fix sonar problems URL: https://github.com/apache/incubator-iotdb/pull/33#discussion_r251302827 ## File path: iotdb/src/main/java/org/apache/iotdb/db/auth/authorizer/BasicAuthorizer.java ## @@ -238,6 +240,7 @@ public void

[GitHub] kr11 commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
kr11 commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251418637 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineExecutorWithTimeGenerator.java ## @@ -59,18 +59,24 @@ *

[GitHub] jixuan1989 commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
jixuan1989 commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251423647 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineExecutorWithoutTimeGenerator.java ## @@ -71,33 +71,50 @@

[GitHub] jixuan1989 commented on issue #31: Fix sonar

2019-01-28 Thread GitBox
jixuan1989 commented on issue #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#issuecomment-458156997 This PR has passed the jenkins pipeline: https://builds.apache.org/job/IoTDB-Pipeline/job/fix_sonar/7 Does anyone has comments for this PR? If not, I will

[GitHub] fanhualta commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
fanhualta commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251406494 ## File path: iotdb/src/main/java/org/apache/iotdb/db/postback/conf/PostBackSenderConfig.java ## @@ -1,19 +1,15 @@ /** - * Licensed

[GitHub] fanhualta commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
fanhualta commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251406533 ## File path: iotdb/src/main/java/org/apache/iotdb/db/postback/conf/PostBackSenderDescriptor.java ## @@ -87,46 +83,42 @@ private

[GitHub] fanhualta commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
fanhualta commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251406460 ## File path: iotdb/src/main/java/org/apache/iotdb/db/postback/conf/PostBackSenderDescriptor.java ## @@ -87,46 +83,42 @@ private

[GitHub] kr11 commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
kr11 commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251419201 ## File path: iotdb/src/main/java/org/apache/iotdb/db/service/IoTDB.java ## @@ -168,6 +169,8 @@ private void systemDataRecovery() throws

[GitHub] jixuan1989 commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
jixuan1989 commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251461180 ## File path: iotdb/src/main/java/org/apache/iotdb/db/postback/utils/CreateDataSender1.java ## @@ -53,6 +58,7 @@ private static

[GitHub] kr11 commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
kr11 commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251228850 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineQueryRouter.java ## @@ -73,18 +73,14 @@ public QueryDataSet

[GitHub] kr11 commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
kr11 commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251411639 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineQueryRouter.java ## @@ -73,18 +73,14 @@ public QueryDataSet

[GitHub] jixuan1989 commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
jixuan1989 commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251472263 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineExecutorWithoutTimeGenerator.java ## @@ -71,33 +71,50 @@

[GitHub] jixuan1989 merged pull request #31: Fix sonar

2019-01-28 Thread GitBox
jixuan1989 merged pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] fanhualta commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
fanhualta commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251406589 ## File path: iotdb/src/test/java/org/apache/iotdb/db/postback/sender/FileManagerTest.java ## @@ -55,20 +56,19 @@ public void

[GitHub] fanhualta commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
fanhualta commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251406638 ## File path: iotdb/src/test/java/org/apache/iotdb/db/postback/sender/FileManagerTest.java ## @@ -368,7 +364,7 @@ public void

[GitHub] fanhualta commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
fanhualta commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251406922 ## File path: iotdb/src/main/java/org/apache/iotdb/db/postback/conf/PostBackSenderDescriptor.java ## @@ -87,46 +87,42 @@ private

[GitHub] fanhualta commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
fanhualta commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251406869 ## File path: iotdb/src/main/java/org/apache/iotdb/db/postback/conf/PostBackSenderDescriptor.java ## @@ -87,46 +87,42 @@ private

[GitHub] kr11 commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
kr11 commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251409147 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineExecutorWithoutTimeGenerator.java ## @@ -71,33 +71,50 @@

[GitHub] kr11 commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
kr11 commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251404197 ## File path: iotdb/src/main/java/org/apache/iotdb/db/postback/receiver/ServerServiceImpl.java ## @@ -320,318 +331,298 @@ public void

[GitHub] fanhualta commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
fanhualta commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251407138 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/control/FileReaderManager.java ## @@ -196,5 +197,7 @@ public ServiceType

[GitHub] fanhualta commented on a change in pull request #31: Fix sonar

2019-01-28 Thread GitBox
fanhualta commented on a change in pull request #31: Fix sonar URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251407053 ## File path: iotdb/src/main/java/org/apache/iotdb/db/postback/utils/CreateDataSender1.java ## @@ -53,6 +58,7 @@ private static

[GitHub] EJTTianYu opened a new pull request #35: Fix sonar tianyu

2019-01-28 Thread GitBox
EJTTianYu opened a new pull request #35: Fix sonar tianyu URL: https://github.com/apache/incubator-iotdb/pull/35 fix sonar by gouwangminhao This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-iotdb] wujysh opened a new pull request #127: Minor modification of README.md

2019-04-01 Thread GitBox
wujysh opened a new pull request #127: Minor modification of README.md URL: https://github.com/apache/incubator-iotdb/pull/127 - Remove extra spaces and add missing ones - Recommend to use `mvnw` This is an automated

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #123: provide unified query resource control interface

2019-04-02 Thread GitBox
jt2594838 commented on a change in pull request #123: provide unified query resource control interface URL: https://github.com/apache/incubator-iotdb/pull/123#discussion_r271148954 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/control/QueryResourceManager.java

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #123: provide unified query resource control interface

2019-04-02 Thread GitBox
jt2594838 commented on a change in pull request #123: provide unified query resource control interface URL: https://github.com/apache/incubator-iotdb/pull/123#discussion_r271148954 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/control/QueryResourceManager.java

[GitHub] [incubator-iotdb] little-emotion commented on a change in pull request #123: provide unified query resource control interface

2019-04-02 Thread GitBox
little-emotion commented on a change in pull request #123: provide unified query resource control interface URL: https://github.com/apache/incubator-iotdb/pull/123#discussion_r271241580 ## File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java ## @@

[GitHub] [incubator-iotdb] jixuan1989 merged pull request #117: move all generated tsfiles for test into the target folder

2019-03-29 Thread GitBox
jixuan1989 merged pull request #117: move all generated tsfiles for test into the target folder URL: https://github.com/apache/incubator-iotdb/pull/117 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-iotdb] jixuan1989 merged pull request #120: [IOTDB-70][IOTDB-71]fix jira issue 70 71

2019-03-29 Thread GitBox
jixuan1989 merged pull request #120: [IOTDB-70][IOTDB-71]fix jira issue 70 71 URL: https://github.com/apache/incubator-iotdb/pull/120 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-iotdb] jixuan1989 commented on issue #121: fix long size

2019-03-29 Thread GitBox
jixuan1989 commented on issue #121: fix long size URL: https://github.com/apache/incubator-iotdb/pull/121#issuecomment-478032568 +1. But this printf is meaningless for automatically UT.. This is an automated message from

[GitHub] [incubator-iotdb] sontallive opened a new pull request #128: fix a doc bug of Readme.md

2019-04-02 Thread GitBox
sontallive opened a new pull request #128: fix a doc bug of Readme.md URL: https://github.com/apache/incubator-iotdb/pull/128 fix a doc bug the **tsile** should be **tsfile** This is an automated message from the Apache

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #123: provide unified query resource control interface

2019-04-02 Thread GitBox
jt2594838 commented on a change in pull request #123: provide unified query resource control interface URL: https://github.com/apache/incubator-iotdb/pull/123#discussion_r271286958 ## File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java ## @@

[GitHub] [incubator-iotdb] MyXOF commented on issue #128: fix a doc bug of Readme.md

2019-04-02 Thread GitBox
MyXOF commented on issue #128: fix a doc bug of Readme.md URL: https://github.com/apache/incubator-iotdb/pull/128#issuecomment-478996507 Thanks for your contribution! This is an automated message from the Apache Git Service.

[GitHub] [incubator-iotdb] MyXOF merged pull request #128: fix a doc bug of Readme.md

2019-04-02 Thread GitBox
MyXOF merged pull request #128: fix a doc bug of Readme.md URL: https://github.com/apache/incubator-iotdb/pull/128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-iotdb] MyXOF commented on issue #127: Minor modification of README.md

2019-04-02 Thread GitBox
MyXOF commented on issue #127: Minor modification of README.md URL: https://github.com/apache/incubator-iotdb/pull/127#issuecomment-479023189 Hi I suppose we should unify the description between readme.md and quick-start page on website. I prefer syncing them up. Since them are

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #123: provide unified query resource control interface

2019-04-02 Thread GitBox
jixuan1989 commented on a change in pull request #123: provide unified query resource control interface URL: https://github.com/apache/incubator-iotdb/pull/123#discussion_r271315958 ## File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java ## @@

[GitHub] [incubator-iotdb] wujysh commented on issue #127: Minor modification of README.md

2019-04-02 Thread GitBox
wujysh commented on issue #127: Minor modification of README.md URL: https://github.com/apache/incubator-iotdb/pull/127#issuecomment-479016858 Hi, some questions: - The quick start on readme.md is not identical to the quick start on official website. Should we remove it on

[GitHub] [incubator-iotdb] MyXOF commented on issue #122: Warm log for Overflow Exception

2019-04-02 Thread GitBox
MyXOF commented on issue #122: Warm log for Overflow Exception URL: https://github.com/apache/incubator-iotdb/pull/122#issuecomment-478998303 Anyone merges this pr? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-iotdb] liukun4515 opened a new pull request #122: Warm log for Overflow Exception

2019-03-31 Thread GitBox
liukun4515 opened a new pull request #122: Warm log for Overflow Exception URL: https://github.com/apache/incubator-iotdb/pull/122 Jira issue: https://issues.apache.org/jira/browse/IOTDB-44 https://issues.apache.org/jira/browse/IOTDB-46

[GitHub] [incubator-iotdb] jt2594838 opened a new pull request #123: provide unified query resource control interface

2019-03-31 Thread GitBox
jt2594838 opened a new pull request #123: provide unified query resource control interface URL: https://github.com/apache/incubator-iotdb/pull/123 Previous query resource control involves calling methods in several different classes, which increases the difficulty of maintenance. All

[GitHub] [incubator-iotdb] liukun4515 merged pull request #122: Warm log for Overflow Exception

2019-04-02 Thread GitBox
liukun4515 merged pull request #122: Warm log for Overflow Exception URL: https://github.com/apache/incubator-iotdb/pull/122 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-iotdb] wujysh commented on issue #127: Minor modification of README.md

2019-04-02 Thread GitBox
wujysh commented on issue #127: Minor modification of README.md URL: https://github.com/apache/incubator-iotdb/pull/127#issuecomment-479311536 @jixuan1989 I have update the changes. Let me know if you have other concerns. Thanks.

[GitHub] [incubator-iotdb] FLOW4215 opened a new pull request #129: [IOTDB-37]A WAL check tool script is desired

2019-04-03 Thread GitBox
FLOW4215 opened a new pull request #129: [IOTDB-37]A WAL check tool script is desired URL: https://github.com/apache/incubator-iotdb/pull/129 upload start walchecker script into /iotdb/bin start-WalChecker.sh and start-WalChecker.bat

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267610511 ## File path:

[GitHub] [incubator-iotdb] jt2594838 commented on issue #103: fix channel close bug in merge process

2019-03-20 Thread GitBox
jt2594838 commented on issue #103: fix channel close bug in merge process URL: https://github.com/apache/incubator-iotdb/pull/103#issuecomment-475097054 LGTM This is an automated message from the Apache Git Service. To

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267612594 ## File path:

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #107: [IOTDB-50]fix bug IOTDB-50

2019-03-21 Thread GitBox
Beyyes commented on a change in pull request #107: [IOTDB-50]fix bug IOTDB-50 URL: https://github.com/apache/incubator-iotdb/pull/107#discussion_r267648143 ## File path: tsfile/src/test/java/org/apache/iotdb/tsfile/read/ReadOnlyTsFileTest.java ## @@ -111,6 +106,38 @@

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #107: [IOTDB-50]fix bug IOTDB-50

2019-03-21 Thread GitBox
Beyyes commented on a change in pull request #107: [IOTDB-50]fix bug IOTDB-50 URL: https://github.com/apache/incubator-iotdb/pull/107#discussion_r267648247 ## File path: tsfile/src/test/java/org/apache/iotdb/tsfile/utils/TsFileGeneratorForTest.java ## @@ -108,7 +113,7 @@

[GitHub] [incubator-iotdb] jixuan1989 commented on issue #100: [IOTDB-39]Refactor auto repair for TsFile reader and TsFile writer

2019-03-20 Thread GitBox
jixuan1989 commented on issue #100: [IOTDB-39]Refactor auto repair for TsFile reader and TsFile writer URL: https://github.com/apache/incubator-iotdb/pull/100#issuecomment-475086493 > Hi @jixuan1989 you code looks code and my only point is very minor. But overall I do not like the

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267608549 ## File path:

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267608549 ## File path:

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #105: [IOTDB-56] faster memtable.getSortedTimeValuePairList

2019-03-20 Thread GitBox
jt2594838 commented on a change in pull request #105: [IOTDB-56] faster memtable.getSortedTimeValuePairList URL: https://github.com/apache/incubator-iotdb/pull/105#discussion_r267613440 ## File path: iotdb/src/main/java/org/apache/iotdb/db/engine/memtable/WritableMemChunk.java

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267612695 ## File path:

[GitHub] [incubator-iotdb] little-emotion opened a new pull request #107: [IOTDB-50]fix bug IOTDB-50

2019-03-21 Thread GitBox
little-emotion opened a new pull request #107: [IOTDB-50]fix bug IOTDB-50 URL: https://github.com/apache/incubator-iotdb/pull/107 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #100: [IOTDB-39]Refactor auto repair for TsFile reader and TsFile writer

2019-03-20 Thread GitBox
jixuan1989 commented on a change in pull request #100: [IOTDB-39]Refactor auto repair for TsFile reader and TsFile writer URL: https://github.com/apache/incubator-iotdb/pull/100#discussion_r267603651 ## File path:

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267612594 ## File path:

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267613015 ## File path:

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267607779 ## File path:

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267609452 ## File path:

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267609279 ## File path:

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267612594 ## File path:

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267615605 ## File path:

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
jt2594838 commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267607646 ## File path:

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module

2019-03-20 Thread GitBox
fanhualta commented on a change in pull request #101: [IOTDB-51]Reimplement post-back module, rename it to synchronization module URL: https://github.com/apache/incubator-iotdb/pull/101#discussion_r267613873 ## File path:

[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #111: try to release memory asap in ReadOnlyMemChunk

2019-03-25 Thread GitBox
jixuan1989 opened a new pull request #111: try to release memory asap in ReadOnlyMemChunk URL: https://github.com/apache/incubator-iotdb/pull/111 In `ReadOnlyMemChunk`, the memSeries is useless after calling `init()`, so I set it to null to let GC collect it asap.

[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #110: change FileChannel to TsFileInput for the future use of tsfile-spark-conn…

2019-03-25 Thread GitBox
LeiRui commented on a change in pull request #110: change FileChannel to TsFileInput for the future use of tsfile-spark-conn… URL: https://github.com/apache/incubator-iotdb/pull/110#discussion_r268928814 ## File path:

[GitHub] [incubator-iotdb] Beyyes commented on issue #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-25 Thread GitBox
Beyyes commented on issue #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#issuecomment-476439927 Aggregate and groupby performance experiment results should be showed.

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #110: change FileChannel to TsFileInput for the future use of tsfile-spark-conn…

2019-03-25 Thread GitBox
jixuan1989 commented on a change in pull request #110: change FileChannel to TsFileInput for the future use of tsfile-spark-conn… URL: https://github.com/apache/incubator-iotdb/pull/110#discussion_r268908647 ## File path:

[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #110: change FileChannel to TsFileInput for the future use of tsfile-spark-conn…

2019-03-25 Thread GitBox
LeiRui commented on a change in pull request #110: change FileChannel to TsFileInput for the future use of tsfile-spark-conn… URL: https://github.com/apache/incubator-iotdb/pull/110#discussion_r268917883 ## File path:

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #110: change FileChannel to TsFileInput for the future use of tsfile-spark-conn…

2019-03-25 Thread GitBox
jixuan1989 commented on a change in pull request #110: change FileChannel to TsFileInput for the future use of tsfile-spark-conn… URL: https://github.com/apache/incubator-iotdb/pull/110#discussion_r268925842 ## File path:

[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #112: [IOTDB-62]set SQL parse error as debug level log; fix some sonar issues

2019-03-25 Thread GitBox
jixuan1989 opened a new pull request #112: [IOTDB-62]set SQL parse error as debug level log; fix some sonar issues URL: https://github.com/apache/incubator-iotdb/pull/112 This is an automated message from the Apache Git

[GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269486551 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] MyXOF merged pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
MyXOF merged pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-iotdb] MyXOF commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
MyXOF commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269478041 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] MyXOF commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
MyXOF commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269477758 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269480675 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269480303 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] mdf369 edited a comment on issue #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 edited a comment on issue #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#issuecomment-477076324 test coverage: ![屏幕快照 2019-03-27 下午6 02

[GitHub] [incubator-iotdb] mdf369 commented on issue #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 commented on issue #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#issuecomment-477076324 test coverage: ![屏幕快照 2019-03-27 下午6 02

[GitHub] [incubator-iotdb] mdf369 opened a new pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
mdf369 opened a new pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114 Add a method to check whether a input path has already been set to storage level or not. This method will be used in Cluster module. It helps a node

[GitHub] [incubator-iotdb] MyXOF commented on a change in pull request #114: add check SG for MManager, MGraph and MTree

2019-03-27 Thread GitBox
MyXOF commented on a change in pull request #114: add check SG for MManager, MGraph and MTree URL: https://github.com/apache/incubator-iotdb/pull/114#discussion_r269481324 ## File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -212,6 +212,34 @@

[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #113: [IOTDB-67] call valueDecoder reset() when reading data from a new Page

2019-03-26 Thread GitBox
jixuan1989 opened a new pull request #113: [IOTDB-67] call valueDecoder reset() when reading data from a new Page URL: https://github.com/apache/incubator-iotdb/pull/113 tsfile/example/src/main/java/org/apache/iotdb/tsfile/TsFileSequenceRead has a bug: if the data type is Float and

[GitHub] [incubator-iotdb] jixuan1989 merged pull request #112: [IOTDB-62]set SQL parse error as debug level log; fix some sonar issues

2019-03-26 Thread GitBox
jixuan1989 merged pull request #112: [IOTDB-62]set SQL parse error as debug level log; fix some sonar issues URL: https://github.com/apache/incubator-iotdb/pull/112 This is an automated message from the Apache Git Service.

[GitHub] [incubator-iotdb] jixuan1989 merged pull request #110: [IOTDB-63] Use TsFileInput instead of FileChannel as the parameter passed to methods

2019-03-26 Thread GitBox
jixuan1989 merged pull request #110: [IOTDB-63] Use TsFileInput instead of FileChannel as the parameter passed to methods URL: https://github.com/apache/incubator-iotdb/pull/110 This is an automated message from the Apache

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268921776 ## File path:

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268932498 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineQueryRouter.java

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268951847 ## File path:

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268951389 ## File path:

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268956961 ## File path:

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268956872 ## File path:

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268957467 ## File path:

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268950743 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/GroupByEngine.java

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268925973 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/GroupByEngine.java

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268920037 ## File path: tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/BatchData.java

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268958594 ## File path:

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268926105 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/GroupByEngine.java

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268926495 ## File path:

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268926413 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/GroupByEngine.java

[GitHub] [incubator-iotdb] Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill

2019-03-26 Thread GitBox
Beyyes commented on a change in pull request #97: [IOTDB-47][IOTDB-54][IOTDB-59][IOTDB-60]Aggregate+GroupBy+Fill URL: https://github.com/apache/incubator-iotdb/pull/97#discussion_r268931066 ## File path: iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineQueryRouter.java

  1   2   3   4   5   6   7   8   9   10   >