Re: [PR] [to dev/1.3] Add copy fallback for compaction hard links [iotdb]
jt2594838 merged PR #18083: URL: https://github.com/apache/iotdb/pull/18083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [to dev/1.3] Add copy fallback for compaction hard links [iotdb]
codecov[bot] commented on PR #18083: URL: https://github.com/apache/iotdb/pull/18083#issuecomment-4852999594 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/18083?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `70.37037%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 43.07%. Comparing base ([`9b124e4`](https://app.codecov.io/gh/apache/iotdb/commit/9b124e4f13103a6627a899b0aecf850db5d4e75a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`324345f`](https://app.codecov.io/gh/apache/iotdb/commit/324345f06ec75e57f835d1d172d5b9706a4f28e8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/18083?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/iotdb/commons/utils/FileUtils.java](https://app.codecov.io/gh/apache/iotdb/pull/18083?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Futils%2FFileUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvdXRpbHMvRmlsZVV0aWxzLmphdmE=) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18083?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...paction/execute/task/InnerSpaceCompactionTask.java](https://app.codecov.io/gh/apache/iotdb/pull/18083?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fstorageengine%2Fdataregion%2Fcompaction%2Fexecute%2Ftask%2FInnerSpaceCompactionTask.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL2NvbXBhY3Rpb24vZXhlY3V0ZS90YXNrL0lubmVyU3BhY2VDb21wYWN0aW9uVGFzay5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18083?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...xecute/task/InsertionCrossSpaceCompactionTask.java](https://app.codecov.io/gh/apache/iotdb/pull/18083?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fstorageengine%2Fdataregion%2Fcompaction%2Fexecute%2Ftask%2FInsertionCrossSpaceCompactionTask.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL2NvbXBhY3Rpb24vZXhlY3V0ZS90YXNrL0luc2VydGlvbkNyb3NzU3BhY2VDb21wYWN0aW9uVGFzay5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18083?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...gine/dataregion/modification/ModificationFile.java](https://app.codecov.io/gh/apache/iotdb/pull/18083?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fstorageengine%2Fdataregion%2Fmodification%2FModificationFile.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL21vZGlmaWNhdGlvbi9Nb2RpZmljYXRpb25GaWxlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18083?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/1.3 #18083 +/- ## = - Coverage 43.07% 43.07% -0.01% Complexity 198 198 = Files 3626 3626 Lines 242522 242533 +11 Branches 2958229583 +1 = - Hits 104473 104468 -5 - Misses138049 138065 +16 ``` [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/18083?dropdown=coverage&src=pr&el=c
Re: [PR] [to dev/1.3] Add copy fallback for compaction hard links [iotdb]
sonarqubecloud[bot] commented on PR #18083: URL: https://github.com/apache/iotdb/pull/18083#issuecomment-4852459838 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18083) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18083&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18083&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=18083&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18083&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18083&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18083) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] [to dev/1.3] Add copy fallback for compaction hard links [iotdb]
shuwenwei opened a new pull request, #18083: URL: https://github.com/apache/iotdb/pull/18083 ## Description Backport of #18045 to `dev/1.3`. This PR adds a shared `FileUtils.createLink(..., fallBackToCopy)` helper and uses it in compaction-related file linking paths. When hard-link creation is unsupported or fails, these paths now fall back to copying the source file instead of failing immediately. ## Changes - Add a `FileUtils.createLink(Path, Path, boolean)` helper with optional copy fallback. - Use the helper in compaction target preparation paths. - Replace remaining compaction hard-link calls with the helper, including recovery tests. ## Verification - Searched compaction sources/tests for remaining `Files.createLink` / `createHardlink` usage; none remain. - Compile/build checks were not run per instruction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
