Re: [PR] Improve pipe receiver session handling [iotdb]
jt2594838 merged PR #18084: URL: https://github.com/apache/iotdb/pull/18084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve pipe receiver session handling [iotdb]
Caideyipi commented on code in PR #18084:
URL: https://github.com/apache/iotdb/pull/18084#discussion_r3519076939
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/twostage/exchange/receiver/TwoStageAggregateReceiver.java:
##
@@ -46,6 +49,14 @@ public IoTDBSinkRequestVersion getVersion() {
@Override
public TPipeTransferResp receive(TPipeTransferReq req) {
try {
+ final IClientSession clientSession = SESSION_MANAGER.getCurrSession();
+ if (!SESSION_MANAGER.checkLogin(clientSession)) {
+return new TPipeTransferResp(
+RpcUtils.getStatus(
+TSStatusCode.NOT_LOGIN,
+"Log in failed. Either you are not authorized or the session
has timed out."));
+ }
Review Comment:
Done, moved the two-stage receiver NOT_LOGIN message to DataNodePipeMessages
with both English and Chinese i18n constants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Improve pipe receiver session handling [iotdb]
jt2594838 commented on code in PR #18084:
URL: https://github.com/apache/iotdb/pull/18084#discussion_r3518142508
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/twostage/exchange/receiver/TwoStageAggregateReceiver.java:
##
@@ -46,6 +49,14 @@ public IoTDBSinkRequestVersion getVersion() {
@Override
public TPipeTransferResp receive(TPipeTransferReq req) {
try {
+ final IClientSession clientSession = SESSION_MANAGER.getCurrSession();
+ if (!SESSION_MANAGER.checkLogin(clientSession)) {
+return new TPipeTransferResp(
+RpcUtils.getStatus(
+TSStatusCode.NOT_LOGIN,
+"Log in failed. Either you are not authorized or the session
has timed out."));
+ }
Review Comment:
i18n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] Improve pipe receiver session handling [iotdb]
Caideyipi opened a new pull request, #18084: URL: https://github.com/apache/iotdb/pull/18084 This PR improves session handling for pipe receiver request paths and updates related tests. Validation: - git diff --check - mvn -o -pl iotdb-core/node-commons -Dtest=IoTDBFileReceiverTest test Note: The datanode-specific test could not be completed locally because the Java process ran out of native memory during module compilation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
