Re: [PR] Limit delete predicate DNF expansion [iotdb]
Caideyipi closed pull request #18148: Limit delete predicate DNF expansion URL: https://github.com/apache/iotdb/pull/18148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Limit delete predicate DNF expansion [iotdb]
codecov[bot] commented on PR #18148: URL: https://github.com/apache/iotdb/pull/18148#issuecomment-4911529402 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/18148?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 41.89%. Comparing base ([`e44cbbb`](https://app.codecov.io/gh/apache/iotdb/commit/e44cbbb0e975f087e9744d8ba800f00b5f0840dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0dd9b6d`](https://app.codecov.io/gh/apache/iotdb/commit/0dd9b6d60d324e12c1b402b32af7011c62d4101c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18148 +/- ## + Coverage 41.87% 41.89% +0.02% Complexity 318 318 Files 5297 5297 Lines374093 374179 +86 Branches 4828748302 +15 + Hits 156645 156770 +125 + Misses 217448 217409 -39 ``` [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/18148?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Limit delete predicate DNF expansion [iotdb]
sonarqubecloud[bot] commented on PR #18148: URL: https://github.com/apache/iotdb/pull/18148#issuecomment-4911344605 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18148) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18148&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18148&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=18148&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18148&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18148&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18148) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] Limit delete predicate DNF expansion [iotdb]
Caideyipi opened a new pull request, #18148: URL: https://github.com/apache/iotdb/pull/18148 ## Summary - Bound table delete predicate DNF expansion to 1000 disjunctive terms. - Return a localized semantic error instead of building an unbounded expression cross product. - Add focused unit coverage for within-limit and limit-exceeded DNF expansion. ## Tests - `mvn spotless:apply -pl iotdb-core/datanode` - `git diff --check` - `python -c "... DataNodeQueryMessages i18n parity ..."` - `mvn test -pl iotdb-core/datanode -Dtest=AnalyzeUtilsTest` failed before tests: JVM native memory allocation failure during checkstyle. - `mvn test -pl iotdb-core/datanode -Dtest=AnalyzeUtilsTest "-Dcheckstyle.skip=true" "-Dspotless.check.skip=true"` failed during datanode compile in generated aggregation classes: missing `ComparatorChain` / `getModeMapSizeThreshold()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
