Re: [PR] Pipe: manage ConfigNode receiver temporary memory [iotdb]
jt2594838 merged PR #18144: URL: https://github.com/apache/iotdb/pull/18144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pipe: manage ConfigNode receiver temporary memory [iotdb]
codecov[bot] commented on PR #18144: URL: https://github.com/apache/iotdb/pull/18144#issuecomment-4911135163 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/18144?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `65 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 41.86%. Comparing base ([`e44cbbb`](https://app.codecov.io/gh/apache/iotdb/commit/e44cbbb0e975f087e9744d8ba800f00b5f0840dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7962044`](https://app.codecov.io/gh/apache/iotdb/commit/7962044863f50de67725e1e7e504bf2315ca0ba7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/18144?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/resource/memory/PipeConfigNodeMemoryManager.java](https://app.codecov.io/gh/apache/iotdb/pull/18144?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fmanager%2Fpipe%2Fresource%2Fmemory%2FPipeConfigNodeMemoryManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS9yZXNvdXJjZS9tZW1vcnkvUGlwZUNvbmZpZ05vZGVNZW1vcnlNYW5hZ2VyLmphdmE=) | 0.00% | [45 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ipe/receiver/protocol/IoTDBConfigNodeReceiver.java](https://app.codecov.io/gh/apache/iotdb/pull/18144?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fmanager%2Fpipe%2Freceiver%2Fprotocol%2FIoTDBConfigNodeReceiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS9yZWNlaXZlci9wcm90b2NvbC9Jb1REQkNvbmZpZ05vZGVSZWNlaXZlci5qYXZh) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...r/pipe/resource/PipeConfigNodeResourceManager.java](https://app.codecov.io/gh/apache/iotdb/pull/18144?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fmanager%2Fpipe%2Fresource%2FPipeConfigNodeResourceManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS9yZXNvdXJjZS9QaXBlQ29uZmlnTm9kZVJlc291cmNlTWFuYWdlci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pipe/agent/runtime/PipeConfigNodeRuntimeAgent.java](https://app.codecov.io/gh/apache/iotdb/pull/18144?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fmanager%2Fpipe%2Fagent%2Fruntime%2FPipeConfigNodeRuntimeAgent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS9hZ2VudC9ydW50aW1lL1BpcGVDb25maWdOb2RlUnVudGltZUFnZW50LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18144 +/- ## - Coverage 41.87% 41.86% -0.01% Complexity 318 318 Files 5297 5298 +1 Lines374093 374138 +45 Branches 4828748292 +5 - Hits 156645 156639 -6 - Misses 217448 217499 +51 ``` [:umbrella: View full report in Codecov by
Re: [PR] Pipe: manage ConfigNode receiver temporary memory [iotdb]
sonarqubecloud[bot] commented on PR #18144: URL: https://github.com/apache/iotdb/pull/18144#issuecomment-4910945649 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18144) **Quality Gate passed** Issues  [7 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18144&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18144&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=18144&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18144&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18144&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18144) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] Pipe: manage ConfigNode receiver temporary memory [iotdb]
Caideyipi opened a new pull request, #18144: URL: https://github.com/apache/iotdb/pull/18144 ## Summary - Introduce a unified ConfigNode Pipe memory manager and move PipePeriodicalLogReducer resizing onto it. - Account ConfigNode receiver snapshot piece request bodies before deserializing/writing file pieces. - Account TRANSFER_COMPRESSED decompression extra buffer and return temporary-unavailable status on allocation failure. - Update ConfigNode Pipe memory config comments to cover log reducer and receiver temporary buffers. ## Tests - mvn spotless:apply -pl iotdb-core/confignode,iotdb-core/node-commons - mvn -Ddevelocity.off=true -Dcheckstyle.skip=true -Dspotless.check.skip=true test-compile -pl iotdb-core/confignode -DskipTests - mvn -Ddevelocity.off=true -Dcheckstyle.skip=true -Dspotless.check.skip=true test-compile -P with-zh-locale -pl iotdb-core/confignode -DskipTests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
