Re: [PR] Pipe: use session context in legacy receiver loaders [iotdb]
jt2594838 merged PR #18184: URL: https://github.com/apache/iotdb/pull/18184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] Pipe: use session context in legacy receiver loaders [iotdb]
Caideyipi opened a new pull request, #18184: URL: https://github.com/apache/iotdb/pull/18184 Cherry-pick of 7ccdaa503e26719dc5b8cd722c2ac297c3f1613a (#18111) to dev/1.3. ## Adaptations - Ported the session and authority checks to the dev/1.3 SessionInfo and AuthorityChecker APIs. - Used the dev/1.3 Deletion package and USE_PIPE grant syntax in the regression test. - Kept the dev/1.3 inline-message style because this branch does not contain the main-branch DataNode Pipe i18n source set. ## Validation - `mvn -Ddevelocity.off=true spotless:apply -pl iotdb-core/datanode,integration-test -P with-integration-tests` - `mvn -o -nsu -Ddevelocity.off=true test -pl iotdb-core/datanode -Dtest=IoTDBLegacyPipeReceiverAgentTest -DfailIfNoTests=false -DforkCount=0` (3 tests passed) - `mvn -o -nsu -Ddevelocity.off=true test-compile -pl integration-test -P with-integration-tests -DskipTests` - `mvn -o -nsu -Ddevelocity.off=true verify -pl integration-test -P with-integration-tests,SimpleIT -DskipUTs -Dit.test=IoTDBLegacyPipeReceiverSecurityIT#testLegacyPipeDataDeleteUsesAuthenticatedUserPermission -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false -DintegrationTest.forkCount=0` (1 test passed; local low-memory JVM used the repository Java 17 open-module options) - `git diff origin/dev/1.3...HEAD --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pipe: use session context in legacy receiver loaders [iotdb]
jt2594838 merged PR #18111: URL: https://github.com/apache/iotdb/pull/18111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Pipe: use session context in legacy receiver loaders [iotdb]
Caideyipi commented on code in PR #18111:
URL: https://github.com/apache/iotdb/pull/18111#discussion_r3549712987
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/legacy/IoTDBLegacyPipeReceiverAgent.java:
##
@@ -262,6 +203,15 @@ private SyncIdentityInfo getCurrentSyncIdentityInfo() {
}
}
+ private SessionInfo getCurrentSessionInfo() {
+final SessionManager sessionManager = SessionManager.getInstance();
+if (!sessionManager.checkLogin(sessionManager.getCurrSession())) {
+ throw new PipeException("Legacy pipe receiver requires a logged-in
session.");
Review Comment:
Fixed, thanks. Moved the message into DataNodePipeMessages for both en and
zh locales.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Pipe: use session context in legacy receiver loaders [iotdb]
jt2594838 commented on code in PR #18111:
URL: https://github.com/apache/iotdb/pull/18111#discussion_r3534445956
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/legacy/IoTDBLegacyPipeReceiverAgent.java:
##
@@ -262,6 +203,15 @@ private SyncIdentityInfo getCurrentSyncIdentityInfo() {
}
}
+ private SessionInfo getCurrentSessionInfo() {
+final SessionManager sessionManager = SessionManager.getInstance();
+if (!sessionManager.checkLogin(sessionManager.getCurrSession())) {
+ throw new PipeException("Legacy pipe receiver requires a logged-in
session.");
Review Comment:
i18n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] Pipe: use session context in legacy receiver loaders [iotdb]
Caideyipi opened a new pull request, #18111: URL: https://github.com/apache/iotdb/pull/18111 ## Description ### Legacy receiver session context Legacy pipe receiver loading now uses the session context supplied by the RPC request path. The loader API accepts this context explicitly so deletion and tsfile loading follow the same request context. ### Loader behavior TsFile loading now follows the configured auto-create setting. The legacy receiver no longer performs database registration during handshake. ### Tests - `git diff --check` This PR has: - [x] been self-reviewed. - [x] added integration tests. # Key changed/added classes (or packages if there are too many classes) in this PR - Legacy pipe receiver agent and loaders. - Client RPC pipe data transport path. - Legacy pipe receiver integration test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
