Re: [PR] Stop snapshot traversal after directory visit failures [iotdb]
cragkhit closed pull request #18379: Stop snapshot traversal after directory visit failures URL: https://github.com/apache/iotdb/pull/18379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Stop snapshot traversal after directory visit failures [iotdb]
Copilot commented on code in PR #18379:
URL: https://github.com/apache/iotdb/pull/18379#discussion_r3700828188
##
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/common/Utils.java:
##
@@ -66,6 +66,10 @@ public FileVisitResult visitFileFailed(Path file,
IOException exc) {
@Override
public FileVisitResult postVisitDirectory(Path dir, IOException
exc) {
+ if (exc != null) {
+logger.info(ConsensusMessages.VISIT_FILE_FAILED,
dir.toAbsolutePath(), exc);
+return FileVisitResult.TERMINATE;
+ }
Review Comment:
`postVisitDirectory` logs `ConsensusMessages.VISIT_FILE_FAILED`, but this
callback is for directory traversal failures. The current i18n message text is
explicitly "visit file"/"访问文件", so the log becomes misleading when `dir` is
passed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] Stop snapshot traversal after directory visit failures [iotdb]
cragkhit opened a new pull request, #18379: URL: https://github.com/apache/iotdb/pull/18379 Hi. We are researchers from Mahidol University, Thailand, and the State University of Ceará, Brazil, working on a research project for improving open-source projects by using the latest accepted answer from Stack Overflow that matched your code snippet. We found this recommendation for improving your code from https://stackoverflow.com/a/18454342. Note: Our study is approved by the Institutional Review Board of Mahidol University. You can find the participant information sheet explaining this study https://drive.google.com/file/d/1ml5AqrtWQ9pnifTQyTFTcWQmwp6RuPA7/view?usp=sharing. ## Proposed change Stopped recursive snapshot listing when postVisitDirectory reports a traversal failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
