Re: [PR] Fix pipe history LoadTsFile after deleting aligned measurements [iotdb]
jt2594838 merged PR #18116: URL: https://github.com/apache/iotdb/pull/18116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix pipe history LoadTsFile after deleting aligned measurements [iotdb]
sonarqubecloud[bot] commented on PR #18116: URL: https://github.com/apache/iotdb/pull/18116#issuecomment-4890730680 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18116) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18116&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18116&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=18116&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18116&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18116&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18116) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix pipe history LoadTsFile after deleting aligned measurements [iotdb]
Caideyipi commented on PR #18116: URL: https://github.com/apache/iotdb/pull/18116#issuecomment-4890640582 Follow-up for the table-model CI failures: The failed `IoTDBWindowFunction2IT` / `IoTDBWindowTVF2IT` cases expose a table-model edge case: a table device can have rows whose value columns are all null, but the device/id row still needs to be persisted in TsFile metadata. My previous early return skipped encoding when the active aligned value schema list was empty, which is valid for tree model (`ignoreAllNullRows=true`) but invalid for table model (`ignoreAllNullRows=false`). I updated the guard to return only when `activeSchemaList.isEmpty() && ignoreAllNullRows`, so tree model still drops all-null/deleted aligned devices while table model still writes the time/device metadata for all-null value rows. Local validation: - `mvn spotless:check -pl iotdb-core/datanode,integration-test -P with-integration-tests` - `git diff --check` I also tried to run the affected ITs locally, but the local build is still blocked before tests by the existing `iotdb-thrift` generated-source compile issue: missing `javax.annotation` under JDK 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix pipe history LoadTsFile after deleting aligned measurements [iotdb]
codecov[bot] commented on PR #18116: URL: https://github.com/apache/iotdb/pull/18116#issuecomment-4890459782 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/18116?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `42.10526%` with `22 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 41.85%. Comparing base ([`8940ba0`](https://app.codecov.io/gh/apache/iotdb/commit/8940ba0e3f5b199af170193128395ec2c5e262fa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`57e4d5f`](https://app.codecov.io/gh/apache/iotdb/commit/57e4d5f73e08810d749c73337e117e191011fc57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/18116?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/dataregion/memtable/AlignedWritableMemChunk.java](https://app.codecov.io/gh/apache/iotdb/pull/18116?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fstorageengine%2Fdataregion%2Fmemtable%2FAlignedWritableMemChunk.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL21lbXRhYmxlL0FsaWduZWRXcml0YWJsZU1lbUNodW5rLmphdmE=) | 42.10% | [22 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18116 +/- ## + Coverage 41.84% 41.85% +0.01% Complexity 318 318 Files 5296 5296 Lines373593 373620 +27 Branches 4823448243 +9 + Hits 156313 156376 +63 + Misses 217280 217244 -36 ``` [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/18116?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix pipe history LoadTsFile after deleting aligned measurements [iotdb]
sonarqubecloud[bot] commented on PR #18116: URL: https://github.com/apache/iotdb/pull/18116#issuecomment-4890128455 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18116) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18116&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18116&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=18116&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18116&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18116&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18116) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix pipe history LoadTsFile after deleting aligned measurements [iotdb]
sonarqubecloud[bot] commented on PR #18116: URL: https://github.com/apache/iotdb/pull/18116#issuecomment-4889989460 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18116) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18116&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18116&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=18116&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18116&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18116&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18116) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
