Re: [PR] Fix race condition in ExternalTsFileQueryResource reference counting [iotdb]

2026-07-31 Thread via GitHub


shuwenwei merged PR #18371:
URL: https://github.com/apache/iotdb/pull/18371


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Fix race condition in ExternalTsFileQueryResource reference counting [iotdb]

2026-07-31 Thread via GitHub


codecov[bot] commented on PR #18371:
URL: https://github.com/apache/iotdb/pull/18371#issuecomment-5140816178

   ## 
[Codecov](https://app.codecov.io/gh/apache/iotdb/pull/18371?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `66.7%` with `1 line` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 43.28%. Comparing base 
([`1546441`](https://app.codecov.io/gh/apache/iotdb/commit/154644107a82ba69431725390b8346149263bd0e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`dcb71a2`](https://app.codecov.io/gh/apache/iotdb/commit/dcb71a20498e50284de69ee5c0f801a9504290c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/iotdb/pull/18371?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...n/tvf/read\_tsfile/ExternalTsFileQueryResource.java](https://app.codecov.io/gh/apache/iotdb/pull/18371?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Ffunction%2Ftvf%2Fread_tsfile%2FExternalTsFileQueryResource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL2Z1bmN0aW9uL3R2Zi9yZWFkX3RzZmlsZS9FeHRlcm5hbFRzRmlsZVF1ZXJ5UmVzb3VyY2UuamF2YQ==)
 | 50.00% | [1 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/18371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   Additional details and impacted files
   
   
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #18371  +/-   ##
   
   - Coverage 43.45%   43.28%   -0.17% 
 Complexity  374  374  
   
 Files  5364 5364  
 Lines383165   383167   +2 
 Branches  4984949850   +1 
   
   - Hits 166516   165866 -650 
   - Misses   216649   217301 +652 
   ```
   
   
   [:umbrella: View full report in Codecov by 
Harness](https://app.codecov.io/gh/apache/iotdb/pull/18371?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Fix race condition in ExternalTsFileQueryResource reference counting [iotdb]

2026-07-31 Thread via GitHub


sonarqubecloud[bot] commented on PR #18371:
URL: https://github.com/apache/iotdb/pull/18371#issuecomment-5140568649

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18371) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [C Reliability Rating on New 
Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18371) 
(required ≥ A)  
 
   
   
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18371)
   
   ##   
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 '') Catch issues before they fail your Quality Gate with our IDE extension 
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 '') [SonarQube for 
IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]