Re: [PR] Support attribute filters in table deletion [iotdb]
jt2594838 merged PR #18079: URL: https://github.com/apache/iotdb/pull/18079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Support attribute filters in table deletion [iotdb]
sonarqubecloud[bot] commented on PR #18079: URL: https://github.com/apache/iotdb/pull/18079#issuecomment-4888766473 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) **Quality Gate failed** Failed conditions  [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) (required ≥ A) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Support attribute filters in table deletion [iotdb]
sonarqubecloud[bot] commented on PR #18079: URL: https://github.com/apache/iotdb/pull/18079#issuecomment-4888489044 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) **Quality Gate failed** Failed conditions  [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) (required ≥ A) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Support attribute filters in table deletion [iotdb]
sonarqubecloud[bot] commented on PR #18079: URL: https://github.com/apache/iotdb/pull/18079#issuecomment-4874212863 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) **Quality Gate failed** Failed conditions  [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) (required ≥ A) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Support attribute filters in table deletion [iotdb]
sonarqubecloud[bot] commented on PR #18079: URL: https://github.com/apache/iotdb/pull/18079#issuecomment-4852385783 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) **Quality Gate passed** Issues  [16 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18079&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18079&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=18079&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18079&metric=new_coverage&view=list)  [3.3% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18079&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Support attribute filters in table deletion [iotdb]
Caideyipi commented on PR #18079: URL: https://github.com/apache/iotdb/pull/18079#issuecomment-4851853090 Thanks for the work on supporting attribute filters in table deletion. I found a few issues that should be addressed before merge: 1. `IS NOT NULL` tag predicates are dropped when they are combined with attribute filters. In `AnalyzeUtils.parsePredicate`, the `IsNotNullPredicate` branch only handles `shouldQueryDevice()`. Unlike the `ComparisonExpression` and `IsNullPredicate` branches, it does not add tag-only predicates to `deviceFilterExpressions` when `shouldFilterDevice()` is true. Later, when any attribute predicate exists, `tagPredicate` is replaced by `new DeviceIn(deviceIDs)`, so the original `SegmentNotNull` predicate is lost. For example: ```sql DELETE FROM t WHERE site IS NOT NULL AND attr1 = 'red' ``` may delete data from devices whose `attr1 = 'red'` but whose `site` tag is `NULL`. Please either include tag `IS NOT NULL` in the schema fetch predicate list, or preserve/intersect the original tag predicate when converting matched devices to `DeviceIn`. 2. The existing integration test expectation for `deviceId IS NOT NULL` looks stale. `testDeleteData` still expects: ```sql DELETE FROM vehicle1 WHERE time < 10 AND deviceId IS NOT NULL ``` to fail with "Unsupported expression", but this PR adds tag `IS NOT NULL` support via `parseIsNotNull`. This test should now fail unless the expectation and subsequent data validation are updated. 3. Attribute comparison predicates need explicit validation before being sent to the schema fetcher. `parseComparison` returns `PredicateParseResult.attribute(...)` without checking the operator or right-hand value type. Inputs such as `attr1 = 1`, `attr1 = null`, or unsupported comparison operators can flow into later schema-filter conversion code and trigger casts/internal exceptions instead of a clear semantic error. Please validate attribute predicates here, or make the schema predicate conversion layer return a proper `SemanticException` for invalid attribute predicates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Support attribute filters in table deletion [iotdb]
codecov[bot] commented on PR #18079: URL: https://github.com/apache/iotdb/pull/18079#issuecomment-4851166003 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/18079?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `45.27559%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 41.59%. Comparing base ([`cd5c3a3`](https://app.codecov.io/gh/apache/iotdb/commit/cd5c3a31195c0ef69b0bf3ccacfd10257bd43ddb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4f31e9f`](https://app.codecov.io/gh/apache/iotdb/commit/4f31e9f2c83467042ec001d87151ffcb2877a568?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 24 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/18079?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otdb/db/queryengine/plan/analyze/AnalyzeUtils.java](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fanalyze%2FAnalyzeUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9hbmFseXplL0FuYWx5emVVdGlscy5qYXZh) | 17.59% | [89 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...geengine/dataregion/modification/TagPredicate.java](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fstorageengine%2Fdataregion%2Fmodification%2FTagPredicate.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL21vZGlmaWNhdGlvbi9UYWdQcmVkaWNhdGUuamF2YQ==) | 63.80% | [38 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../iotdb/db/storageengine/dataregion/DataRegion.java](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fstorageengine%2Fdataregion%2FDataRegion.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL0RhdGFSZWdpb24uamF2YQ==) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ine/dataregion/modification/DeletionPredicate.java](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fstorageengine%2Fdataregion%2Fmodification%2FDeletionPredicate.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL21vZGlmaWNhdGlvbi9EZWxldGlvblByZWRpY2F0ZS5qYXZh) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ne/dataregion/modification/TableDeletionEntry.java](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fstorageengine%2Fdataregion%2Fmodification%2FTableDeletionEntry.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL21vZGlmaWNhdGlvbi9UYWJsZURlbGV0aW9uRW50cnkuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ol/thrift/impl/DataNodeInternalRPCServiceImpl.java](https://app.codecov.io/gh/apache/iotdb/pull/18079?src=pr&el=tree&filepath=i
Re: [PR] Support attribute filters in table deletion [iotdb]
sonarqubecloud[bot] commented on PR #18079: URL: https://github.com/apache/iotdb/pull/18079#issuecomment-4850814010 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) **Quality Gate passed** Issues  [15 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18079&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=18079&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=18079&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18079&metric=new_coverage&view=list)  [3.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=18079&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=18079) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
