[kudu-CR] [thirdparty]: added include-what-you-use

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [thirdparty]: added include-what-you-use .. Patch Set 3: (2 comments) any idea what the incremental compilation time cost is for thirdparty on this?

[kudu-CR] Add tablet state summary metrics and fix KUDU-2044

2017-08-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7618 to look at the new patch set (#2). Change subject: Add tablet state summary metrics and fix KUDU-2044 .. Add

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 13: (19 comments) http://gerrit.cloudera.org:8080/#/c/7207/5//COMMIT_MSG Commit Message: PS5, Line

[kudu-CR] consensus: Don't replay config changes

2017-08-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Don't replay config changes .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7614/1/src/kudu/tablet/tablet_bootstrap.cc File

[kudu-CR] consensus: Don't replay config changes

2017-08-08 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7614 to look at the new patch set (#2). Change subject: consensus: Don't replay config changes .. consensus: Don't

[kudu-CR] [maintenance manager] fix op scheduling lock contention, thread ID tweak

2017-08-08 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7621 to review the following change. Change subject: [maintenance manager] fix op scheduling lock contention, thread ID tweak

[kudu-CR] consensus: Don't replay config changes

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Don't replay config changes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit

[kudu-CR] KUDU-2060: Show primary keys in the master's table web UI page

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2060: Show primary keys in the master's table web UI page .. KUDU-2060: Show primary keys in the master's table web UI page Change-Id:

[kudu-CR] consensus: Don't replay config changes

2017-08-08 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7614 to look at the new patch set (#3). Change subject: consensus: Don't replay config changes ..

[kudu-CR] Give more context on errors reading cfiles

2017-08-08 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Grant Henke, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7620 to review the following change. Change subject: Give more context on errors reading cfiles

[kudu-CR] Add Maintenance Manager visualizer

2017-08-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add Maintenance Manager visualizer .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7570/7/www/maintenance-manager.mustache File

[kudu-CR] KUDU-2060: Show primary keys in the master's table web UI page

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2060: Show primary keys in the master's table web UI page .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7569 To

[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7607 To unsubscribe,

[kudu-CR] kudu client tools for hadoop and spark import/export(csv,parquet,avro)

2017-08-08 Thread Sandish Kumar HN (Code Review)
Sandish Kumar HN has posted comments on this change. Change subject: kudu client tools for hadoop and spark import/export(csv,parquet,avro) .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/7421/6//COMMIT_MSG

[kudu-CR] consensus: Don't replay config changes

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Don't replay config changes .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7614/1/src/kudu/tablet/tablet_bootstrap.cc File

[kudu-CR] Add Maintenance Manager visualizer

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add Maintenance Manager visualizer .. Patch Set 7: (10 comments) http://gerrit.cloudera.org:8080/#/c/7570/7/www/maintenance-manager.mustache File

[kudu-CR] Give more context on errors reading cfiles

2017-08-08 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: Give more context on errors reading cfiles .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7620/1/src/kudu/cfile/cfile-test.cc File

[kudu-CR] consensus: Don't replay config changes

2017-08-08 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7614 to look at the new patch set (#4). Change subject: consensus: Don't replay config changes ..

[kudu-CR] consensus: Don't replay config changes

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Don't replay config changes .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7614 To unsubscribe, visit

[kudu-CR] consensus: Don't replay config changes

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: consensus: Don't replay config changes .. consensus: Don't replay config changes We have invariants in place that make it unnecessary to "replay" a

[kudu-CR] disk failure: release failed txs from tracker

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: disk failure: release failed txs from tracker .. Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/7439/8/src/kudu/tablet/mvcc.h File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 4: (32 comments) http://gerrit.cloudera.org:8080/#/c/6960/4/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-08 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#6). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] [maintenance manager] fix op scheduling lock contention, thread ID tweak

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [maintenance manager] fix op scheduling lock contention, thread ID tweak .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-08 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#5). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-08-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. KUDU-2033 (part 1). Add write and stop/start in a loop to

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 4: (21 comments) did a first pass, probably will have more comments after a second pass but figured I'd send

[kudu-CR] disk failure: reassign failed tablets

2017-08-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: reassign failed tablets .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/7440/7/src/kudu/client/scanner-internal.cc File

[kudu-CR] disk failure: reassign failed tablets

2017-08-08 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7440 to look at the new patch set (#8). Change subject: disk failure: reassign failed tablets .. disk failure: reassign

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-08-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 8: Apparently raft_consensus-itest is flaky under TSAN. Overriding

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-08-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7456 To

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-08-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7456

[kudu-CR] WIP: [iwyu] first pass

2017-08-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 11: (19 comments) Thanks for banging on this some more, will be great to have with the automated checking. I only got

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-08-08 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 8: (1 comment)

[kudu-CR](branch-1.2.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks This fixes a

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-08 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7602 to look at the new patch set (#4). Change subject: separate DataDirManager from BlockManagers .. separate

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-08-08 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7456 to look at the new patch set (#8). Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

[kudu-CR](branch-1.2.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7613

[kudu-CR] WIP: [iwyu] first pass

2017-08-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 11: -Verified > (19 comments) > > Thanks for banging on this some more, will be great to have with > the automated

[kudu-CR] WIP KUDU-1489: move tablet metadata

2017-08-08 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7617 Change subject: WIP KUDU-1489: move tablet metadata .. WIP KUDU-1489: move tablet metadata WIP: a few areas still need cleaning (e.g.

[kudu-CR] Add tablet state summary metrics and fix KUDU-2044

2017-08-08 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7618 Change subject: Add tablet state summary metrics and fix KUDU-2044 .. Add tablet state summary metrics and fix KUDU-2044 This patch

[kudu-CR] KUDU-2060: Show primary keys in the master's table web UI page

2017-08-08 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7569 to look at the new patch set (#2). Change subject: KUDU-2060: Show primary keys in the master's table web UI page

[kudu-CR] disk failure: release failed txs from tracker

2017-08-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: release failed txs from tracker .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/7439/6/src/kudu/tablet/transactions/transaction.h

[kudu-CR] disk failure: release failed txs from tracker

2017-08-08 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#7). Change subject: disk failure: release failed txs from tracker .. disk failure:

[kudu-CR] disk failure: release failed txs from tracker

2017-08-08 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#8). Change subject: disk failure: release failed txs from tracker .. disk failure:

[kudu-CR] disk failure: release failed txs from tracker

2017-08-08 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: release failed txs from tracker .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/4//COMMIT_MSG Commit Message: PS4, Line 15: