[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: use operation timeout as deadline for finding new leader master .. Patch Set 2: Alright, let's try this and see if people complain about the UX. (I'm

[kudu-CR] Fix mailing list archive links to not reference incubator

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3725 to review the following change. Change subject: Fix mailing list archive links to not reference incubator .. Fix

[kudu-CR](gh-pages) Update the overview page

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3726 to review the following change. Change subject: Update the overview page .. Update the overview page Long-overdue

[kudu-CR](gh-pages) Update the overview page

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update the overview page .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3726 To unsubscribe, visit

[kudu-CR] Remove ASF incubation callouts

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Remove ASF incubation callouts .. Remove ASF incubation callouts Now that the resolution has passed, we no longer need to call out incubation status.

[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update the docs webpages to reflect the master branch .. Patch Set 1: I think updating prior to release is nice, but only if we do the "this is an unreleased

[kudu-CR] Remove ASF incubation callouts

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Remove ASF incubation callouts .. Patch Set 1: k, I'll do a follow-up -- To view, visit http://gerrit.cloudera.org:8080/3699 To unsubscribe, visit

[kudu-CR] ksck: improve output for long-running ksck checksums

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: improve output for long-running ksck checksums .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3715/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] KUDU-1516 ksck should check for more raft-related status issues (partial)

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1516 ksck should check for more raft-related status issues (partial) .. Patch Set 4: (3 comments)

[kudu-CR] ksck: fix a test flake caused by a race on timeout

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3727 to review the following change. Change subject: ksck: fix a test flake caused by a race on timeout

[kudu-CR] KUDU-1516 ksck should check for more raft-related status issues (partial)

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3632 to look at the new patch set (#5). Change subject: KUDU-1516 ksck should check for more raft-related status issues (partial)

[kudu-CR] ksck: improve output for long-running ksck checksums

2016-07-22 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3715 to look at the new patch set (#2). Change subject: ksck: improve output for long-running ksck checksums

[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3733 to review the following change. Change subject: Fix block_manager-test running in some builds .. Fix

[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3733 to look at the new patch set (#2). Change subject: Fix block_manager-test running in some builds .. Fix

[kudu-CR] Fix block manager-test running in some builds

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3733 to look at the new patch set (#3). Change subject: Fix block_manager-test running in some builds .. Fix

[kudu-CR] ksck-test: fix failure on OSX

2016-07-24 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3734 to review the following change. Change subject: ksck-test: fix failure on OSX .. ksck-test: fix

[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss

2016-07-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss .. KUDU-1538: prevent block ID reuse to avoid potential data loss This changes the block

[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss

2016-07-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss .. Patch Set 2: (1 comment)

[kudu-CR] WIP: KUDU-1271: allow primary keys not at the start of the row

2016-07-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3722 Change subject: WIP: KUDU-1271: allow primary keys not at the start of the row .. WIP: KUDU-1271: allow primary keys not at the start of

[kudu-CR] docs: Add missing DISTRIBUTE to quickstart

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: Add missing DISTRIBUTE to quickstart .. Patch Set 1: Did you verify this syntax by trying it? (I can't remember if the DISTRIBUTE BY goes before or after

[kudu-CR] docs: fix links to MR examples in developing

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: fix links to MR examples in developing .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3821/1/docs/developing.adoc File

[kudu-CR] KUDU-1548. Fix flaky RaftConsensusITest.TestReplaceChangeConfigOperation

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1548. Fix flaky RaftConsensusITest.TestReplaceChangeConfigOperation .. KUDU-1548. Fix flaky RaftConsensusITest.TestReplaceChangeConfigOperation

[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. KUDU-1358 (part 1): master should accept heartbeat even if follower This patch

[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3609 To

[kudu-CR] KUDU-1358 (part 3): new multi-master stress test

2016-07-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 13: Code-Review+1 have you looped this one? Also, Dan, any further comments? -- To view, visit

[kudu-CR] Add docs for non-covering range partitioning

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add docs for non-covering range partitioning .. Patch Set 1: Dan, do you have time to look at this before the 0.10 release? -- To view, visit

[kudu-CR] [util] fixed build on MacOS X

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util] fixed build on MacOS X .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt File

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3834/1/src/kudu/client/scan_batch.h File

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: remote_bootstrap_client: mild API changes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG Commit Message: Line 15:

[kudu-CR] docs: design for handling permanent master failures

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: design for handling permanent master failures .. Patch Set 3: (3 comments)

[kudu-CR] Fix ksck-test reliance on unordered map iteration order

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix ksck-test reliance on unordered map iteration order .. Patch Set 1: Hey Will. I actually put a patch up already for this here

[kudu-CR] Clarify that minor delta compaction is for REDOs

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Clarify that minor delta compaction is for REDOs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3944/1/src/kudu/tablet/tablet.h File

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3943/1/src/kudu/common/timestamp.h File

[kudu-CR] KUDU-1553: kudu-client crash

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1553: kudu-client crash .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3945/2//COMMIT_MSG Commit Message: Line 12: where

[kudu-CR] Clarify that delta compaction is for REDOs

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Clarify that delta compaction is for REDOs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3944 To unsubscribe, visit

[kudu-CR] Clarify that delta compaction is for REDOs

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Clarify that delta compaction is for REDOs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3944/1/src/kudu/tablet/tablet.h File

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3943 To unsubscribe, visit

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3946 Change subject: fs_tool: improve format for dumping a rowset .. fs_tool: improve format for dumping a rowset Change-Id:

[kudu-CR] KUDU-1555. PBC Flush() method should be async

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1555. PBC Flush() method should be async .. KUDU-1555. PBC Flush() method should be async WritablePBContainerFile::Flush is meant to flush the data

[kudu-CR] KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1553: Crash when specifying multiple unbounded range predicates on a column .. Patch Set 3: not sure why dist-test keeps having issues... I do see some SYN

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. Patch Set 3: oops... accidentally un-pushed rev 2... -- To view, visit

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3939 to look at the new patch set (#3). Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes

[kudu-CR] KUDU-1555. PBC Flush() method should be async

2016-08-11 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3951 to review the following change. Change subject: KUDU-1555. PBC Flush() method should be async ..

[kudu-CR] maintenance manager: fix gflags docs

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: maintenance_manager: fix gflags docs .. maintenance_manager: fix gflags docs The gflag doc referenced an "emergency flush thread" which was removed more

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1474: single to multi-master deployment migration .. Patch Set 4: (15 comments)

[kudu-CR] maintenance manager: fix gflags docs

2016-08-11 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3950 to review the following change. Change subject: maintenance_manager: fix gflags docs .. maintenance_manager: fix

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3939 to look at the new patch set (#2). Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes

[kudu-CR](gh-pages) Simple typo fix in faq: 'arge' => 'large'

2016-08-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Simple typo fix in faq: 'arge' => 'large' .. Simple typo fix in faq: 'arge' => 'large' Change-Id: I675d770f8fa484cf6fff7a7006f0dbd68eb51517 Reviewed-on:

[kudu-CR] [C++ client] doxygenized all C++ client API

2016-08-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [C++ client] doxygenized all C++ client API .. [C++ client] doxygenized all C++ client API Doxygenized the rest of header files distributed along with

[kudu-CR] Memory tracking for result tracker

2016-08-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.h File

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 13: looking over this stuff tonight, just a note: seems like this is lacking actually

[kudu-CR] KUDU-1559. Fix block manager metric for aborted blocks

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1559. Fix block manager metric for aborted blocks .. KUDU-1559. Fix block manager metric for aborted blocks We weren't properly decrementing the

[kudu-CR] monotime: remove granularity argument

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: monotime: remove granularity argument .. monotime: remove granularity argument In practice, we almost never used the 'COARSE' granularity. Instead, it

[kudu-CR] monotime: remove granularity argument

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: monotime: remove granularity argument .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3966/1//COMMIT_MSG Commit Message: Line 13: Let's remove

[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3972 To unsubscribe,

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. Patch Set 1: (2 comments) Thanks for fixing this. Just a small style nit.

[kudu-CR] Reorganize range partition client API

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Reorganize range partition client API .. Reorganize range partition client API This commit redesigns the client APIs dealing with adding and dropping

[kudu-CR] log block manager: replace custom RAII class with ScopedCleanup

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: log_block_manager: replace custom RAII class with ScopedCleanup .. log_block_manager: replace custom RAII class with ScopedCleanup Change-Id:

[kudu-CR] [java-client] Reorganize range partition client API

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [java-client] Reorganize range partition client API .. [java-client] Reorganize range partition client API Equivalient to the corresponding C++ commit

[kudu-CR] Various comment / doc improvements

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Various comment / doc improvements .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3977/1/src/kudu/tablet/delta_compaction.cc File

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 2: (1 comment) will try to write a test. fwiw I've been testing this on a cluster ~2 days now and

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-14 Thread Todd Lipcon (Code Review)
Hello Anonymous Coward #80, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3976 to look at the new patch set (#2). Change subject: MergeIterator: don't stop iterating on an empty block

[kudu-CR] Replace gscoped ptr with unique ptr for ConsensusMetadata

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Replace gscoped_ptr with unique_ptr for ConsensusMetadata .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3967 To unsubscribe,

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1474: single to multi-master deployment migration .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/3880/6/src/kudu/gutil/strings/join.h File

[kudu-CR] fs: allow format with arbitrary uuid

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: fs: allow format with arbitrary uuid .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3968/2/src/kudu/fs/fs_manager.cc File

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 12: (3 comments)

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action.cc

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util/env_posix.cc] fixed build on MacOS X .. Patch Set 1: Code-Review+2 oops, my bad! -- To view, visit http://gerrit.cloudera.org:8080/3978 To unsubscribe,

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3961 to look at the new patch set (#3). Change subject: Start a background thread to run ResultTracker GC .. Start a

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#21). Change subject: Memory tracking for result tracker .. Memory tracking

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.cc File

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3786 To

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3786 to look at the new patch set (#7). Change subject: KUDU-526: use on-disk cmeta when loading existing master state

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [util/env_posix.cc] fixed build on MacOS X .. [util/env_posix.cc] fixed build on MacOS X Fixed a tiny typo which broke build on MacOS X. This is a

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3786 to look at the new patch set (#6). Change subject: KUDU-526: use on-disk cmeta when loading existing master state

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3979 to review the following change. Change subject: Another pass on 0.10.0 release notes ..

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3939 to look at the new patch set (#4). Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#14). Change subject: Add time/watermark based garbage collection to ResultTracker ..

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 13: (11 comments)

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add regex string match assert helper macros .. Patch Set 1: I think this same functionality is already available using the ContainsRegex or MatchesRegex matcher

[kudu-CR] Memory tracking for result tracker

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 20: Verified+1 known flake -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 8: Code-Review+1 Looks good to me. Mike, any comments on this? -- To view, visit

[kudu-CR] env posix: improve error message on short writes

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3959 to review the following change. Change subject: env_posix: improve error message on short writes ..

[kudu-CR] Memory tracking for result tracker

2016-08-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#20). Change subject: Memory tracking for result tracker ..

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3961 Change subject: Start a background thread to run ResultTracker GC .. Start a background thread to run ResultTracker GC Change-Id:

[kudu-CR] [util/stopwatch.h] fixed integer overflow

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util/stopwatch.h] fixed integer overflow .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3960 To unsubscribe, visit

[kudu-CR] monotime: use a signed integer for the value

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: monotime: use a signed integer for the value .. Patch Set 1: yea, 2^63 microseconds is 292,277.266 years, so I dont think we're in danger of a system's uptime

[kudu-CR] monotime: use a signed integer for the value

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: monotime: use a signed integer for the value .. monotime: use a signed integer for the value MonoTime previously used a uint64_t to store its value. This

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 2: I looped exactly_once_writes-itest with this patch 1000 times (100% pass):

[kudu-CR] Add regex string match assert helper macros

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add regex string match assert helper macros .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3962 To unsubscribe, visit

[kudu-CR] test result server: improve indexes, add sorting

2016-08-10 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3889 to review the following change. Change subject: test_result_server: improve indexes, add sorting ..

[kudu-CR] WIP: Adding some missing 0.10.0 release notes

2016-08-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: WIP: Adding some missing 0.10.0 release notes .. WIP: Adding some missing 0.10.0 release notes This isn't complete and is missing some information, but

[kudu-CR] Rename raft-remote-bootstrap design doc

2016-08-10 Thread Todd Lipcon (Code Review)
Hello Misty Stanley-Jones, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3890 to review the following change. Change subject: Rename raft-remote-bootstrap design doc .. Rename

[kudu-CR] test result server: improve indexes, add sorting

2016-08-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: test_result_server: improve indexes, add sorting .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3889/1/build-support/test_result_server.py File

[kudu-CR] test result server: improve indexes, add sorting

2016-08-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: test_result_server: improve indexes, add sorting .. Patch Set 2: (I deployed this) -- To view, visit http://gerrit.cloudera.org:8080/3889 To unsubscribe, visit

[kudu-CR] test result server: improve indexes, add sorting

2016-08-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: test_result_server: improve indexes, add sorting .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3889 To unsubscribe, visit

[kudu-CR] test result server: improve indexes, add sorting

2016-08-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: test_result_server: improve indexes, add sorting .. test_result_server: improve indexes, add sorting * adds a new index to the underlying database table.

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 6: (14 comments) http://gerrit.cloudera.org:8080/#/c/3076/6/src/kudu/tablet/compaction.cc File

[kudu-CR] Reorganize range partition client API

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Reorganize range partition client API .. Patch Set 4: Code-Review+1 (2 comments) basically just looked at the API, rather than the impl, since it looks like

[kudu-CR] [java-client] Reorganize range partition client API

2016-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java-client] Reorganize range partition client API .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3958 To unsubscribe, visit

  1   2   3   4   5   6   7   8   9   10   >