[kudu-CR] KUDU-1553: kudu-client crash

2016-08-11 Thread song bruce zhang (Code Review)
song bruce zhang has uploaded a new change for review. http://gerrit.cloudera.org:8080/3945 Change subject: KUDU-1553: kudu-client crash .. KUDU-1553: kudu-client crash When issue sql query through impala, kudu-client will

[kudu-CR] KUDU-1553: kudu-client crash

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1553: kudu-client crash .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2815/ -- To view, visit http://gerrit.cloudera.org:8080/3945

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/3871/2//COMMIT_MSG Commit Message: Line 13: for

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3871 to look at the new patch set (#3). Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. KUDU-1533 Spark

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2816/ -- To view, visit

[kudu-CR] Clarify that minor delta compaction is for REDOs

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Clarify that minor delta compaction is for REDOs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3944/1/src/kudu/tablet/tablet.h File

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3943/1/src/kudu/common/timestamp.h File

[kudu-CR] KUDU-1553: kudu-client crash

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1553: kudu-client crash .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3945/2//COMMIT_MSG Commit Message: Line 12: where

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 2: (1 comment)

[kudu-CR] Clarify that delta compaction is for REDOs

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Clarify that delta compaction is for REDOs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3944 To unsubscribe, visit

[kudu-CR] KUDU-1553: kudu-client crash

2016-08-11 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3945 to look at the new patch set (#2). Change subject: KUDU-1553: kudu-client crash .. KUDU-1553: kudu-client crash

[kudu-CR] KUDU-1553: kudu-client crash

2016-08-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1553: kudu-client crash .. Patch Set 2: Thanks for the patch, Bruce! I suspected there may be even more issues lurking here, so I wrote up a bunch of test

[kudu-CR] Clarify that delta compaction is for REDOs

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Clarify that delta compaction is for REDOs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3944/1/src/kudu/tablet/tablet.h File

[kudu-CR] Clarify that delta compaction is for REDOs

2016-08-11 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3944 to look at the new patch set (#2). Change subject: Clarify that delta compaction is for REDOs .. Clarify that

[kudu-CR] Clarify that delta compaction is for REDOs

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Clarify that delta compaction is for REDOs .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2818/ -- To view, visit

[kudu-CR] Clarify that minor delta compaction is for REDOs

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Clarify that minor delta compaction is for REDOs .. Patch Set 1: (1 comment) actually i have a couple more changes i want to make

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3871/2//COMMIT_MSG Commit Message: Line 19: The

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3943/1/src/kudu/common/timestamp.h File

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3943 To unsubscribe, visit

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Patch Set 12: Alexey: Feel free to abandon this. The alternative patch was merged:

[kudu-CR] Clarify that delta compaction is for REDOs

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Clarify that delta compaction is for REDOs .. Clarify that delta compaction is for REDOs This just clarifies docs and comments around delta compaction, as

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Chris George (Code Review)
Chris George has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 3: Specifically this documentation:

[kudu-CR] KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

2016-08-11 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3945 to look at the new patch set (#3). Change subject: KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Chris George (Code Review)
Chris George has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 3: Code-Review-1 I would prefer that we not drop CreatableRelationProvider. I'm using cassandra spark

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: fs_tool: improve format for dumping a rowset .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2819/ -- To view, visit

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fs_tool: improve format for dumping a rowset .. Patch Set 1: Given that the tool will now take a different code path entirely, could you amend the commit message

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Timestamp::FromUint64 should return void .. Timestamp::FromUint64 should return void It does no validation, can't fail, and has the same signature as one

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3946 Change subject: fs_tool: improve format for dumping a rowset .. fs_tool: improve format for dumping a rowset Change-Id:

[kudu-CR] KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1553: Crash when specifying multiple unbounded range predicates on a column .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2820/ --

[kudu-CR] KUDU-1555. PBC Flush() method should be async

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1555. PBC Flush() method should be async .. KUDU-1555. PBC Flush() method should be async WritablePBContainerFile::Flush is meant to flush the data

[kudu-CR] KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1553: Crash when specifying multiple unbounded range predicates on a column .. Patch Set 3: not sure why dist-test keeps having issues... I do see some SYN

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2833/ -- To view, visit

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. Patch Set 3: oops... accidentally un-pushed rev 2... -- To view, visit

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2823/ -- To view, visit

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3939 to look at the new patch set (#3). Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes

[kudu-CR] KUDU-1555. PBC Flush() method should be async

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1555. PBC Flush() method should be async .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2825/ -- To view, visit

[kudu-CR] KUDU-1555. PBC Flush() method should be async

2016-08-11 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3951 to review the following change. Change subject: KUDU-1555. PBC Flush() method should be async ..

[kudu-CR] maintenance manager: fix gflags docs

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: maintenance_manager: fix gflags docs .. maintenance_manager: fix gflags docs The gflag doc referenced an "emergency flush thread" which was removed more

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3952 Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode Implemented

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2827/ -- To view, visit

[kudu-CR] KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1553: Crash when specifying multiple unbounded range predicates on a column .. Patch Set 3: -Verified Build Started

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1474: single to multi-master deployment migration .. Patch Set 4: (15 comments)

[kudu-CR] KUDU-1555. PBC Flush() method should be async

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1555. PBC Flush() method should be async .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3951 To unsubscribe, visit

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3939 To unsubscribe,

[kudu-CR] maintenance manager: fix gflags docs

2016-08-11 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3950 to review the following change. Change subject: maintenance_manager: fix gflags docs .. maintenance_manager: fix

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3939 to look at the new patch set (#2). Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2822/ -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2811/ -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-11 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3668 to look at the new patch set (#8). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] Rename raft-remote-bootstrap design doc

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Rename raft-remote-bootstrap design doc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3890 To unsubscribe, visit

[kudu-CR] Rename raft-remote-bootstrap design doc

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Rename raft-remote-bootstrap design doc .. Rename raft-remote-bootstrap design doc Change-Id: I1bf1de7edfd1412eb744f0c72c0e8c6db5491044 Reviewed-on:

[kudu-CR] WIP: KUDU-236. Implement tablet history GC

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: KUDU-236. Implement tablet history GC .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2812/ -- To view, visit

[kudu-CR] Clarify that minor delta compaction is for REDOs

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Clarify that minor delta compaction is for REDOs .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2814/ -- To view, visit

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Timestamp::FromUint64 should return void .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2813/ -- To view, visit

[kudu-CR] WIP: KUDU-236. Implement tablet history GC

2016-08-11 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#5). Change subject: WIP: KUDU-236. Implement tablet history GC .. WIP: KUDU-236.

[kudu-CR] Clarify that minor delta compaction is for REDOs

2016-08-11 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3944 to review the following change. Change subject: Clarify that minor delta compaction is for REDOs .. Clarify that

[kudu-CR] Timestamp::FromUint64 should return void

2016-08-11 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3943 to review the following change. Change subject: Timestamp::FromUint64 should return void .. Timestamp::FromUint64

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 6: (14 comments) http://gerrit.cloudera.org:8080/#/c/3076/6/src/kudu/tablet/compaction.cc File

[kudu-CR](gh-pages) www: Add Spark Summit EU talk

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: www: Add Spark Summit EU talk .. www: Add Spark Summit EU talk Change-Id: I575c1ee7219a96a3c019cb2fe0899dfeef66 Reviewed-on:

[kudu-CR](gh-pages) www: Add Spark Summit EU talk

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: www: Add Spark Summit EU talk .. Patch Set 1: Code-Review+2 Verified+1 Tested, looks good -- To view, visit http://gerrit.cloudera.org:8080/3949 To unsubscribe,

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. Patch Set 1: Code-Review+1 A tiny nit: is it possible to re-format the commit message to preserve

[kudu-CR] KUDU-564 (part 1): log a 'diff' when tablet config changes

2016-08-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes .. Patch Set 1: > A tiny nit: is it possible to re-format the commit message to > preserve the useful