[kudu-CR] Remove pessimizing std::move() in return statement

2016-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Remove pessimizing std::move() in return statement .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4122 To unsubscribe, visit

[kudu-CR] tool: basic integration test

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: basic integration test .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3065/ -- To view, visit http://gerrit.cloudera.org:8080/4058

[kudu-CR] tool: basic integration test

2016-08-25 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4058 to look at the new patch set (#5). Change subject: tool: basic integration test .. tool: basic integration test

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new change for review. http://gerrit.cloudera.org:8080/4123 Change subject: KUDU-687: add replication factor to KuduTable .. KUDU-687: add replication factor to KuduTable This is generally useful,

[kudu-CR] tool: add ksck

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: add ksck .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3066/ -- To view, visit http://gerrit.cloudera.org:8080/4121 To unsubscribe,

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-687: add replication factor to KuduTable .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3067/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3070/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#4). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 1: (6 comments) This is good stuff.

[kudu-CR] tool: add ksck

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: add ksck .. Patch Set 2: Verified+1 Overriding Jenkins, known flake. -- To view, visit http://gerrit.cloudera.org:8080/4121 To unsubscribe, visit

[kudu-CR] tool: basic integration test

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: basic integration test .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4058/4/src/kudu/util/test_macros.h File src/kudu/util/test_macros.h:

[kudu-CR] Remove pessimizing std::move() in return statement

2016-08-25 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Remove pessimizing std::move() in return statement .. Remove pessimizing std::move() in return statement This change fixes this Clang warning: [334/463]

[kudu-CR] java: fix leak of TabletClient objects in client2tablets map

2016-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: fix leak of TabletClient objects in client2tablets map .. Patch Set 1: erg, this is a mess... apparently we were relying on this bug somehow so that, when

[kudu-CR] Rolling-upgrades compat for changing TSRegistrationPB

2016-08-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Rolling-upgrades compat for changing TSRegistrationPB .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/4062/5/src/kudu/master/ts_descriptor.cc

[kudu-CR] Actually support downgrade to version that has LocalConsensus

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Actually support downgrade to version that has LocalConsensus .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3068/ -- To view, visit

[kudu-CR] Rolling-upgrades compat for changing TSRegistrationPB

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Rolling-upgrades compat for changing TSRegistrationPB .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3069/ -- To view, visit

[kudu-CR] Rolling-upgrades compat for changing TSRegistrationPB

2016-08-25 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4062 to look at the new patch set (#6). Change subject: Rolling-upgrades compat for changing TSRegistrationPB ..

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 4: (14 comments) TFTR Adar/Alexey, updated the patch after addressing rev comments.

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#5). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3071/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 5: (3 comments) Just a couple of nits but this is otherwise good, though we still need to find

[kudu-CR] Rolling-upgrades compat for changing TSRegistrationPB

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Rolling-upgrades compat for changing TSRegistrationPB .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4062 To unsubscribe, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 22: Build Started http://104.196.14.100/job/kudu-gerrit/3072/ -- To view, visit

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-25 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4034 to look at the new patch set (#3). Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Add

[kudu-CR] Add AvroKuduEventProducer to Kudu-Flume integration

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add AvroKuduEventProducer to Kudu-Flume integration .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3073/ -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-25 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#22). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode ..

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 15: (8 comments) Thank you for your feedback. I'm posting a new version in a minute.

[kudu-CR] docs: update installation with new OS support

2016-08-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4128/1//COMMIT_MSG Commit Message: Line 10: 1.

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3079/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 6: (2 comments) TFTR Adar, will follow the JIRA suggestions for more testing tonight.

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#7). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] ksck: colorize and clean up output

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3081/ -- To view, visit

[kudu-CR] java: fix leak of TabletClient objects in client2tablets map

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: java: fix leak of TabletClient objects in client2tablets map .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3080/ -- To view, visit

[kudu-CR] tools: wrap descriptions

2016-08-25 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4130 to review the following change. Change subject: tools: wrap descriptions .. tools: wrap descriptions

[kudu-CR] tools: wrap descriptions

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tools: wrap descriptions .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3082/ -- To view, visit http://gerrit.cloudera.org:8080/4130 To

[kudu-CR] ksck: colorize and clean up output

2016-08-25 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4129 to review the following change. Change subject: ksck: colorize and clean up output .. ksck: colorize and

[kudu-CR] java: fix leak of TabletClient objects in client2tablets map

2016-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: fix leak of TabletClient objects in client2tablets map .. Patch Set 2: ignore the re-push, accidentally rebased -- To view, visit

[kudu-CR] WIP: ts-cli: add commands to trigger step-down and copying tablets

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: ts-cli: add commands to trigger step-down and copying tablets .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3075/ -- To view, visit

[kudu-CR] WIP: ts-cli: add commands to trigger step-down and copying tablets

2016-08-25 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3582 to look at the new patch set (#2). Change subject: WIP: ts-cli: add commands to trigger step-down and copying tablets

[kudu-CR] tool: basic integration test

2016-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: basic integration test .. tool: basic integration test So far all it does is spot check some help pages, but in the future we should augment it to

[kudu-CR] tool: add ksck

2016-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: add ksck .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4121 To unsubscribe, visit

[kudu-CR] tool: basic integration test

2016-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: basic integration test .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4058 To unsubscribe, visit

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-687: add replication factor to KuduTable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4123/1/src/kudu/client/client-test.cc File

[kudu-CR] Predicate evaluation pushdown

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3074/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 22: (18 comments) Did another pass. I'm still blown away by the overall complexity; I wonder if

[kudu-CR] master: include TS address in log messages

2016-08-25 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4131 to review the following change. Change subject: master: include TS address in log messages .. master:

[kudu-CR] master: include TS address in log messages

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master: include TS address in log messages .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3086/ -- To view, visit

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-687: add replication factor to KuduTable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4123/1/src/kudu/client/client-test.cc File

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-687: add replication factor to KuduTable .. KUDU-687: add replication factor to KuduTable This is generally useful, and necessary if ksck is to use

[kudu-CR] KUDU-687: add replication factor to KuduTable

2016-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-687: add replication factor to KuduTable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4123 To unsubscribe, visit

[kudu-CR] Rolling-upgrades compat for changing TSRegistrationPB

2016-08-25 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Rolling-upgrades compat for changing TSRegistrationPB .. Rolling-upgrades compat for changing TSRegistrationPB This should allow for adding fields to

[kudu-CR] Predicate evaluation pushdown

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3076/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Predicate evaluation pushdown

2016-08-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#6). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] docs: update installation with new OS support

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 1: Verified+1 Unrelated test flake. -- To view, visit http://gerrit.cloudera.org:8080/4128 To

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/c/3952/22/src/kudu/client/session-internal.cc

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 6: (2 comments) I left you some more comments in the JIRA regarding the testing.

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 22: (1 comment)

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 22: (2 comments) http://gerrit.cloudera.org:8080/#/c/3952/22/src/kudu/client/client.h File

[kudu-CR] docs: update installation with new OS support

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: docs: update installation with new OS support .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3077/ -- To view, visit

[kudu-CR] docs: update installation with new OS support

2016-08-25 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4128 to review the following change. Change subject: docs: update installation with new OS support .. docs: update

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#6). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3078/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 4: Addressed all the rev comments below, thanks Adar. Also updated commit message to reflect

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 22: (17 comments) Thank you for the review. I'll try to take a fresh look in the context of

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 22: (1 comment)

[kudu-CR] ksck: colorize and clean up output

2016-08-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4129 to look at the new patch set (#2). Change subject: ksck: colorize and clean up output .. ksck: colorize and clean

[kudu-CR] ksck: colorize and clean up output

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3084/ -- To view, visit

[kudu-CR] tools: wrap descriptions

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tools: wrap descriptions .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3083/ -- To view, visit http://gerrit.cloudera.org:8080/4130 To

[kudu-CR] java: inherit from ASF parent pom

2016-08-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4118 to look at the new patch set (#2). Change subject: java: inherit from ASF parent pom .. java: inherit from ASF

[kudu-CR] java: inherit from ASF parent pom

2016-08-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: inherit from ASF parent pom .. Patch Set 2: - updated to v18 of the parent pom. - I believe I've updated Cloudera's internal mvn-deploy job so that