[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-08 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#4). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP)

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP) .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3279/ -- To view, visit

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-08 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#9). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Predicate evaluation pushdown

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/3280/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Predicate evaluation pushdown

2016-09-08 Thread Andrew Wong (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#16). Change subject: Predicate evaluation pushdown .. Predicate

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/3281/ -- To view, visit

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 1: (8 comments) Do we also want something in the release notes about the API change +

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4320 to look at the new patch set (#2). Change subject: API and style improvements to the Kudu Flume Sink .. API and

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3282/ -- To view, visit

[kudu-CR] Predicate evaluation pushdown

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown The premise of this patch is to avoid the excessive use of CPU when evaluating column

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/9/src/kudu/common/column_predicate.cc File

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4320 to look at the new patch set (#3). Change subject: API and style improvements to the Kudu Flume Sink .. API and

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-08 Thread Andrew Wong (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#10). Change subject: Inlined dispatch for predicate evaluation ..

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/3283/ -- To view, visit

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 3: > > Do we also want something in the release notes about the API > change > > +

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [server] clean-up: stringstream --> ostringstream .. [server] clean-up: stringstream --> ostringstream Replaced std::stringstream with std::ostringstream

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 2: > Do we also want something in the release notes about the API change > +

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 3: > > don't forget about RegexpKuduEventProducer, > > which I need to rebase and refactor as

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

2016-09-08 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4328 to look at the new patch set (#2). Change subject: KUDU-1304 - [python] Enable listing of tablet servers ..

[kudu-CR] Tie log retention to consensus watermarks

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Tie log retention to consensus watermarks .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/4177/5//COMMIT_MSG Commit Message: Line 11:

[kudu-CR] rpc: print nicer errors when mixing up HTTP and KRPC

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: rpc: print nicer errors when mixing up HTTP and KRPC .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3287/ -- To view, visit

[kudu-CR] KUDU-1065: [java client] Flexible Partition Pruning

2016-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1065: [java client] Flexible Partition Pruning .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4299 To unsubscribe, visit

[kudu-CR] KUDU-1065: [java client] Flexible Partition Pruning

2016-09-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1065: [java client] Flexible Partition Pruning .. KUDU-1065: [java client] Flexible Partition Pruning This commit introduces an internal utility

[kudu-CR] KUDU-1065: [java client] Flexible Partition Pruning

2016-09-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1065: [java client] Flexible Partition Pruning .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1065: [java client] Flexible Partition Pruning

2016-09-08 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4299 to look at the new patch set (#3). Change subject: KUDU-1065: [java client] Flexible Partition Pruning ..

[kudu-CR] Tie log retention to consensus watermarks

2016-09-08 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4177 to look at the new patch set (#6). Change subject: Tie log retention to consensus watermarks .. Tie log retention

[kudu-CR] Tie log retention to consensus watermarks

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Tie log retention to consensus watermarks .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3286/ -- To view, visit

[kudu-CR] rpc: print nicer errors when mixing up HTTP and KRPC

2016-09-08 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4338 to review the following change. Change subject: rpc: print nicer errors when mixing up HTTP and KRPC .. rpc: print

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

2016-09-08 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1304 - [python] Enable listing of tablet servers .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4328/1/python/kudu/client.pyx File

[kudu-CR] KUDU-1420. client: remove unimplemented ApplyAsync() method

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1420. client: remove unimplemented ApplyAsync() method .. KUDU-1420. client: remove unimplemented ApplyAsync() method This was never implemented,

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: (2 comments) didn't really look at the implementation because I assume that's just moved code and

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 3: OK perfect -- To view, visit http://gerrit.cloudera.org:8080/4320 To unsubscribe, visit

[kudu-CR] KUDU-1420. client: remove unimplemented ApplyAsync() method

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1420. client: remove unimplemented ApplyAsync() method .. Patch Set 1: OK, I'll commit this removal for now, can always add it back with the magic of source

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: API and style improvements to the Kudu Flume Sink .. API and style improvements to the Kudu Flume Sink This patch cleans up the Flume integration code a

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/19/src/kudu/tablet/tablet.cc File

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/19/src/kudu/tablet/tablet.cc File

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add RegexpKuduOperationsProducer class .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3293/ -- To view, visit

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3883 to look at the new patch set (#4). Change subject: Add RegexpKuduOperationsProducer class .. Add

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/19/src/kudu/tablet/tablet.cc File

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 20: (9 comments) http://gerrit.cloudera.org:8080/#/c/3076/20/src/kudu/tablet/compaction.cc File

[kudu-CR] ksck: add a note about spurious checksum mismatches

2016-09-08 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4341 to review the following change. Change subject: ksck: add a note about spurious checksum mismatches .. ksck: add a

[kudu-CR] Fix flakiness in tablet replacement-itest

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Fix flakiness in tablet_replacement-itest .. Fix flakiness in tablet_replacement-itest This test was flaky because we were trying to perform a config

[kudu-CR] Fix flakiness in tablet replacement-itest

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix flakiness in tablet_replacement-itest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4342 To unsubscribe, visit

[kudu-CR] rpc: print nicer errors when mixing up HTTP and KRPC

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: rpc: print nicer errors when mixing up HTTP and KRPC .. rpc: print nicer errors when mixing up HTTP and KRPC Users often accidentally try to navigate to a

[kudu-CR] ksck: add a note about spurious checksum mismatches

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: ksck: add a note about spurious checksum mismatches .. ksck: add a note about spurious checksum mismatches Safe-time isn't properly respected on the

[kudu-CR] KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting .. Patch Set 1: Code-Review+1 (1 comment) lgtm

[kudu-CR] ksck: add a note about spurious checksum mismatches

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: ksck: add a note about spurious checksum mismatches .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4341 To unsubscribe, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-08 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#20). Change subject: KUDU-236 (part 1). Implement tablet history GC .. KUDU-236

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 6: (5 comments)

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3883 to look at the new patch set (#3). Change subject: Add RegexpKuduOperationsProducer class .. Add

[kudu-CR] Add RegexpKuduOperationsProducer class

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add RegexpKuduOperationsProducer class .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3292/ -- To view, visit

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1304 - [python] Enable listing of tablet servers .. KUDU-1304 - [python] Enable listing of tablet servers Kudu's python client currently doesn't

[kudu-CR] rpc: print nicer errors when mixing up HTTP and KRPC

2016-09-08 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4338 to look at the new patch set (#2). Change subject: rpc: print nicer errors when mixing up HTTP and KRPC

[kudu-CR] rpc: print nicer errors when mixing up HTTP and KRPC

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: rpc: print nicer errors when mixing up HTTP and KRPC .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3296/ -- To view, visit

[kudu-CR] ksck: add a note about spurious checksum mismatches

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: add a note about spurious checksum mismatches .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3297/ -- To view, visit

[kudu-CR] Fix flakiness in tablet replacement-itest

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix flakiness in tablet_replacement-itest .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3298/ -- To view, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 19: (22 comments) http://gerrit.cloudera.org:8080/#/c/3076/19/src/kudu/tablet/compaction-test.cc File

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3289/ -- To view, visit

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1304 - [python] Enable listing of tablet servers .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4328 To unsubscribe, visit

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 17: Do you guys think we should pull this in for 1.0 even though we don't have

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1304 - [python] Enable listing of tablet servers .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3291/ -- To view, visit

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

2016-09-08 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1304 - [python] Enable listing of tablet servers .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4328/2/python/kudu/client.pyx File

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

2016-09-08 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4328 to look at the new patch set (#3). Change subject: KUDU-1304 - [python] Enable listing of tablet servers ..

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 20: (9 comments) http://gerrit.cloudera.org:8080/#/c/3076/20/src/kudu/tablet/compaction.cc File

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 21: Build Started http://104.196.14.100/job/kudu-gerrit/3295/ -- To view, visit

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/3294/ -- To view, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-08 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#21). Change subject: KUDU-236 (part 1). Implement tablet history GC .. KUDU-236