[kudu-CR] Tie log retention to consensus watermarks

2016-09-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Tie log retention to consensus watermarks .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4177 To unsubscribe, visit

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

2016-09-09 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4344 Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. KUDU-854 - [python] Expose additional scanner

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-09-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 17: > Do you guys think we should pull this in for 1.0 even though we > don't

[kudu-CR] KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting

2016-09-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting .. Patch Set 1: (1 comment)

[kudu-CR] Fix one more flakiness in tablet replacement-itest

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix one more flakiness in tablet_replacement-itest .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3305/ -- To view, visit

[kudu-CR] KUDU-1594. Rename TIMESTAMP to UNIXTIME MICROS

2016-09-09 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4343 to look at the new patch set (#2). Change subject: KUDU-1594. Rename TIMESTAMP to UNIXTIME_MICROS .. KUDU-1594.

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3304/ -- To view, visit

[kudu-CR] java: fix leak of TabletClient objects in client2tablets map

2016-09-09 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4119 to look at the new patch set (#3). Change subject: java: fix leak of TabletClient objects in client2tablets map ..

[kudu-CR] java: fix leak of TabletClient objects in client2tablets map

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: java: fix leak of TabletClient objects in client2tablets map .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3308/ -- To view, visit

[kudu-CR] debug-util-test: address flakiness

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: debug-util-test: address flakiness .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3306/ -- To view, visit

[kudu-CR] debug-util-test: address flakiness

2016-09-09 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4346 to review the following change. Change subject: debug-util-test: address flakiness .. debug-util-test: address

[kudu-CR] Fix one more flakiness in tablet replacement-itest

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix one more flakiness in tablet_replacement-itest .. Patch Set 1: Verified+1 Test failure was an unrelated flake in debug-util-test. Put up a patch for that

[kudu-CR] Tie log retention to consensus watermarks

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Tie log retention to consensus watermarks .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3307/ -- To view, visit

[kudu-CR] Tie log retention to consensus watermarks

2016-09-09 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4177 to look at the new patch set (#7). Change subject: Tie log retention to consensus watermarks

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 9: Code-Review+2 (1 comment)

[kudu-CR] Tie log retention to consensus watermarks

2016-09-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Tie log retention to consensus watermarks .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4177 To unsubscribe, visit

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3974/9/build-support/lint.sh File

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3974/9/build-support/lint.sh File

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Create base class for MiniCluster and ExternalMiniCluster This allows utility classes to

[kudu-CR] Tie log retention to consensus watermarks

2016-09-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Tie log retention to consensus watermarks .. Patch Set 6: Code-Review+1 (3 comments) A couple very minor nits but they are ignorable. LGTM

[kudu-CR] Tie log retention to consensus watermarks

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Tie log retention to consensus watermarks .. Tie log retention to consensus watermarks This changes the calculation of log retention to consult

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 22: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3076 To unsubscribe, visit

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

2016-09-09 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4344 to look at the new patch set (#2). Change subject: KUDU-854 - [python] Expose additional scanner projection methods

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

2016-09-09 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4344 to look at the new patch set (#3). Change subject: KUDU-854 - [python] Expose additional scanner projection methods

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3310/ -- To view, visit

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

2016-09-09 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-1594. Rename TIMESTAMP to UNIXTIME MICROS

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1594. Rename TIMESTAMP to UNIXTIME_MICROS .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4343/2/docs/release_notes.adoc File

[kudu-CR] Add release notes for tablet history GC

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3314/ -- To view, visit

[kudu-CR] Add release notes for tablet history GC

2016-09-09 Thread Mike Percy (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3988 to look at the new patch set (#4). Change subject: Add release notes for tablet history GC .. Add

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 3). Enable tablet history GC by default .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3315/ -- To view, visit

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/3313/ -- To view, visit

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-09-09 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata The test

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4180/4/src/kudu/tools/kudu-admin-test.cc File

[kudu-CR] tool: rename tablet mode to local replica

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rename tablet mode to local_replica .. Patch Set 1: (2 comments)

[kudu-CR] delete table-test: make TestUnknownTabletsAreNotDeleted less flaky

2016-09-09 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4356 to review the following change. Change subject: delete_table-test: make TestUnknownTabletsAreNotDeleted less flaky ..

[kudu-CR] tool: rename tablet mode to local replica

2016-09-09 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4355 to review the following change. Change subject: tool: rename tablet mode to local_replica .. tool: rename tablet mode

[kudu-CR] tool: rename tablet mode to local replica

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: rename tablet mode to local_replica .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3318/ -- To view, visit

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-09-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/19/src/kudu/tablet/tablet.cc File

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 22: Build Started http://104.196.14.100/job/kudu-gerrit/3300/ -- To view, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-09 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#22). Change subject: KUDU-236 (part 1). Implement tablet history GC .. KUDU-236

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest .. Patch Set 10: (11 comments)

[kudu-CR] delete table-test: make TestUnknownTabletsAreNotDeleted less flaky

2016-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: delete_table-test: make TestUnknownTabletsAreNotDeleted less flaky .. Patch Set 1: (1 comment)

[kudu-CR] Add release notes for tablet history GC

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 5: (1 comment) is there somewhere that this also belongs in the docs?

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 3). Enable tablet history GC by default .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3983/5/src/kudu/tablet/tablet.cc File

[kudu-CR] tool: rename tablet mode to local replica

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: rename tablet mode to local_replica .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3328/ -- To view, visit

[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3327/ -- To view, visit

[kudu-CR] tool: rename tablet mode to local replica

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rename tablet mode to local_replica .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4355 To unsubscribe, visit

[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'

2016-09-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 6: Code-Review+1 (3 comments) LGTM, few nits and Qs as usual from my side.

[kudu-CR] python: bump version number to 0.3.0

2016-09-09 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Jordan Birdsell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4364 to review the following change. Change subject: python: bump version number to 0.3.0 ..

[kudu-CR] WIP: Add UNDO GC background task

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add UNDO GC background task .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3325/ -- To view, visit

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-09-09 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#11). Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest ..

[kudu-CR] Add release notes for tablet history GC

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3321/ -- To view, visit

[kudu-CR] WIP: Add UNDO GC background task

2016-09-09 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/4363 Change subject: WIP: Add UNDO GC background task .. WIP: Add UNDO GC background task Change-Id: I0309bf7acfb6d018860c80f354012c3500da5c68

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/3320/ -- To view, visit

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 3). Enable tablet history GC by default .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3322/ -- To view, visit

[kudu-CR] Update some comments in Tablet impl and rename a method

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Update some comments in Tablet impl and rename a method .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3323/ -- To view, visit

[kudu-CR] Separate tablet MM ops into separate .cc file

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Separate tablet MM ops into separate .cc file .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3324/ -- To view, visit

[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'

2016-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 5: Verified+1 Overriding Jenkins, spurious TSAN failure in debug-util-test (which Todd has

[kudu-CR] tool: rename tablet mode to local replica

2016-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: rename tablet mode to local_replica .. Patch Set 1: (2 comments)

[kudu-CR] java: fix leak of TabletClient objects in client2tablets map

2016-09-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: java: fix leak of TabletClient objects in client2tablets map .. Patch Set 3: (1 comment)

[kudu-CR] java: fix leak of TabletClient objects in client2tablets map

2016-09-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: java: fix leak of TabletClient objects in client2tablets map .. java: fix leak of TabletClient objects in client2tablets map After running YCSB

[kudu-CR] Update some comments in Tablet impl and rename a method

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update some comments in Tablet impl and rename a method .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3981 To unsubscribe,

[kudu-CR] Separate tablet MM ops into separate .cc file

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Separate tablet MM ops into separate .cc file .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4362/1/src/kudu/tablet/tablet_mm_ops.cc File

[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 6: (1 comment) looks good, 1 nit

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4344 To

[kudu-CR] KUDU-1594. Rename TIMESTAMP to UNIXTIME MICROS

2016-09-09 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4343 to review the following change. Change subject: KUDU-1594. Rename TIMESTAMP to UNIXTIME_MICROS .. KUDU-1594. Rename

[kudu-CR] KUDU-1594. Rename TIMESTAMP to UNIXTIME MICROS

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1594. Rename TIMESTAMP to UNIXTIME_MICROS .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3301/ -- To view, visit

[kudu-CR] Add release notes for tablet history GC

2016-09-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3988/1/docs/release_notes.adoc File

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

2016-09-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-854 - [python] Expose additional scanner projection methods .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-1594. Rename TIMESTAMP to UNIXTIME MICROS

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1594. Rename TIMESTAMP to UNIXTIME_MICROS .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3311/ -- To view, visit

[kudu-CR] Followup to 7eaeb6d9: fix typo in schema design.adoc

2016-09-09 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4354 to review the following change. Change subject: Followup to 7eaeb6d9: fix typo in schema_design.adoc .. Followup to

[kudu-CR] Followup to 7eaeb6d9: fix typo in schema design.adoc

2016-09-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Followup to 7eaeb6d9: fix typo in schema_design.adoc .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3312/ -- To view, visit

[kudu-CR] Add release notes for tablet history GC

2016-09-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3988/4/docs/release_notes.adoc File

[kudu-CR] KUDU-1594. Rename TIMESTAMP to UNIXTIME MICROS

2016-09-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1594. Rename TIMESTAMP to UNIXTIME_MICROS .. Patch Set 3: Code-Review+2 (1 comment) tiny nit, feel free to fix-and-push or ignore

[kudu-CR] KUDU-1594. Rename TIMESTAMP to UNIXTIME MICROS

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1594. Rename TIMESTAMP to UNIXTIME_MICROS .. KUDU-1594. Rename TIMESTAMP to UNIXTIME_MICROS As described in the JIRA, this is to reduce confusion

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-09-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 17: Code-Review+2 OK let's commit this :) -- To view, visit

[kudu-CR] Followup to 7eaeb6d9: fix typo in schema design.adoc

2016-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Followup to 7eaeb6d9: fix typo in schema_design.adoc .. Followup to 7eaeb6d9: fix typo in schema_design.adoc Accidentally wrote 'unix_microtime' instead

[kudu-CR] tool: rename tablet mode to local replica

2016-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: tool: rename tablet mode to local_replica .. tool: rename tablet mode to local_replica The tablet mode isn't actually going away, we're just going to use

[kudu-CR] delete table-test: make TestUnknownTabletsAreNotDeleted less flaky

2016-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: delete_table-test: make TestUnknownTabletsAreNotDeleted less flaky .. delete_table-test: make TestUnknownTabletsAreNotDeleted less flaky Let's take

[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'

2016-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4180/6/build-support/dist_test.py File

[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'

2016-09-09 Thread Adar Dembo (Code Review)
Hello Dinesh Bhat, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4180 to look at the new patch set (#7). Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet'

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list

2016-09-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list .. Patch Set 5: (22 comments) http://gerrit.cloudera.org:8080/#/c/4305/5/docs/release_notes.adoc File

[kudu-CR] KUDU-1594. Rename TIMESTAMP to UNIXTIME MICROS

2016-09-09 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4343 to look at the new patch set (#3). Change subject: KUDU-1594. Rename TIMESTAMP to UNIXTIME_MICROS .. KUDU-1594.

[kudu-CR] KUDU-1594. Rename TIMESTAMP to UNIXTIME MICROS

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1594. Rename TIMESTAMP to UNIXTIME_MICROS .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4343/3/docs/release_notes.adoc File

[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'

2016-09-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. tool: port kudu-admin to 'kudu table' and 'kudu tablet' The config change operations go to the