[kudu-CR] WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

2016-09-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4470 to look at the new patch set (#2). Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4440 to look at the new patch set (#5). Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-19 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/4417/8/python/kudu/client.pyx File

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-19 Thread Jordan Birdsell (Code Review)
Hello David Ribeiro Alves, Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4417 to look at the new patch set (#9). Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File

[kudu-CR] consensus: remove some unimplemented methods

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: consensus: remove some unimplemented methods .. consensus: remove some unimplemented methods Change-Id: I82089fa5a4d1e62e63c2656cc6ffeefccf10376c

[kudu-CR](gh-pages) Docs and download page for 1.0

2016-09-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Docs and download page for 1.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4472 To unsubscribe, visit

[kudu-CR](gh-pages) Remove 'beta' verbiage from site

2016-09-19 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4473 to review the following change. Change subject: Remove 'beta' verbiage from site .. Remove 'beta' verbiage

[kudu-CR](gh-pages) Docs and download page for 1.0

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Docs and download page for 1.0 .. Docs and download page for 1.0 Change-Id: I200e295652fea930f21d52836d75f3bc9c7a3db1 Reviewed-on:

[kudu-CR](gh-pages) Remove 'beta' verbiage from site

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Remove 'beta' verbiage from site .. Remove 'beta' verbiage from site Change-Id: I864b9fbbc1fc6c389ab4dc082e72a46cc99d9d68 Reviewed-on:

[kudu-CR](gh-pages) Remove 'beta' verbiage from site

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Remove 'beta' verbiage from site .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4473 To unsubscribe, visit

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

2016-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4471/1/src/kudu/client/client-test.cc File

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

2016-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4471/1/src/kudu/client/client-test.cc

[kudu-CR] consensus: fix some clang-tidy warnings

2016-09-19 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4454 to look at the new patch set (#2). Change subject: consensus: fix some clang-tidy warnings

[kudu-CR] metrics: move SCOPED LATENCY METRIC to metrics.h

2016-09-19 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4469 to review the following change. Change subject: metrics: move SCOPED_LATENCY_METRIC to metrics.h

[kudu-CR] [tests] MANUAL FLUSH --> AUTO FLUSH BACKGROUND

2016-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4471 Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND .. [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND In tests, run

[kudu-CR] WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target .. Patch Set 1: I ran a quick benchmark with this using YCSB and got similar performance

[kudu-CR] WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

2016-09-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4470 to look at the new patch set (#4). Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

[kudu-CR] WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

2016-09-19 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4470 to review the following change. Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

[kudu-CR] consensus: fix some clang-tidy warnings

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: fix some clang-tidy warnings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4454/1/src/kudu/consensus/log_metrics.h File

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4440 To

[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Document Impala and Spark integration known issues & limitations .. Patch Set 1: (1 comment) Is there a note anywhere mentioning that the Spark integration is

[kudu-CR] Implement an upgrade test

2016-09-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Implement an upgrade test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4424/2/src/kudu/integration-tests/upgrade-test.cc File

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4440 to look at the new patch set (#3). Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'

[kudu-CR] [tools]: Keep the verbosity of CLI at WARNING and above

2016-09-19 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4447 to review the following change. Change subject: [tools]: Keep the verbosity of CLI at WARNING and above

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 3: > > Also on an ortho topic of making the output to machine-readable > by > >

[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Document Impala and Spark integration known issues & limitations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4443/1/docs/developing.adoc File

[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-19 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4443 to look at the new patch set (#2). Change subject: Document Impala and Spark integration known issues & limitations

[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Document Impala and Spark integration known issues & limitations .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4443/2/docs/developing.adoc

[kudu-CR] KUDU-1623. Properly handle UPSERTS that only include PK column

2016-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4441 To

[kudu-CR] [tools]: Keep the verbosity of CLI at WARNING and above

2016-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at WARNING and above .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File

[kudu-CR] Python - Bump package version to 0.4.0

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Python - Bump package version to 0.4.0 .. Python - Bump package version to 0.4.0 There have been additional changes to the python client since the 0.3.0

[kudu-CR] KUDU-1623. Properly handle UPSERTS that only include PK column

2016-09-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4441 to look at the new patch set (#3). Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column

[kudu-CR] row operations-test: reduce iterations in ASAN build

2016-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: row_operations-test: reduce iterations in ASAN build .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4449 To unsubscribe,

[kudu-CR] Separated Dead and Live tablet server count in master web ui.

2016-09-19 Thread Ninad Shringarpure (Code Review)
Ninad Shringarpure has uploaded a new change for review. http://gerrit.cloudera.org:8080/4450 Change subject: Separated Dead and Live tablet server count in master web ui. .. Separated Dead and Live tablet server count in

[kudu-CR] [tools]: Keep the verbosity of CLI at WARNING and above

2016-09-19 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4447 to look at the new patch set (#2). Change subject: [tools]: Keep the verbosity of CLI at WARNING and above

[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()

2016-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord() .. Improve the debuggability of LogBlockContainer::CheckBlockRecord() We're

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File

[kudu-CR] consensus: fix some clang-tidy warnings

2016-09-19 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4454 to review the following change. Change subject: consensus: fix some clang-tidy warnings .. consensus: fix

[kudu-CR] Add a basic .clang-tidy configuration

2016-09-19 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4453 to review the following change. Change subject: Add a basic .clang-tidy configuration .. Add a basic

[kudu-CR] consensus: remove some unimplemented methods

2016-09-19 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4452 to review the following change. Change subject: consensus: remove some unimplemented methods .. consensus:

[kudu-CR] consensus: remove some unimplemented methods

2016-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: remove some unimplemented methods .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4452 To unsubscribe, visit

[kudu-CR] Add a basic .clang-tidy configuration

2016-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add a basic .clang-tidy configuration .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4453/1/src/kudu/.clang-tidy File src/kudu/.clang-tidy: Line

[kudu-CR] Add a basic .clang-tidy configuration

2016-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a basic .clang-tidy configuration .. Patch Set 1: any docs on how to use this locally? -- To view, visit http://gerrit.cloudera.org:8080/4453 To

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/4417/8/python/kudu/client.pyx File

[kudu-CR] KUDU-1623. Properly handle UPSERTS that only include PK column

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column .. Patch Set 2: (5 comments)

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 3: (1 comment)

[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()

2016-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4451 Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord() .. Improve the debuggability of

[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()

2016-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4451 To

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 3: (1 comment)

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-19 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4447 to look at the new patch set (#4). Change subject: [tools]: Keep the verbosity of CLI at FATAL and above

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Patch Set 3: (1 comment) Thanks, updated.

[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()

2016-09-19 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4451 to look at the new patch set (#2). Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord()

[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()

2016-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord() .. Patch Set 2: added printing out the file name -- To view, visit

[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4451 To

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 3: (1 comment)

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1623. Properly handle UPSERTS that only include PK column

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column .. KUDU-1623. Properly handle UPSERTS that only include PK column This fixes a bug

[kudu-CR] KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting .. KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting This adds a

[kudu-CR] [tools]: Keep the verbosity of CLI at WARNING and above

2016-09-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at WARNING and above .. Patch Set 1: (1 comment) TFTR Adar, please see below.

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-19 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4447 to look at the new patch set (#3). Change subject: [tools]: Keep the verbosity of CLI at FATAL and above

[kudu-CR] Implement an upgrade test

2016-09-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Implement an upgrade test .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4424/2/src/kudu/integration-tests/upgrade-test.cc File

[kudu-CR] Separated Dead and Live tablet server count in master web ui.

2016-09-19 Thread Ninad Shringarpure (Code Review)
Ninad Shringarpure has abandoned this change. Change subject: Separated Dead and Live tablet server count in master web ui. .. Abandoned Missed a test case. -- To view, visit http://gerrit.cloudera.org:8080/4450 To

[kudu-CR] Add a basic .clang-tidy configuration

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a basic .clang-tidy configuration .. Patch Set 1: (1 comment) Will add some scripting in a future commit for running this locally.

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc File

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4440 to look at the new patch set (#4). Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 4: (1 comment) TFTR Adar, updated the patch with new test added.

[kudu-CR] Separated Dead and Live tablet server count in master web ui.

2016-09-19 Thread Ninad Shringarpure (Code Review)
Ninad Shringarpure has restored this change. Change subject: Separated Dead and Live tablet server count in master web ui. .. Restored Made the required change and comiting the patch. -- To view, visit

[kudu-CR] Separated Dead and Live tablet server count in master web ui.

2016-09-19 Thread Ninad Shringarpure (Code Review)
Ninad Shringarpure has uploaded a new change for review. http://gerrit.cloudera.org:8080/4455 Change subject: Separated Dead and Live tablet server count in master web ui. .. Separated Dead and Live tablet server count in

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] Separated Dead and Live tablet server count in master web ui.

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Separated Dead and Live tablet server count in master web ui. .. Patch Set 1: hmm, were you looking at KUDU-1619? I think the intention here was to separate the

[kudu-CR] Separated Dead and Live tablet server count in master web ui.

2016-09-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Separated Dead and Live tablet server count in master web ui. .. Patch Set 2: Also, it seems like you've now got two reviews stacked on top of each other. Please