[kudu-CR] rpc: Add min / max negotiation threads

2016-09-30 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/4574 Change subject: rpc: Add min / max negotiation threads .. rpc: Add min / max negotiation threads Since we use a thread pool for connection

[kudu-CR] [WIP]KUDU-1640 - [python] Add IN-list predicate support

2016-09-30 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: [WIP]KUDU-1640 - [python] Add IN-list predicate support .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4548/3/python/kudu/client.pyx File

[kudu-CR] reactor: Minor tidy cleanup

2016-09-30 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/4573 Change subject: reactor: Minor tidy cleanup .. reactor: Minor tidy cleanup No functional changes Change-Id:

[kudu-CR] Bump up min negotiation threads in disk reservation-itest

2016-09-30 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/4575 Change subject: Bump up min negotiation threads in disk_reservation-itest .. Bump up min negotiation threads in disk_reservation-itest

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-30 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#6). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

2016-09-30 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4548 to look at the new patch set (#5). Change subject: KUDU-1640 - [python] Add IN-list predicate support .. KUDU-1640

[kudu-CR] [c++ client] added few deprecation notes

2016-09-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] added few deprecation notes .. Patch Set 2: (1 comment) I think that the get/set latest timestamp APIs can be marked with "unstable" or

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 7: (2 comments)

[kudu-CR] Remove newlines from raft consensus.cc state logging

2016-09-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Remove newlines from raft_consensus.cc state logging .. Patch Set 1: did you have a specific problem with the new lines? it seems like it helps with

[kudu-CR] Remove newlines from raft consensus.cc state logging

2016-09-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Remove newlines from raft_consensus.cc state logging .. Patch Set 1: (should say I don't fell super-strongly about it either way, mostly just curious)

[kudu-CR] reactor: Minor tidy cleanup

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: reactor: Minor tidy cleanup .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4573 To unsubscribe, visit

[kudu-CR] reactor: Minor tidy cleanup

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: reactor: Minor tidy cleanup .. reactor: Minor tidy cleanup No functional changes Change-Id: I27419e064e071995b4895e25e737b5acd610ec60 Reviewed-on:

[kudu-CR] Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager

2016-09-30 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4576 to review the following change. Change subject: Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-30 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#7). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

2016-09-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1640 - [python] Add IN-list predicate support .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4548/3/python/kudu/client.pyx File

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4533/6/src/kudu/tools/kudu-admin-test.cc

[kudu-CR] [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader .. Patch Set 1: (7 comments)

[kudu-CR] Python - Clean up distutils classifiers and package information

2016-09-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Python - Clean up distutils classifiers and package information .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4579 To

[kudu-CR] Python - Clean up distutils classifiers and package information

2016-09-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Python - Clean up distutils classifiers and package information .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4579/1/python/setup.py

[kudu-CR] rpc: Add min / max negotiation threads

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpc: Add min / max negotiation threads .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4574/1//COMMIT_MSG Commit Message: PS1, Line 9: it would

[kudu-CR] java: fix kudu-client builds with TSAN-only thirdparty

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: java: fix kudu-client builds with TSAN-only thirdparty .. Patch Set 1: Verified+1 Overriding Jenkins, filed KUDU-1669 for the failure. -- To view, visit

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

2016-09-30 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4548 to look at the new patch set (#4). Change subject: KUDU-1640 - [python] Add IN-list predicate support .. KUDU-1640

[kudu-CR] Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager

2016-09-30 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager .. Retry on early TimedOut error in

[kudu-CR] Bump up min negotiation threads in disk reservation-itest

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Bump up min negotiation threads in disk_reservation-itest .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4575/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Retry on early TimedOut error in ExternalMiniCluster::WaitForCatalogManager .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4576

[kudu-CR] Python - Clean up distutils classifiers and package information

2016-09-30 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4579 Change subject: Python - Clean up distutils classifiers and package information .. Python - Clean up distutils classifiers and package

[kudu-CR] Remove newlines from raft consensus.cc state logging

2016-09-30 Thread Dan Burkert (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4580 to review the following change. Change subject: Remove newlines from raft_consensus.cc state logging

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-30 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#8). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] [client-test] added basic test for RWYW behavior

2016-09-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [client-test] added basic test for RWYW behavior .. Patch Set 1: I have an ambivalent opinion regarding this test. Read Your Writes means that a client

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4533/6/src/kudu/tools/kudu-admin-test.cc

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-30 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#9). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] Remove newlines from raft consensus.cc state logging

2016-09-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Remove newlines from raft_consensus.cc state logging .. Patch Set 1: I found it confusing because it's not clear what it belongs to. I thought it may have been

[kudu-CR] [util] Fix a minor bug in AssertEventually()

2016-09-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4566/2/src/kudu/common/column_predicate.cc File

[kudu-CR] rpc: Add min / max negotiation threads

2016-09-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: Add min / max negotiation threads .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4574/1/src/kudu/rpc/messenger.h File

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 8: (5 comments)

[kudu-CR] [client-test] added basic test for RWYW behavior

2016-09-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [client-test] added basic test for RWYW behavior .. Patch Set 1: Btw, a more interesting test, perhaps, would be one that _always_ failed, i.e. that made

[kudu-CR] [c++ client] added few deprecation notes

2016-09-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++ client] added few deprecation notes .. Patch Set 2: (1 comment) > (1 comment) > > I think that the get/set latest timestamp APIs can be marked with >

[kudu-CR] Python - Clean up distutils classifiers and package information

2016-09-30 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: Python - Clean up distutils classifiers and package information .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4579/1/python/setup.py File

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4533 To unsubscribe,

[kudu-CR] [client-test] added basic test for RWYW behavior

2016-09-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4583 Change subject: [client-test] added basic test for RWYW behavior .. [client-test] added basic test for RWYW behavior Change-Id:

[kudu-CR] [util] shorten names for key/mapped types

2016-09-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4584 Change subject: [util] shorten names for key/mapped types .. [util] shorten names for key/mapped types There are not functional changes

[kudu-CR] [util] shorten names for key/mapped types

2016-09-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] shorten names for key/mapped types .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4584/1/src/kudu/gutil/map-util.h File

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 9: (6 comments)

[kudu-CR] java: fix kudu-client builds with TSAN-only thirdparty

2016-09-30 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4577 to review the following change. Change subject: java: fix kudu-client builds with TSAN-only thirdparty