[kudu-CR] KUDU-1682. Lock contention on table locations cache in Java client

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1682. Lock contention on table locations cache in Java client .. KUDU-1682. Lock contention on table locations cache in Java client

[kudu-CR] [java client] Cleanup AsyncKuduClient's unused caches

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Cleanup AsyncKuduClient's unused caches .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-1365. Add leader pre-elections

2016-10-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1365. Add leader pre-elections .. Patch Set 4: | I guess we need to do something such that a peer with an old term bumps its term up to at least the

[kudu-CR] [java client] Cleanup AsyncKuduClient's unused caches

2016-10-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Cleanup AsyncKuduClient's unused caches .. Patch Set 4: Code-Review+2 So no regression test for that race? -- To view, visit

[kudu-CR] consensus queue: make methods non-virtual

2016-10-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus_queue: make methods non-virtual .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4710 To unsubscribe, visit

[kudu-CR] [java client] Cleanup AsyncKuduClient's unused caches

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Cleanup AsyncKuduClient's unused caches .. Patch Set 4: > So no regression test for that race? Sorry, where in this gerrit did you mention a

[kudu-CR] [java client] Extract ip2client out of AsyncKuduClient

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4717 Change subject: [java client] Extract ip2client out of AsyncKuduClient .. [java client] Extract ip2client out of AsyncKuduClient

[kudu-CR] consensus: move ReplicaTransactionFactory into RaftConsensus

2016-10-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: move ReplicaTransactionFactory into RaftConsensus .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4711 To

[kudu-CR] [java client] Extract ip2client out of AsyncKuduClient

2016-10-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Extract ip2client out of AsyncKuduClient .. Patch Set 1: (3 comments) I looked at the ConnectionCache API and members, but only skimmed the method

[kudu-CR] [java client] Cleanup AsyncKuduClient's unused caches

2016-10-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Cleanup AsyncKuduClient's unused caches .. Patch Set 4: > > So no regression test for that race? > > Sorry, where in this gerrit did you mention a

[kudu-CR] consensus: remove bits of dead code

2016-10-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4712/1/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] [java client] Extract RemoteTablet from AsyncKuduClient

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4719 Change subject: [java client] Extract RemoteTablet from AsyncKuduClient .. [java client] Extract RemoteTablet from AsyncKuduClient

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. Patch Set 2: (1 comment)

[kudu-CR] consensus: split ReplicaState in twain[1]

2016-10-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: split ReplicaState in twain[1] .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. Patch Set 2: (1 comment)

[kudu-CR] consensus: split ReplicaState in twain[1]

2016-10-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: split ReplicaState in twain[1] .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4713/1/src/kudu/consensus/raft_consensus_state.h File

[kudu-CR] consensus: move more logic from ReplicaState to RaftConsensus

2016-10-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: move more logic from ReplicaState to RaftConsensus .. Patch Set 1: (2 comments)

[kudu-CR] [java client] Extract ip2client out of AsyncKuduClient

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Extract ip2client out of AsyncKuduClient .. Patch Set 1: (3 comments) > (3 comments) > > I looked at the ConnectionCache API and members,

[kudu-CR] [java client] Extract ip2client out of AsyncKuduClient

2016-10-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Extract ip2client out of AsyncKuduClient .. Patch Set 1: (2 comments)

[kudu-CR] [java client] Cleanup AsyncKuduClient's unused caches

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Cleanup AsyncKuduClient's unused caches .. [java client] Cleanup AsyncKuduClient's unused caches Originally, asynchbase came with a

[kudu-CR] [client.h] updated comment for CountBufferedOperations

2016-10-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4723 Change subject: [client.h] updated comment for CountBufferedOperations .. [client.h] updated comment for CountBufferedOperations

[kudu-CR] [java client] Extract RemoteTablet from AsyncKuduClient

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Extract RemoteTablet from AsyncKuduClient .. Patch Set 1: (4 comments) > (4 comments) > > As with the other patch, has anything actually

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure .. Patch Set 1: (1 comment)

[kudu-CR] [client.h] updated comment for CountBufferedOperations

2016-10-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client.h] updated comment for CountBufferedOperations .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4723/1/src/kudu/client/client.h File

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4724 to look at the new patch set (#2). Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure .. Patch Set 2: (1 comment)

[kudu-CR] [client.h] updated comment for CountBufferedOperations

2016-10-13 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4723 to look at the new patch set (#2). Change subject: [client.h] updated comment for CountBufferedOperations ..

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/4724 Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure .. KUDU-1700: Debug build will not fail

[kudu-CR] [java client] Extract ip2client out of AsyncKuduClient

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4717 to look at the new patch set (#2). Change subject: [java client] Extract ip2client out of AsyncKuduClient .. [java

[kudu-CR] [java client] Extract RemoteTablet from AsyncKuduClient

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4719 to look at the new patch set (#2). Change subject: [java client] Extract RemoteTablet from AsyncKuduClient ..

[kudu-CR] [java client] Extract ip2client out of AsyncKuduClient

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4717 to look at the new patch set (#3). Change subject: [java client] Extract ip2client out of AsyncKuduClient .. [java

[kudu-CR] [client.h] updated comment for CountBufferedOperations

2016-10-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [client.h] updated comment for CountBufferedOperations .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4723/1/src/kudu/client/client.h

[kudu-CR] [java client] Extract ip2client out of AsyncKuduClient

2016-10-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Extract ip2client out of AsyncKuduClient .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4724 to look at the new patch set (#3). Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

[kudu-CR] KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure

2016-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1700: Debug build will not fail gracefully on Messenger::Init() failure .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-1365. Add leader pre-elections

2016-10-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1365. Add leader pre-elections .. Patch Set 4: Sorry, made a typo in my scenario. Peer A has term 1, so when it sends pre-elections, it's for term 2 (the