[kudu-CR] KUDU-1696. Daemons should dump their version info to the INFO log at startup

2016-10-17 Thread Maxim Smyatkin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4733 to look at the new patch set (#2). Change subject: KUDU-1696. Daemons should dump their version info to the INFO log at startup

[kudu-CR] KUDU-1508: script for testing presence of bug and finding upper bounds

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1508: script for testing presence of bug and finding upper bounds .. Patch Set 2: Code-Review+2 Seems fine. I'll admit I didn't review it that carefully,

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. Patch Set 3: (1 comment)

[kudu-CR] consensus: remove bits of dead code

2016-10-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] consensus queue: make methods non-virtual

2016-10-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus_queue: make methods non-virtual .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4710 To unsubscribe, visit

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1508: script for testing presence of bug and finding upper bounds

2016-10-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1508: script for testing presence of bug and finding upper bounds .. Patch Set 2: > (btw in the future would prefer this kind of thing in python vs >

[kudu-CR] KUDU-1508: script for testing presence of bug and finding upper bounds

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1508: script for testing presence of bug and finding upper bounds .. Patch Set 2: I suppose, except that the shell regexes make my eyes bleed. Plus the

[kudu-CR] KUDU-1508: script for testing presence of bug and finding upper bounds

2016-10-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1508: script for testing presence of bug and finding upper bounds .. KUDU-1508: script for testing presence of bug and finding upper bounds This

[kudu-CR] KUDU-1684 - [python] Add Scan Resource Metrics Capabilities

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1684 - [python] Add Scan Resource Metrics Capabilities .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-1692: tie various reader memtrackers to the tablet tracker

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1692: tie various reader memtrackers to the tablet tracker .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1365. Add leader pre-elections

2016-10-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1365. Add leader pre-elections .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4694 To unsubscribe, visit

[kudu-CR] KUDU-1365. Add leader pre-elections

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1365. Add leader pre-elections .. KUDU-1365. Add leader pre-elections This implements the "pre-election" extension to the Raft algorithm. The idea

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4702

[kudu-CR] consensus peers: a little cleanup of cruft

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: consensus_peers: a little cleanup of cruft .. consensus_peers: a little cleanup of cruft * removes a test method that no longer was necessary * removes

[kudu-CR] consensus peers: a little cleanup of cruft

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: a little cleanup of cruft .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4704 To unsubscribe, visit

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. Patch Set 4: just a rebase -- To view, visit

[kudu-CR] consensus: move more logic from ReplicaState to RaftConsensus

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: move more logic from ReplicaState to RaftConsensus .. Patch Set 3: this one still needs a re-review -- To view, visit

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. KUDU-1135 (part 2): avoid flushing metadata twice when starting an

[kudu-CR] rpc: Add min / max negotiation threads

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: Add min / max negotiation threads .. Patch Set 1: (1 comment) Doing some tests on a very large cluster recently I ran into the fact that this wasn't

[kudu-CR] KUDU-1508: script for testing presence of bug and finding upper bounds

2016-10-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1508: script for testing presence of bug and finding upper bounds .. Patch Set 1: (5 comments) > can you write in the commit message or in the test header

[kudu-CR] [client.h] CountBufferedOperations marked as deprecated

2016-10-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [client.h] CountBufferedOperations marked as deprecated .. [client.h] CountBufferedOperations marked as deprecated

[kudu-CR] KUDU-1508: script for testing presence of bug and finding upper bounds

2016-10-17 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4730 to look at the new patch set (#2). Change subject: KUDU-1508: script for testing presence of bug and finding upper bounds

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-17 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#10). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-17 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#11). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add

[kudu-CR] KUDU-1696. Daemons should dump their version info to the INFO log at startup

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1696. Daemons should dump their version info to the INFO log at startup .. Patch Set 2: (1 comment)

[kudu-CR] ITBLL: use a faster PRNG

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: ITBLL: use a faster PRNG .. ITBLL: use a faster PRNG The SecureRandom PRNG is very very slow. Since we don't need cryptographic random numbers, we can

[kudu-CR] KUDU-1649 - [python] Add Binary Type Support

2016-10-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1649 - [python] Add Binary Type Support .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4653/2/python/kudu/client.pyx File

[kudu-CR] [IWYU] WIP: common/gutil/util/rpc

2016-10-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4738 Change subject: [IWYU] WIP: common/gutil/util/rpc .. [IWYU] WIP: common/gutil/util/rpc This are changes for the included headers

[kudu-CR] [IWYU] WIP: common/gutil/util/rpc

2016-10-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#2). Change subject: [IWYU] WIP: common/gutil/util/rpc .. [IWYU] WIP: