[kudu-CR] [tools] Fail ksck if fetching consensus state fails

2018-02-14 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9316 ) Change subject: [tools] Fail ksck if fetching consensus state fails .. [tools] Fail ksck if fetching consensus state fails

[kudu-CR](branch-1.5.x) KUDU-2238. DMS not flush under memory pressure.

2018-02-14 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9322 to review the following change. Change subject: KUDU-2238. DMS not flush under memory pressure. ..

[kudu-CR](branch-1.6.x) KUDU-2238. DMS not flush under memory pressure.

2018-02-14 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9323 Change subject: KUDU-2238. DMS not flush under memory pressure. .. KUDU-2238. DMS not flush under memory pressure. When we choose DMS

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

2018-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9255 ) Change subject: KUDU-2274 [itest] stress test for replica replacement .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] KUDU-2274 [itest] stress test for replica replacement

2018-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9255 ) Change subject: KUDU-2274 [itest] stress test for replica replacement .. Patch Set 5: Verified+1 (1 comment) Unreleated flakes in

[kudu-CR] [catalog manager] check re-replication scheme upon table creation

2018-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9321 Change subject: [catalog_manager] check re-replication scheme upon table creation .. [catalog_manager] check re-replication scheme upon

[kudu-CR] [tablet service] remove useless call

2018-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9324 Change subject: [tablet_service] remove useless call .. [tablet_service] remove useless call Removed useless call of

[kudu-CR] [catalog manager] check re-replication scheme upon table creation

2018-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9321 ) Change subject: [catalog_manager] check re-replication scheme upon table creation .. Patch Set 1: Verified+1 Unrelated fake in

[kudu-CR] [tablet service] remove useless call

2018-02-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9324 ) Change subject: [tablet_service] remove useless call .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [catalog manager] check re-replication scheme upon table creation

2018-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9321 ) Change subject: [catalog_manager] check re-replication scheme upon table creation .. Removed reviewer Kudu Jenkins with the

[kudu-CR] [tablet service] remove useless call

2018-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9324 ) Change subject: [tablet_service] remove useless call .. [tablet_service] remove useless call Removed useless call of

[kudu-CR] gutil: properly hook up ANNOTATE HAPPENS BEFORE/AFTER

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9325 to review the following change. Change subject: gutil: properly hook up ANNOTATE_HAPPENS_BEFORE/AFTER ..

[kudu-CR] KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9319 to look at the new patch set (#2). Change subject: KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing

[kudu-CR] rw semaphore: dont include debug-util.h when not necessary

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9328 to review the following change. Change subject: rw_semaphore: dont include debug-util.h when not necessary

[kudu-CR] KUDU-2297 (part 1): refactor metrics log out of ServerBase

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9326 to review the following change. Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase

[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9329 to review the following change. Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9330 to review the following change. Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log

[kudu-CR] KUDU-2291 (part 5): allow collecting stack traces asynchronously

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9318 to look at the new patch set (#2). Change subject: KUDU-2291 (part 5): allow collecting stack traces asynchronously

[kudu-CR] KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9327 to review the following change. Change subject: KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog

[kudu-CR] KUDU-1704: add c++ client support for READ YOUR WRITES mode

2018-02-14 Thread Hao Hao (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8823 to look at the new patch set (#7). Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-14 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Mike Percy, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8804 to look at the new patch set (#13). Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 12: (23 comments)

[kudu-CR] gutil: properly hook up ANNOTATE HAPPENS BEFORE/AFTER

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9325 to look at the new patch set (#2). Change subject: gutil: properly hook up ANNOTATE_HAPPENS_BEFORE/AFTER

[kudu-CR] KUDU-2291 (part 5): allow collecting stack traces asynchronously

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9318 to look at the new patch set (#3). Change subject: KUDU-2291 (part 5): allow collecting stack traces asynchronously

[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9329 to look at the new patch set (#2). Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9330 to look at the new patch set (#2). Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log

[kudu-CR] KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9319 to look at the new patch set (#3). Change subject: KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing

[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2

2018-02-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9333 ) Change subject: [CMakeLists] un-break build with gcc 4.9.2 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2

2018-02-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9333 ) Change subject: [CMakeLists] un-break build with gcc 4.9.2 .. Patch Set 1: I ran a test build on SLES12 with gcc 4.8.5 (Impala has

[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2

2018-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9333 Change subject: [CMakeLists] un-break build with gcc 4.9.2 .. [CMakeLists] un-break build with gcc 4.9.2 This is a quick fix to

[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2

2018-02-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9333 ) Change subject: [CMakeLists] un-break build with gcc 4.9.2 .. Patch Set 1: (1 comment) This change makes sense. I am testing on an SLES

[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2

2018-02-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9333 ) Change subject: [CMakeLists] un-break build with gcc 4.9.2 .. Patch Set 2: (1 comment)

[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2

2018-02-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9333 to look at the new patch set (#2). Change subject: [CMakeLists] un-break build with gcc 4.9.2

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-14 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9330 to look at the new patch set (#3). Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log