[kudu-CR] Fix move constructors to be noexcept

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9382 ) Change subject: Fix move constructors to be noexcept .. Patch Set 1: nope, I just didn't grep well enough to find those. Will fix --

[kudu-CR] thirdparty: patch tcmalloc to improve AllocLarge performance

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9392 to review the following change. Change subject: thirdparty: patch tcmalloc to improve AllocLarge performance ..

[kudu-CR] Fix move constructors to be noexcept

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9382 to look at the new patch set (#2). Change subject: Fix move constructors to be noexcept ..

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9393 Change subject: KUDU-2290: Tool to re-create a tablet .. KUDU-2290: Tool to re-create a tablet This adds a tool `kudu tablet

[kudu-CR] WIP: KUDU-2324. Add gflags to disable tablet data compaction

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9394 Change subject: WIP: KUDU-2324. Add gflags to disable tablet data compaction .. WIP: KUDU-2324. Add gflags to disable tablet data

[kudu-CR] WIP: KUDU-2324. Add gflags to disable tablet data compaction

2018-02-22 Thread Mike Percy (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9394 to look at the new patch set (#2). Change subject: WIP: KUDU-2324. Add gflags to disable tablet data compaction

[kudu-CR] [tablet] Avoid compactions in the past

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#11) to the change originally created by David Ribeiro Alves. ( http://gerrit.cloudera.org:8080/8965 ) Change subject: [tablet] Avoid compactions in the past .. [tablet] Avoid

[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9396 Change subject: Optionally advance safe time with non-write operations .. Optionally advance safe time with non-write operations

[kudu-CR] thirdparty: patch tcmalloc to improve AllocLarge performance

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9392 to look at the new patch set (#2). Change subject: thirdparty: patch tcmalloc to improve AllocLarge performance

[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9396 ) Change subject: Optionally advance safe time with non-write operations .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. KUDU-2301: (Part-1) Add instrumentation on

[kudu-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9397 Change subject: Don't perform compactions when clean time has not been advanced .. Don't perform compactions when clean time has

[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations

2018-02-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9396 to look at the new patch set (#2). Change subject: Optionally advance safe time with non-write operations

[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9396 ) Change subject: Optionally advance safe time with non-write operations .. Patch Set 1: (1 comment)

[kudu-CR] java: provide our own preferred cipher suite list

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9398 to review the following change. Change subject: java: provide our own preferred cipher suite list ..

[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9396 ) Change subject: Optionally advance safe time with non-write operations .. Patch Set 2: the build failed because of python, c++

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-02-22 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9378 to look at the new patch set (#3). Change subject: KUDU-2309: /masters can show the wrong list of masters

[kudu-CR] java: provide our own preferred cipher suite list

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9398 ) Change subject: java: provide our own preferred cipher suite list .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-02-22 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#2). Change subject: KUDU-2290: Tool to re-create a tablet .. KUDU-2290:

[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9396 ) Change subject: Optionally advance safe time with non-write operations .. Optionally advance safe time with non-write

[kudu-CR] java: provide our own preferred cipher suite list

2018-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9398 ) Change subject: java: provide our own preferred cipher suite list .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9397 ) Change subject: Don't perform compactions when clean time has not been advanced .. Patch Set 1: (1 comment)

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9397 to look at the new patch set (#2). Change subject: Don't perform compactions when clean time has not been advanced

[kudu-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9355 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. KUDU-2305: Fix local variable usage to handle 2GB

[kudu-CR] Improve tablet status messages during startup

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9400 ) Change subject: Improve tablet status messages during startup .. Improve tablet status messages during startup Currently while

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has removed a vote on this change. Change subject: Don't perform compactions when clean time has not been advanced .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] java: provide our own preferred cipher suite list

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9398 ) Change subject: java: provide our own preferred cipher suite list .. java: provide our own preferred cipher suite list This

[kudu-CR](branch-1.5.x) KUDU-2238. DMS not flush under memory pressure.

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9322 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. Patch Set 2: Verified+1 The python build failures are due to an old

[kudu-CR] row: optimize copying of MRS rows into the Arena

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9404 ) Change subject: row: optimize copying of MRS rows into the Arena .. Patch Set 1: (1 comment)

[kudu-CR] java: provide our own preferred cipher suite list

2018-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9398 ) Change subject: java: provide our own preferred cipher suite list .. Patch Set 2: (1 comment)

[kudu-CR] Improve tablet status messages during startup

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9400 to review the following change. Change subject: Improve tablet status messages during startup .. Improve tablet

[kudu-CR] Improve tablet status messages during startup

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9400 ) Change subject: Improve tablet status messages during startup .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] util: fix logged Kudu URL

2018-02-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9280 ) Change subject: util: fix logged Kudu URL .. Patch Set 3: > Patch Set 3: > > (3 comments) > > > Patch Set 3: > > > > > It's not just for

[kudu-CR](branch-1.6.x) KUDU-2238. DMS not flush under memory pressure.

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9323 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. KUDU-2238. DMS not flush under memory pressure. When we

[kudu-CR](branch-1.5.x) KUDU-2238. DMS not flush under memory pressure.

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9322 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9397 ) Change subject: Don't perform compactions when clean time has not been advanced .. Patch Set 2: (1 comment)

[kudu-CR] java: provide our own preferred cipher suite list

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9398 to look at the new patch set (#2). Change subject: java: provide our own preferred cipher suite list

[kudu-CR] KUDU-2039: /masters can show the wrong list of masters

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2039: /masters can show the wrong list of masters .. Patch Set 2: (5 comments)

[kudu-CR] java: provide our own preferred cipher suite list

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9398 to look at the new patch set (#3). Change subject: java: provide our own preferred cipher suite list

[kudu-CR] java: provide our own preferred cipher suite list

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9398 ) Change subject: java: provide our own preferred cipher suite list .. Patch Set 2: (1 comment)

[kudu-CR] thirdparty: patch tcmalloc to improve AllocLarge performance

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9392 ) Change subject: thirdparty: patch tcmalloc to improve AllocLarge performance .. Patch Set 2: I stress tested this with a read heavy

[kudu-CR] thirdparty: patch tcmalloc to improve AllocLarge performance

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9392 ) Change subject: thirdparty: patch tcmalloc to improve AllocLarge performance .. thirdparty: patch tcmalloc to improve AllocLarge

[kudu-CR] fs: clarify error message at startup

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9281 ) Change subject: fs: clarify error message at startup .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] util: fix logged Kudu URL

2018-02-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9280 ) Change subject: util: fix logged Kudu URL .. Patch Set 3: (3 comments) > Patch Set 3: > > > It's not just for dev builds. What prompted

[kudu-CR] util: fix logged Kudu URL

2018-02-22 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9280 ) Change subject: util: fix logged Kudu URL .. Patch Set 3: I wonder if it's worth embedding a specific version into our release at all.

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9397 ) Change subject: Don't perform compactions when clean time has not been advanced .. Patch Set 2: (1 comment)

[kudu-CR] util: fix logged Kudu URL

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9280 ) Change subject: util: fix logged Kudu URL .. Patch Set 3: > It's not just for dev builds. What prompted the change was that I > saw a

[kudu-CR] thirdparty: patch tcmalloc to improve AllocLarge performance

2018-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9392 ) Change subject: thirdparty: patch tcmalloc to improve AllocLarge performance .. Patch Set 2: I haven't reviewed the TCMalloc code, but

[kudu-CR] util: fix logged Kudu URL

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9280 ) Change subject: util: fix logged Kudu URL .. Patch Set 3: (3 comments)

[kudu-CR](branch-1.6.x) KUDU-2238. DMS not flush under memory pressure.

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9323 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) KUDU-2238. DMS not flush under memory pressure.

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9322 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. KUDU-2238. DMS not flush under memory pressure. When we

[kudu-CR] java: provide our own preferred cipher suite list

2018-02-22 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9398 ) Change subject: java: provide our own preferred cipher suite list .. Patch Set 2: (1 comment)

[kudu-CR] util: fix logged Kudu URL

2018-02-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9280 ) Change subject: util: fix logged Kudu URL .. Patch Set 3: (2 comments) > Patch Set 3: > > (2 comments) > > > This is only an issue in

[kudu-CR](branch-1.5.x) KUDU-2238. DMS not flush under memory pressure.

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9322 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has removed a vote on this change. Change subject: Optionally advance safe time with non-write operations .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9396 To

[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9396 ) Change subject: Optionally advance safe time with non-write operations .. Patch Set 2: Verified+1 unrelated java failure -- To

[kudu-CR] tools: add more detail about unsafe change config

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9278 ) Change subject: tools: add more detail about unsafe_change_config .. Patch Set 2: (4 comments)

[kudu-CR] row: optimize copying of MRS rows into the Arena

2018-02-22 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9404 to review the following change. Change subject: row: optimize copying of MRS rows into the Arena .. row:

[kudu-CR] [consensus peers] micro-optimization on controller status

2018-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9387 ) Change subject: [consensus_peers] micro-optimization on controller status .. [consensus_peers] micro-optimization on controller

[kudu-CR] [consensus peers] micro-optimization on controller status

2018-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9387 ) Change subject: [consensus_peers] micro-optimization on controller status .. Patch Set 2: > Patch Set 2: > > sure, seems fine, but for

[kudu-CR] [consensus peers] micro-optimization on controller status

2018-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9387 ) Change subject: [consensus_peers] micro-optimization on controller status .. Patch Set 2: > Patch Set 2: Code-Review+1 > > (1 comment)

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Make tcmalloc heap sampling more useful Previously our /pprof/heap

[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9396 ) Change subject: Optionally advance safe time with non-write operations .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9397 ) Change subject: Don't perform compactions when clean time has not been advanced .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 1: I think tidy bot is wrong about the using decls. -- To view,

[kudu-CR] util: fix logged Kudu URL

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9280 ) Change subject: util: fix logged Kudu URL .. Patch Set 3: (2 comments) > This is only an issue in development while working on

[kudu-CR] thirdparty: patch tcmalloc to improve AllocLarge performance

2018-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9392 ) Change subject: thirdparty: patch tcmalloc to improve AllocLarge performance .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9355 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 3: Errant ??- what I mean is I checked it builds on macOS -- To

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 3: Code-Review+2 Builds on macOS ✔️ -- To view, visit

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9397 ) Change subject: Don't perform compactions when clean time has not been advanced .. Patch Set 2: Verified+1 python flakyness once

[kudu-CR] row: optimize copying of MRS rows into the Arena

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9404 ) Change subject: row: optimize copying of MRS rows into the Arena .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9330 ) Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log .. Patch Set 9: Verified+1 IWYU failure from ancestor

[kudu-CR] KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9327 ) Change subject: KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog .. Patch Set 8: Verified+1 IWYU failure from

[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9329 ) Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. Patch Set 8: Verified+1 IWYU failure from

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-02-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 2: (5 comments) Mostly some nits and high-level points

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread David Ribeiro Alves (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9397 to look at the new patch set (#3). Change subject: Don't perform compactions when clean time has not been advanced

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9330 ) Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log .. Patch Set 8: (1 comment)

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9397 ) Change subject: Don't perform compactions when clean time has not been advanced .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2297 (part 1): refactor metrics log out of ServerBase

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9326 ) Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase .. Patch Set 8: Verified+1 IWYU failure from parent patch

[kudu-CR] KUDU-2297 (part 1): refactor metrics log out of ServerBase

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2297 (part 1): refactor metrics log out of ServerBase .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9326 To

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9216 ) Change subject: tablet: don't store row count in delta tracker .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9216 ) Change subject: tablet: don't store row count in delta tracker .. tablet: don't store row count in delta tracker DeltaTracker's

[kudu-CR] row: optimize copying of MRS rows into the Arena

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9404 ) Change subject: row: optimize copying of MRS rows into the Arena .. Patch Set 1: Code-Review+2 k, thanks for looking into it.

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9330

[kudu-CR] KUDU-2309: /masters can show the wrong list of masters

2018-02-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9378 ) Change subject: KUDU-2309: /masters can show the wrong list of masters .. Patch Set 3: (1 comment)

[kudu-CR] row: optimize copying of MRS rows into the Arena

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9404 ) Change subject: row: optimize copying of MRS rows into the Arena .. row: optimize copying of MRS rows into the Arena I tried a

[kudu-CR] KUDU-2291 (part 7): fix race in stack trace collection

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9406 Change subject: KUDU-2291 (part 7): fix race in stack trace collection .. KUDU-2291 (part 7): fix race in stack trace collection This

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9330 to look at the new patch set (#9). Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9397 ) Change subject: Don't perform compactions when clean time has not been advanced .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.5.x) Don't perform compactions when clean time has not been advanced

2018-02-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9397 ) Change subject: Don't perform compactions when clean time has not been advanced .. Don't perform compactions when clean

[kudu-CR] rw semaphore: dont include debug-util.h when not necessary

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9328 ) Change subject: rw_semaphore: dont include debug-util.h when not necessary .. Patch Set 6: (1 comment)

[kudu-CR] rw semaphore: dont include debug-util.h when not necessary

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9328 to look at the new patch set (#9). Change subject: rw_semaphore: dont include debug-util.h when not necessary

[kudu-CR] KUDU-2297 (part 4): periodically dump stacks to diagnostics log

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9330 ) Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization

2018-02-22 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9409 ) Change subject: KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization .. Patch Set 1: (2 comments)

[kudu-CR] webserver-stress-itest: fix flakiness

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9414 to review the following change. Change subject: webserver-stress-itest: fix flakiness .. webserver-stress-itest: fix

[kudu-CR] KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization

2018-02-22 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9409 to look at the new patch set (#3). Change subject: KUDU-2291 (part 8): fix a TSAN issue with libunwind initialization

  1   2   >