[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-04-13 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 1: (1 comment)

[kudu-CR] run-test.sh: treat empty gzipped output files as text files

2018-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10062 ) Change subject: run-test.sh: treat empty gzipped output files as text files .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10061 ) Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. Patch Set 1: (1 comment)

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

2018-04-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10057 ) Change subject: [java] KUDU-2407: Fix leaked protubuf generated class .. Patch Set 1: Code-Review+1 > Patch Set 1: > > It is and we

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

2018-04-13 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10057 ) Change subject: [java] KUDU-2407: Fix leaked protubuf generated class .. [java] KUDU-2407: Fix leaked protubuf generated class

[kudu-CR] [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option

2018-04-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-2406: derive filesystem block size from a temp file and not a directory

2018-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10063 ) Change subject: KUDU-2406: derive filesystem block size from a temp file and not a directory .. Patch Set 1: Code-Review+2 -- To

[kudu-CR] run-test.sh: treat empty gzipped output files as text files

2018-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10062 ) Change subject: run-test.sh: treat empty gzipped output files as text files .. run-test.sh: treat empty gzipped output files as

[kudu-CR] KUDU-2406: derive filesystem block size from a temp file and not a directory

2018-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10063 ) Change subject: KUDU-2406: derive filesystem block size from a temp file and not a directory .. KUDU-2406: derive filesystem

[kudu-CR] [tools] minor enhancements on 'kudu cluster ksck' output

2018-04-13 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 ) Change subject: [tools] minor enhancements on 'kudu cluster ksck' output .. Patch Set 5: (1 comment) How does this behave with table

[kudu-CR] [Java] Add Yetus doclet to Gradle build

2018-04-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10059 ) Change subject: [Java] Add Yetus doclet to Gradle build .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags

2018-04-13 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10061 Change subject: [tools] ksck improvements [5/n]: Checks for experimental, unsafe, hidden flags .. [tools] ksck improvements [5/n]:

[kudu-CR] KUDU-2406: derive filesystem block size from a temp file and not a directory

2018-04-13 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10063 to review the following change. Change subject: KUDU-2406: derive filesystem block size from a temp file and not a directory

[kudu-CR] run-test.sh: treat empty gzipped output files as text files

2018-04-13 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10062 to review the following change. Change subject: run-test.sh: treat empty gzipped output files as text files ..

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

2018-04-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10057 ) Change subject: [java] KUDU-2407: Fix leaked protubuf generated class .. Patch Set 1: It is and we don't. It was added in 1.5.0 and I

[kudu-CR] KUDU-2191 (10/n): Hive Metastore notification log event listener

2018-04-13 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8313 to look at the new patch set (#9). Change subject: KUDU-2191 (10/n): Hive Metastore notification log event listener

[kudu-CR] [Java] Add Yetus doclet to Gradle build

2018-04-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10059 ) Change subject: [Java] Add Yetus doclet to Gradle build .. Patch Set 1: (2 comments)

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

2018-04-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10057 ) Change subject: [java] KUDU-2407: Fix leaked protubuf generated class .. Patch Set 1: How do we know that it's safe to do this?

[kudu-CR] [Java] Add Yetus doclet to Gradle build

2018-04-13 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10059 Change subject: [Java] Add Yetus doclet to Gradle build .. [Java] Add Yetus doclet to Gradle build - Adds the yetus doclet to the gradle

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

2018-04-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10057 ) Change subject: [java] KUDU-2407: Fix leaked protubuf generated class .. Patch Set 1: Note: This interface is marked

[kudu-CR] [Java] Add Yetus doclet to Gradle build

2018-04-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10059 ) Change subject: [Java] Add Yetus doclet to Gradle build .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2191 (10/n): Hive Metastore notification log event listener

2018-04-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8313 ) Change subject: KUDU-2191 (10/n): Hive Metastore notification log event listener .. Patch Set 9: R9 includes another case that isn't

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

2018-04-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10057 ) Change subject: [java] KUDU-2407: Fix leaked protubuf generated class .. Patch Set 1: Seems fine to me, this is clearly not an API

[kudu-CR] [Java] Add Yetus doclet to Gradle build

2018-04-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10059 ) Change subject: [Java] Add Yetus doclet to Gradle build .. Patch Set 1: (2 comments)

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

2018-04-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10057 ) Change subject: [java] KUDU-2407: Fix leaked protubuf generated class .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docs] Update kudu-spark section and add Upsert ignoreNull subsection

2018-04-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9849 ) Change subject: [docs] Update kudu-spark section and add Upsert ignoreNull subsection .. Patch Set 1: (1 comment)

[kudu-CR] [Java] Add Yetus doclet to Gradle build

2018-04-13 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10059 ) Change subject: [Java] Add Yetus doclet to Gradle build .. [Java] Add Yetus doclet to Gradle build - Adds the yetus doclet to

[kudu-CR] [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option

2018-04-13 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option .. Patch Set 9: (1 comment)

[kudu-CR] [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option

2018-04-13 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Dan Burkert, Kudu Jenkins, Hao Hao, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9834 to look at the new patch set (#9). Change subject: [spark] KUDU-2371: Add KuduWriteOptions class and ignoreNull option

[kudu-CR] test util: include shard number in test scratch directory name

2018-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10069 ) Change subject: test_util: include shard number in test scratch directory name .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] test util: include shard number in test scratch directory name

2018-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10069 ) Change subject: test_util: include shard number in test scratch directory name .. test_util: include shard number in test

[kudu-CR] test util: include shard number in test scratch directory name

2018-04-13 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10069 to review the following change. Change subject: test_util: include shard number in test scratch directory name ..

[kudu-CR] [docs] Add lpeers output to ntp monitoring

2018-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10041 ) Change subject: [docs] Add lpeers output to ntp monitoring .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docs] Add lpeers output to ntp monitoring

2018-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10041 ) Change subject: [docs] Add lpeers output to ntp monitoring .. [docs] Add lpeers output to ntp monitoring The ntp monitoring had

[kudu-CR] [docs] Add warning about unsafe-change-config

2018-04-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9906 ) Change subject: [docs] Add warning about unsafe-change-config .. [docs] Add warning about unsafe-change-config Adding an

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

2018-04-13 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10057 Change subject: [java] KUDU-2407: Fix leaked protubuf generated class .. [java] KUDU-2407: Fix leaked protubuf generated class