[kudu-CR] [server] Add start time in server description

2019-02-12 Thread Yingchun Lai (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12304 to look at the new patch set (#6). Change subject: [server] Add start_time in server description

[kudu-CR] [server] Add start time in server description

2019-02-12 Thread Yingchun Lai (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12304 to look at the new patch set (#7). Change subject: [server] Add start_time in server description

[kudu-CR] [server] Add start time in server description

2019-02-12 Thread Yingchun Lai (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12304 to look at the new patch set (#5). Change subject: [server] Add start_time in server description

[kudu-CR] [server] Add start time in server description

2019-02-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12304 ) Change subject: [server] Add start_time in server description .. Patch Set 5: (9 comments)

[kudu-CR] fs: enable runtime container deletion for block manager-stress-test

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12455 Change subject: fs: enable runtime container deletion for block_manager-stress-test .. fs: enable runtime container deletion for

[kudu-CR] [docker] Optimize kudu image size

2019-02-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12371 ) Change subject: [docker] Optimize kudu image size .. Patch Set 3: (2 comments)

[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 ) Change subject: [tools] Add tablet data dirs to 'kudu remote replica list' .. Patch Set 1: (3 comments)

[kudu-CR] [tools] Add to 'kudu remote replica list' the ability to exclude schema and to filter on tablet id, table name

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12450 ) Change subject: [tools] Add to 'kudu remote_replica list' the ability to exclude schema and to filter on tablet id, table name .. Patch

[kudu-CR] Rename DeadlineTracker to TimeoutTracker

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12373 ) Change subject: Rename DeadlineTracker to TimeoutTracker .. Patch Set 3: (2 comments)

[kudu-CR] [client] Fix GetUnscaledDecimal backward compatiblity

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12446 ) Change subject: [client] Fix GetUnscaledDecimal backward compatiblity .. Patch Set 1: > I was thinking of ignoring IWYU given I didn't

[kudu-CR] [tools] Add tool to list data dirs for a tablet

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 ) Change subject: [tools] Add tool to list data dirs for a tablet .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [docker] Optimize kudu image size

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12371 ) Change subject: [docker] Optimize kudu image size .. Patch Set 3: (2 comments)

[kudu-CR] [tools] Add tool to list data dirs for a tablet

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 ) Change subject: [tools] Add tool to list data dirs for a tablet .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-2411: Update license information for binary test jars

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12431 ) Change subject: KUDU-2411: Update license information for binary test jars .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2411: fix dep pattern matching in relocation script

2019-02-12 Thread Adar Dembo (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12456 to review the following change. Change subject: KUDU-2411: fix dep pattern matching in relocation script ..

[kudu-CR] fs: enable runtime container deletion for block manager-stress-test

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12455 ) Change subject: fs: enable runtime container deletion for block_manager-stress-test .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tools] Add to 'kudu remote replica list' the ability to exclude schema and to filter on tablet id, table name

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12450 ) Change subject: [tools] Add to 'kudu remote_replica list' the ability to exclude schema and to filter on tablet id, table name .. Patch

[kudu-CR] KUDU-1868: Part 1: Add timer-based RPC timeouts

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12338 ) Change subject: KUDU-1868: Part 1: Add timer-based RPC timeouts .. Patch Set 7: (3 comments)

[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 ) Change subject: [tools] Add tablet data dirs to 'kudu remote replica list' .. Patch Set 1: (1 comment)

[kudu-CR] [tools] Add tablet data dirs to 'kudu remote replica list'

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 ) Change subject: [tools] Add tablet data dirs to 'kudu remote replica list' .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-1868 Part 2: Eliminate socket read timeout except for negotiation

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12363 ) Change subject: KUDU-1868 Part 2: Eliminate socket read timeout except for negotiation .. Patch Set 4: (2 comments)

[kudu-CR] [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12445 to look at the new patch set (#3). Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized()

[kudu-CR] KUDU-2411: Exclude libz from binary jar on macOS

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12444 ) Change subject: KUDU-2411: Exclude libz from binary jar on macOS .. Patch Set 2: (1 comment)

[kudu-CR] [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12445 ) Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized() .. Patch Set 3: (5 comments)

[kudu-CR] [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Alexey Serbin (Code Review)
Hello Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12445 to look at the new patch set (#4). Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized()

[kudu-CR] KUDU-2674: [java] Add a Java KuduPartitioner API

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12275 ) Change subject: KUDU-2674: [java] Add a Java KuduPartitioner API .. Patch Set 6: (5 comments)

[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12459 ) Change subject: [CMakeLists] get rid of warnings in ASAN builds .. Patch Set 1: (1 comment)

[kudu-CR] Schema copy and move constructors/operators must copy max col id

2019-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12415 ) Change subject: Schema copy and move constructors/operators must copy max_col_id_ .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2645: schema: Add support for virtual columns in projections

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12204 ) Change subject: KUDU-2645: schema: Add support for virtual columns in projections .. Patch Set 4: (2 comments)

[kudu-CR] [webserver] Add table name filter to JSON metrics

2019-02-12 Thread Zhang Yifan (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12467 to look at the new patch set (#4). Change subject: [webserver] Add table name filter to JSON metrics ..

[kudu-CR] [server] Add start time in server description

2019-02-12 Thread Yingchun Lai (Code Review)
Hello Dan Burkert, Zhang Yifan, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12304 to look at the new patch set (#10). Change subject: [server] Add start_time in server description

[kudu-CR] [webserver] Add table name filter to JSON metrics

2019-02-12 Thread Zhang Yifan (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12467 to look at the new patch set (#3). Change subject: [webserver] Add table name filter to JSON metrics ..

[kudu-CR] Schema copy and move constructors/operators must copy max col id

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12415 ) Change subject: Schema copy and move constructors/operators must copy max_col_id_ .. Patch Set 3: (5 comments)

[kudu-CR] KUDU-2645: schema: Validate that defaults are provided for virtual columns

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12416 ) Change subject: KUDU-2645: schema: Validate that defaults are provided for virtual columns .. Patch Set 4: (1 comment)

[kudu-CR](branch-1.9.x) [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12464 ) Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized() .. [security] KUDU-2695 fix CheckOpenSSLInitialized() With

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 12: Code-Review+2 (2 comments)

[kudu-CR](branch-1.9.x) KUDU-2411: fix dep pattern matching in relocation script

2019-02-12 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12460 ) Change subject: KUDU-2411: fix dep pattern matching in relocation script .. KUDU-2411: fix dep pattern matching in relocation

[kudu-CR] [webserver] Add entity ID filter and table name filter on webserver metrics page

2019-02-12 Thread Zhang Yifan (Code Review)
Zhang Yifan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12467 Change subject: [webserver] Add entity ID filter and table name filter on webserver metrics page .. [webserver] Add entity ID filter and

[kudu-CR] KUDU-2645: tablet: Support deduplication of deleted rows in MergeIterator

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12205 ) Change subject: KUDU-2645: tablet: Support deduplication of deleted rows in MergeIterator .. Patch Set 3: (18 comments)

[kudu-CR](branch-1.9.x) [CMakeLists] get rid of warnings in ASAN builds

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12466 ) Change subject: [CMakeLists] get rid of warnings in ASAN builds .. [CMakeLists] get rid of warnings in ASAN builds This patch

[kudu-CR] KUDU-2693. Buffer blocks while flushing rowsets

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12425 ) Change subject: KUDU-2693. Buffer blocks while flushing rowsets .. Patch Set 1: (11 comments)

[kudu-CR] [webserver] Add entity ID filter and table name filter to JSON metrics

2019-02-12 Thread Zhang Yifan (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12467 to look at the new patch set (#2). Change subject: [webserver] Add entity ID filter and table name filter to JSON metrics

[kudu-CR] [webserver] Add table name filter to JSON metrics

2019-02-12 Thread Zhang Yifan (Code Review)
Zhang Yifan has uploaded a new patch set (#9) to the change originally created by Yingchun Lai. ( http://gerrit.cloudera.org:8080/12304 ) Change subject: [webserver] Add table name filter to JSON metrics .. [webserver] Add

[kudu-CR] KUDU-2693. Buffer blocks while flushing rowsets

2019-02-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12425 ) Change subject: KUDU-2693. Buffer blocks while flushing rowsets .. Patch Set 1: (5 comments)

[kudu-CR] [client] Fix GetUnscaledDecimal backward compatiblity

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12446 ) Change subject: [client] Fix GetUnscaledDecimal backward compatiblity .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [client] Fix GetUnscaledDecimal backward compatiblity

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12446 ) Change subject: [client] Fix GetUnscaledDecimal backward compatiblity .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] wip: KUDU-2690: don't roll log schema on failed alter

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12462 Change subject: wip: KUDU-2690: don't roll log schema on failed alter .. wip: KUDU-2690: don't roll log schema on failed alter wip: I'm

[kudu-CR] [server] Add start time in server description

2019-02-12 Thread Yingchun Lai (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12304 to look at the new patch set (#8). Change subject: [server] Add start_time in server description

[kudu-CR] [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12445 ) Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized() .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [spark] Factor out the Spark/Kudu row converter

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12410 ) Change subject: [spark] Factor out the Spark/Kudu row converter .. Patch Set 1: Code-Review+1 (1 comment) Probably best to get a +2

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-02-12 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12122 to look at the new patch set (#11). Change subject: KUDU-2543 pt 2: pass around default authz tokens

[kudu-CR] [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12445 ) Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized() .. [security] KUDU-2695 fix CheckOpenSSLInitialized() With

[kudu-CR](branch-1.9.x) [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12464 to review the following change. Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized() ..

[kudu-CR](branch-1.9.x) [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12464 ) Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized() .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-02-12 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12122 to look at the new patch set (#12). Change subject: KUDU-2543 pt 2: pass around default authz tokens

[kudu-CR] [examples] updated README.md for basic-python-example

2019-02-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12458 to look at the new patch set (#2). Change subject: [examples] updated README.md for basic-python-example

[kudu-CR] fs: enable runtime container deletion for block manager-stress-test

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: fs: enable runtime container deletion for block_manager-stress-test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] KUDU-2411: fix dep pattern matching in relocation script

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12456 ) Change subject: KUDU-2411: fix dep pattern matching in relocation script .. KUDU-2411: fix dep pattern matching in relocation

[kudu-CR] fs: enable runtime container deletion for block manager-stress-test

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12455 ) Change subject: fs: enable runtime container deletion for block_manager-stress-test .. fs: enable runtime container deletion

[kudu-CR] fs: enable runtime container deletion for block manager-stress-test

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12455 ) Change subject: fs: enable runtime container deletion for block_manager-stress-test .. Patch Set 1: Verified+1 The failure is

[kudu-CR](branch-1.9.x) KUDU-2411: fix dep pattern matching in relocation script

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12460 ) Change subject: KUDU-2411: fix dep pattern matching in relocation script .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [spark-tools] DistributedDataGenerator repartition support

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12411 ) Change subject: [spark-tools] DistributedDataGenerator repartition support .. Patch Set 1: Code-Review+1 (2 comments)

[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12459 ) Change subject: [CMakeLists] get rid of warnings in ASAN builds .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12459 ) Change subject: [CMakeLists] get rid of warnings in ASAN builds .. Patch Set 1: (1 comment)

[kudu-CR] python: fix handling for non-SNAPSHOT versions

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12385 ) Change subject: python: fix handling for non-SNAPSHOT versions .. Patch Set 3: (1 comment)

[kudu-CR](branch-1.9.x) [client] Fix GetUnscaledDecimal backward compatiblity

2019-02-12 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12454 ) Change subject: [client] Fix GetUnscaledDecimal backward compatiblity .. [client] Fix GetUnscaledDecimal backward compatiblity

[kudu-CR](branch-1.9.x) [client] Fix GetUnscaledDecimal backward compatiblity

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12454 ) Change subject: [client] Fix GetUnscaledDecimal backward compatiblity .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [client] Fix GetUnscaledDecimal backward compatiblity

2019-02-12 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12446 ) Change subject: [client] Fix GetUnscaledDecimal backward compatiblity .. [client] Fix GetUnscaledDecimal backward compatiblity

[kudu-CR] [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12445 ) Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized() .. Patch Set 3: (5 comments)

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 10: (21 comments)

[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12459 ) Change subject: [CMakeLists] get rid of warnings in ASAN builds .. [CMakeLists] get rid of warnings in ASAN builds This patch

[kudu-CR](branch-1.9.x) [CMakeLists] get rid of warnings in ASAN builds

2019-02-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12466 ) Change subject: [CMakeLists] get rid of warnings in ASAN builds .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.9.x) [CMakeLists] get rid of warnings in ASAN builds

2019-02-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12466 to review the following change. Change subject: [CMakeLists] get rid of warnings in ASAN builds ..

[kudu-CR] [client] Fix GetUnscaledDecimal backward compatiblity

2019-02-12 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12446 to look at the new patch set (#2). Change subject: [client] Fix GetUnscaledDecimal backward compatiblity

[kudu-CR] [client] Fix GetUnscaledDecimal backward compatiblity

2019-02-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12446 ) Change subject: [client] Fix GetUnscaledDecimal backward compatiblity .. Patch Set 2: I updated the patch to fix the tidy errors. --

[kudu-CR] [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12445 ) Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized() .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] [examples] updated README.md for basic-python-example

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12458 Change subject: [examples] updated README.md for basic-python-example .. [examples] updated README.md for basic-python-example

[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12459 ) Change subject: [CMakeLists] get rid of warnings in ASAN builds .. Patch Set 1: (1 comment)

[kudu-CR] [Java] Add PartialRow and RowResult getObject API

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12393 ) Change subject: [Java] Add PartialRow and RowResult getObject API .. Patch Set 2: (4 comments)

[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds

2019-02-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12459 to look at the new patch set (#2). Change subject: [CMakeLists] get rid of warnings in ASAN builds

[kudu-CR] [client] Fix GetUnscaledDecimal backward compatiblity

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12446 ) Change subject: [client] Fix GetUnscaledDecimal backward compatiblity .. Patch Set 1: BTW, the clang-tidy errors are interesting. I'll

[kudu-CR] [CMakeLists] get rid of warnings in ASAN builds

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12459 Change subject: [CMakeLists] get rid of warnings in ASAN builds .. [CMakeLists] get rid of warnings in ASAN builds This patch updates

[kudu-CR](branch-1.9.x) KUDU-2411: fix dep pattern matching in relocation script

2019-02-12 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12460 Change subject: KUDU-2411: fix dep pattern matching in relocation script .. KUDU-2411: fix dep pattern matching in relocation script The

[kudu-CR] KUDU-2411: fix dep pattern matching in relocation script

2019-02-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12456 ) Change subject: KUDU-2411: fix dep pattern matching in relocation script .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [Java] Add setRow to Operation

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12409 ) Change subject: [Java] Add setRow to Operation .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12409/1//COMMIT_MSG

[kudu-CR] [security] KUDU-2695 fix CheckOpenSSLInitialized()

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12445 ) Change subject: [security] KUDU-2695 fix CheckOpenSSLInitialized() .. Patch Set 3: (1 comment) Unrelated flake in

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 11: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

2019-02-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 11: Code-Review+1 LGTM, might need to look into the IWYU

[kudu-CR] KUDU-2693. Buffer blocks while flushing rowsets

2019-02-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12425 ) Change subject: KUDU-2693. Buffer blocks while flushing rowsets .. Patch Set 1: (1 comment)

[kudu-CR](branch-1.9.x) WIP: add release notes for 1.9.0

2019-02-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 ) Change subject: WIP: add release notes for 1.9.0 .. Patch Set 2: (1 comment)