[kudu-CR] [test] Make the kudu-admin-test more rubust by adding AssertEventually

2019-08-15 Thread honeyhexin (Code Review)
honeyhexin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14070 Change subject: [test] Make the kudu-admin-test more rubust by adding AssertEventually .. [test] Make the kudu-admin-test more rubust by

[kudu-CR] docs: correct invalid link

2019-08-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14028 ) Change subject: docs: correct invalid link .. Patch Set 1: I see. It looks like there is a correct way to handle this so it works in

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-15 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Patch Set 4: I implemented an integration test case that

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-15 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#3). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-15 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#4). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-15 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 ) Change subject: [tools] Add table tools to delete column and alter column .. Patch Set 7: (18 comments)

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-15 Thread Yifan Zhang (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13976 to look at the new patch set (#7). Change subject: [tools] Add table tools to delete column and alter column

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-15 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#11). Change subject: [metrics] Merge metrics by the same attribute

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-15 Thread Yifan Zhang (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13976 to look at the new patch set (#8). Change subject: [tools] Add table tools to delete column and alter column

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-15 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13580 to look at the new patch set (#12). Change subject: [metrics] Merge metrics by the same attribute

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 11: (4 comments)

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-15 Thread Yifan Zhang (Code Review)
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13976 to look at the new patch set (#9). Change subject: [tools] Add table tools to delete column and alter column

[kudu-CR] KUDU-1938 [java] Add support for CHAR/VARCHAR pt 4

2019-08-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14050 ) Change subject: KUDU-1938 [java] Add support for CHAR/VARCHAR pt 4 .. Patch Set 4: (6 comments)

[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-08-15 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Alex Rodoni, Kudu Jenkins, Mitch Barnett, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12997 to look at the new patch set (#5). Change subject: [docs] updated docs w.r.t. collocation practices

[kudu-CR] [tools] Add table tools to delete column and alter column

2019-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 ) Change subject: [tools] Add table tools to delete column and alter column .. Patch Set 9: (5 comments)

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. Patch Set 12: Code-Review+2 (1 comment)

[kudu-CR] [metrics] Merge metrics by the same attribute

2019-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13580 ) Change subject: [metrics] Merge metrics by the same attribute .. [metrics] Merge metrics by the same attribute This patch merge

[kudu-CR] [test] Make the kudu-admin-test more rubust by adding AssertEventually

2019-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 ) Change subject: [test] Make the kudu-admin-test more rubust by adding AssertEventually .. Patch Set 1: (1 comment)

[kudu-CR] [test] Make the kudu-admin-test more rubust by adding AssertEventually

2019-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 ) Change subject: [test] Make the kudu-admin-test more rubust by adding AssertEventually .. Patch Set 1: (7 comments)

[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12997 ) Change subject: [docs] updated docs w.r.t. collocation practices .. Patch Set 4: > What is the status of this? Is this abandoned?

[kudu-CR] POC: Disable Sentry related tests

2019-08-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14020 ) Change subject: POC: Disable Sentry related tests .. Patch Set 1: (1 comment)

[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually

2019-08-15 Thread honeyhexin (Code Review)
honeyhexin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 ) Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually .. Patch Set 2: (6 comments)

[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually

2019-08-15 Thread honeyhexin (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14070 to look at the new patch set (#3). Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually

[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually

2019-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14070 ) Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually .. [test] Make the kudu-admin-test more

[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually

2019-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 ) Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually

2019-08-15 Thread honeyhexin (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14070 to look at the new patch set (#2). Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually

[kudu-CR] Prepare for upgrading to Hive 3

2019-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 ) Change subject: Prepare for upgrading to Hive 3 .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-2212 mute TSAN on destruction of a locked mutex in glog

2019-08-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13763 to look at the new patch set (#2). Change subject: KUDU-2212 mute TSAN on destruction of a locked mutex in glog

[kudu-CR] [llvm] back-port of fix for TSAN issue 944

2019-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14078 Change subject: [llvm] back-port of fix for TSAN issue 944 .. [llvm] back-port of fix for TSAN issue 944 See