[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: refactor: move SetEncryptionFlags to constructors .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20592 To

[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20592 ) Change subject: refactor: move SetEncryptionFlags to constructors .. Patch Set 1: Verified+1 The failed test

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 18: Code-Review+1 (1 comment)

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-18 Thread Wang Xixu (Code Review)
Hello Yuqi Du, Alexey Serbin, Yingchun Lai, Yifan Zhang, Attila Bukor, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19949 to look at the new patch set (#19). Change subject: KUDU-3483 Fix flushing data in batch when table schema

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-18 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 19: (1 comment)

[kudu-CR] KUDU-3497 optimize leader rebalancer algorithm

2023-10-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20310 to look at the new patch set (#15). Change subject: KUDU-3497 optimize leader rebalancer algorithm

[kudu-CR] KUDU-3516 No need to traverse all delta stores while computing score.

2023-10-18 Thread Song Jiacheng (Code Review)
Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20547 ) Change subject: KUDU-3516 No need to traverse all delta stores while computing score. .. Patch Set 12: (1 comment)

[kudu-CR] WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-10-18 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18569 to look at the new patch set (#48). Change subject: WIP KUDU-3371 [fs] Use RocksDB to store LBM metadata

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 16: Code-Review+1 (6 comments)

[kudu-CR] KUDU-3497 optimize leader rebalancer algorithm

2023-10-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20310 to look at the new patch set (#16). Change subject: KUDU-3497 optimize leader rebalancer algorithm

[kudu-CR] KUDU-3516 No need to traverse all delta stores while computing score.

2023-10-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Zoltan Martonka, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20547 to look at the new patch set (#14). Change subject: KUDU-3516 No need to traverse all delta stores while computing score.

[kudu-CR] KUDU-3516 No need to traverse all delta stores while computing score.

2023-10-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Zoltan Martonka, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20547 to look at the new patch set (#13). Change subject: KUDU-3516 No need to traverse all delta stores while computing score.

[kudu-CR] KUDU-3516 No need to traverse all delta stores while computing score.

2023-10-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Zoltan Martonka, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20547 to look at the new patch set (#12). Change subject: KUDU-3516 No need to traverse all delta stores while computing score.

[kudu-CR] KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

2023-10-18 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20582 ) Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4 .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 18: Code-Review+1 The failed test is related. -- To view, visit

[kudu-CR] [KUDU-3447] Limit tablets copying speed

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 ) Change subject: [KUDU-3447] Limit tablets copying speed .. Patch Set 18: Code-Review+2 -- To view, visit

[kudu-CR] refactor: move SetEncryptionFlags to constructors

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20592 Change subject: refactor: move SetEncryptionFlags to constructors .. refactor: move SetEncryptionFlags to constructors

[kudu-CR] KUDU-3516 No need to traverse all delta stores while computing score.

2023-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20547 ) Change subject: KUDU-3516 No need to traverse all delta stores while computing score. .. Patch Set 15: Code-Review+2 Thank you for

[kudu-CR] KUDU-3516 No need to traverse all delta stores while computing score.

2023-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20547 ) Change subject: KUDU-3516 No need to traverse all delta stores while computing score. .. KUDU-3516 No need to traverse all

[kudu-CR] logging for mini ranger

2023-10-18 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has abandoned this change. ( http://gerrit.cloudera.org:8080/20589 ) Change subject: logging for mini ranger .. Abandoned I accidentally pushed this up -- To view, visit http://gerrit.cloudera.org:8080/20589

[kudu-CR] KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

2023-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20582 ) Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4 .. KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

[kudu-CR] Make uncompress symbols local in exported libkudu client.so

2023-10-18 Thread Zoltan Martonka (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20590 to look at the new patch set (#2). Change subject: Make uncompress symbols local in exported libkudu_client.so ..

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-18 Thread Wang Xixu (Code Review)
Hello Yuqi Du, Alexey Serbin, Yingchun Lai, Yifan Zhang, Attila Bukor, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19949 to look at the new patch set (#18). Change subject: KUDU-3483 Fix flushing data in batch when table schema

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-18 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 ) Change subject: KUDU-3483 Fix flushing data in batch when table schema changed .. Patch Set 18: (6 comments)

[kudu-CR] KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

2023-10-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20582 ) Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3516 No need to traverse all delta stores while computing score.

2023-10-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Zoltan Martonka, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20547 to look at the new patch set (#15). Change subject: KUDU-3516 No need to traverse all delta stores while computing score.

[kudu-CR] KUDU-3483 Fix flushing data in batch when table schema changed

2023-10-18 Thread Wang Xixu (Code Review)
Hello Yuqi Du, Alexey Serbin, Yingchun Lai, Yifan Zhang, Attila Bukor, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19949 to look at the new patch set (#17). Change subject: KUDU-3483 Fix flushing data in batch when table schema

[kudu-CR] KUDU-3407 Avoid unchecked scheduling of flush operations.

2023-10-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20166 to look at the new patch set (#30). Change subject: KUDU-3407 Avoid unchecked scheduling of flush operations.

[kudu-CR] KUDU-3407 Avoid unchecked scheduling of flush operations.

2023-10-18 Thread Song Jiacheng (Code Review)
Hello Tidy Bot, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20166 to look at the new patch set (#31). Change subject: KUDU-3407 Avoid unchecked scheduling of flush operations.

[kudu-CR] logging for mini ranger

2023-10-18 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20589 Change subject: logging for mini ranger .. logging for mini ranger Change-Id: Id47b1bb7d712248965ff39a59c5f328d3414f006 --- M

[kudu-CR] [arm64] Make uncompress symbols local in exported libkudu client.so

2023-10-18 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20590 Change subject: [arm64] Make uncompress symbols local in exported libkudu_client.so .. [arm64] Make uncompress symbols local in

[kudu-CR] [build] Make uncompress symbols local in exported libkudu client.so

2023-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20590 ) Change subject: [build] Make uncompress symbols local in exported libkudu_client.so .. Patch Set 4: Verified+1 unrelated test

[kudu-CR] [build] Make uncompress symbols local in exported libkudu client.so

2023-10-18 Thread Zoltan Martonka (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20590 to look at the new patch set (#4). Change subject: [build] Make uncompress symbols local in exported libkudu_client.so

[kudu-CR] [build] Make uncompress symbols local in exported libkudu client.so

2023-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20590 ) Change subject: [build] Make uncompress symbols local in exported libkudu_client.so .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [build] Make uncompress symbols local in exported libkudu client.so

2023-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [build] Make uncompress symbols local in exported libkudu_client.so .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] [build] Make uncompress symbols local in exported libkudu client.so

2023-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20590 ) Change subject: [build] Make uncompress symbols local in exported libkudu_client.so .. [build] Make uncompress symbols local