[kudu-CR] [tests] fix a misprint

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21229 Change subject: [tests] fix a misprint .. [tests] fix a misprint Tests should use ASSERT_NE(), not DCHECK_NE(). This is a follow-up

[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes

2024-04-01 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 ) Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [gutil] fix compilation with clang 15

2024-04-01 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21206 ) Change subject: [gutil] fix compilation with clang 15 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [gutil] fix compilation with clang 15

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21206 ) Change subject: [gutil] fix compilation with clang 15 .. [gutil] fix compilation with clang 15 std::{binary,unary}_function

[kudu-CR](branch-1.17.x) KUDU-3562 fix integer overflow in available space metrics

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21228 Change subject: KUDU-3562 fix integer overflow in available space metrics .. KUDU-3562 fix integer overflow in available space metrics

[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 ) Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes .. Patch Set 2: Verified+1 unrelated test failures -- To

[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21212 ) Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes .. [rpc] relax settings for MeasureAcceptorDispatchTimes

[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21212 To

[kudu-CR] KUDU-3562 fix integer overflow in available space metrics

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21227 ) Change subject: KUDU-3562 fix integer overflow in available space metrics .. KUDU-3562 fix integer overflow in available space

[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Patch Set 1: Verified+1 unrelated test failures -- To view,

[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21226 To

[kudu-CR] [gutil] fix compilation with clang 15

2024-04-01 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21206 ) Change subject: [gutil] fix compilation with clang 15 .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3562 fix integer overflow in available space metrics

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21227 Change subject: KUDU-3562 fix integer overflow in available space metrics .. KUDU-3562 fix integer overflow in available space metrics

[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format

2024-04-01 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-3562 fix integer overflow in available space metrics

2024-04-01 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21227 to look at the new patch set (#2). Change subject: KUDU-3562 fix integer overflow in available space metrics

[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes

2024-04-01 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 ) Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3562 fix integer overflow in available space metrics

2024-04-01 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has removed a vote on this change. Change subject: KUDU-3562 fix integer overflow in available space metrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21227

[kudu-CR] KUDU-3562 fix integer overflow in available space metrics

2024-04-01 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21227 ) Change subject: KUDU-3562 fix integer overflow in available space metrics .. Patch Set 2: Verified+1 Code-Review+2 Thanks for

[kudu-CR] KUDU-3562 fix integer overflow in available space metrics

2024-04-01 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21227 ) Change subject: KUDU-3562 fix integer overflow in available space metrics .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21226 Change subject: KUDU-3561 skip tablet entities in Prometheus format .. KUDU-3561 skip tablet entities in Prometheus format Currently,

[kudu-CR] [codegen] use std::atomic instead of AtomicInt

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21225 ) Change subject: [codegen] use std::atomic instead of AtomicInt .. Patch Set 2: Verified+1 unrelated test failures -- To view, visit

[kudu-CR] [codegen] use std::atomic instead of AtomicInt

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [codegen] use std::atomic instead of AtomicInt .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21225 To unsubscribe,

[kudu-CR] [codegen] use std::atomic instead of AtomicInt

2024-04-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21225 ) Change subject: [codegen] use std::atomic instead of AtomicInt .. [codegen] use std::atomic instead of AtomicInt The