[kudu-CR] build: Make 'download-thirdparty.sh' resilient to failure

2016-08-07 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new change for review. http://gerrit.cloudera.org:8080/3857 Change subject: build: Make 'download-thirdparty.sh' resilient to failure .. build: Make 'download-thirdparty.sh' resilient to failure

[kudu-CR] build: Make 'download-thirdparty.sh' resilient to failure

2016-08-07 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new patch set (#2). Change subject: build: Make 'download-thirdparty.sh' resilient to failure .. build: Make 'download-thirdparty.sh' resilient to failure Many contributors work at home on flaky

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2017-01-31 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [python] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 10: Yep. I've been a little busy but I plan to get back to this. Should have some time this week.

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

2016-09-23 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#4). Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. [WIP]

[kudu-CR] [WIP][java] KUDU-1563. Add support for INSERT IGNORE

2016-09-23 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4523 to look at the new patch set (#3). Change subject: [WIP][java] KUDU-1563. Add support for INSERT IGNORE ..

[kudu-CR] [tests] fix test which fails with two cpus and document other dependencies

2016-09-25 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4446 to look at the new patch set (#5). Change subject: [tests] fix test which fails with two cpus and document other dependencies

[kudu-CR] [tests] fix test which fails with two cpus and document other dependencies

2016-09-25 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [tests] fix test which fails with two cpus and document other dependencies .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-09-25 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 7: Tests appear to be unrelated as the later patches had their tests pass. -- To view, visit

[kudu-CR] [tests] fix test which fails with two cpus and document other dependencies

2016-09-25 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [tests] fix test which fails with two cpus and document other dependencies .. Patch Set 5: Makes sense. I thought /proc/sys/kernel/pid_max was higher on 64bit

[kudu-CR] [tests] fix test which fails with two cpus and document other dependencies

2016-09-25 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4446 to look at the new patch set (#6). Change subject: [tests] fix test which fails with two cpus and document other dependencies

[kudu-CR] [tests] fix test which fails with two cpus and document other dependencies

2016-09-26 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [tests] fix test which fails with two cpus and document other dependencies .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4446/6//COMMIT_MSG

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2016-09-24 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4523 to look at the new patch set (#5). Change subject: [java] KUDU-1563. Add support for INSERT IGNORE .. [java]

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2016-09-24 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4522 to look at the new patch set (#3). Change subject: [python] KUDU-1563. Add support for INSERT IGNORE .. [python]

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-09-24 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#5). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-04 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 8: Thanks for the tip on the RPC thing. Spent some time looking into the RPC system and looks like it's

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

2016-09-21 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#2). Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. [WIP]

[kudu-CR] [tests] fix tests - two cpus and fresh install

2016-09-18 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new change for review. http://gerrit.cloudera.org:8080/4446 Change subject: [tests] fix tests - two cpus and fresh install .. [tests] fix tests - two cpus and fresh install

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 2: (1 comment) I am going to push a new series of patches. Still a WIP though.

[kudu-CR] [WIP][java] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new change for review. http://gerrit.cloudera.org:8080/4523 Change subject: [WIP][java] KUDU-1563. Add support for INSERT IGNORE .. [WIP][java] KUDU-1563. Add support for INSERT IGNORE Implements

[kudu-CR] [WIP][python] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new change for review. http://gerrit.cloudera.org:8080/4522 Change subject: [WIP][python] KUDU-1563. Add support for INSERT IGNORE .. [WIP][python] KUDU-1563. Add support for INSERT IGNORE

[kudu-CR] [WIP][java] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new patch set (#2). Change subject: [WIP][java] KUDU-1563. Add support for INSERT IGNORE .. [WIP][java] KUDU-1563. Add support for INSERT IGNORE Implements java support for the `INSERT IGNORE'

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

2016-09-21 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 2: (12 comments) Still have work todo, but wanted to wanted to get these comments out of my buffer.

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

2016-09-22 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4491/2/src/kudu/tablet/tablet.cc File

[kudu-CR] [tests] fix tests - two cpus and fresh install

2016-09-20 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [tests] fix tests - two cpus and fresh install .. Patch Set 2: Yep sounds good to me. I haven't fully investigated why the change fixes the test for me. The

[kudu-CR] [tests] fix tests - two cpus and fresh install

2016-09-20 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [tests] fix tests - two cpus and fresh install .. Patch Set 2: That does look similar. I can look into this more. It's actually bothering me that I cannot

[kudu-CR] [WIP] KUDU-1563. Add support for INSERT IGNORE

2016-09-20 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new change for review. http://gerrit.cloudera.org:8080/4491 Change subject: [WIP] KUDU-1563. Add support for INSERT IGNORE .. [WIP] KUDU-1563. Add support for INSERT IGNORE Add's `INSERT IGNORE'

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-02 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 7: (10 comments) http://gerrit.cloudera.org:8080/#/c/4491/7/src/kudu/integration-tests/fuzz-itest.cc File

[kudu-CR] [tests] fix test which fails with two cpus and document other dependencies

2016-09-24 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4446 to look at the new patch set (#4). Change subject: [tests] fix test which fails with two cpus and document other dependencies

[kudu-CR] [tests] fix tests - two cpus and fresh install

2016-09-24 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4446 to look at the new patch set (#3). Change subject: [tests] fix tests - two cpus and fresh install .. [tests] fix

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2016-09-25 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4522 to look at the new patch set (#4). Change subject: [python] KUDU-1563. Add support for INSERT IGNORE .. [python]

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-09-25 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#6). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-09-25 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#7). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-03 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#8). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2016-10-03 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4523 to look at the new patch set (#8). Change subject: [java] KUDU-1563. Add support for INSERT IGNORE .. [java]

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2016-10-03 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4522 to look at the new patch set (#6). Change subject: [python] KUDU-1563. Add support for INSERT IGNORE .. [python]

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2016-10-03 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [python] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 5: (2 comments) Thank you!

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2016-10-03 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [java] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 7: (6 comments)

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-10 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 8: As far as the C++ client, it looks like I can take a similar approach to the Java client

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-20 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 11: Hey guys, Any chance I could get a new review on this one? -- To view, visit

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-11-26 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/4491/11/src/kudu/client/batcher.cc File

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2016-11-28 Thread Brock Noland (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4523 to look at the new patch set (#15). Change subject: [java] KUDU-1563. Add support for INSERT IGNORE

[kudu-CR] Implement feature flag support on WriteRpc and add flag for INSERT IGNORE

2016-11-27 Thread Brock Noland (Code Review)
Brock Noland has uploaded a new change for review. http://gerrit.cloudera.org:8080/5241 Change subject: Implement feature flag support on WriteRpc and add flag for INSERT IGNORE .. Implement feature flag support on WriteRpc

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2016-11-27 Thread Brock Noland (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4523 to look at the new patch set (#14). Change subject: [java] KUDU-1563. Add support for INSERT IGNORE

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2016-11-27 Thread Brock Noland (Code Review)
Hello Jordan Birdsell, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4522 to look at the new patch set (#10). Change subject: [python] KUDU-1563. Add support for INSERT IGNORE

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-11-27 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#12). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-11 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 8: >From the JIRA "The Java client currently has an option to ignore duplicate row >key errors, which is

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-11 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 8: "Another thought is to do it at the RowOperations encoding time - you're already iterating over the

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-16 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#9). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2016-10-16 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: [java] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 9: I need to update the java client to send required features. -- To view, visit

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2016-10-16 Thread Brock Noland (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4523 to look at the new patch set (#10). Change subject: [java] KUDU-1563. Add support for INSERT IGNORE

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

2016-10-16 Thread Brock Noland (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4523 to look at the new patch set (#11). Change subject: [java] KUDU-1563. Add support for INSERT IGNORE

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-12 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 8: (17 comments) Updated patch should have these items addressed.

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-17 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#10). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-17 Thread Brock Noland (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#11). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add