[kudu-CR] Doxygen for C++ client API

2016-07-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Doxygen for C++ client API .. Doxygen for C++ client API If doxygen is available, build 'doxygen' taget to generate Doxygen docs from client.h and other

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-22 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3648 to look at the new patch set (#14). Change subject: KUDU-1311 [master] support adding and dropping range partitions

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 14: (2 comments)

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 15: (4 comments)

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-22 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3648 to look at the new patch set (#15). Change subject: KUDU-1311 [master] support adding and dropping range partitions

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-22 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3648 to look at the new patch set (#16). Change subject: KUDU-1311 [master] support adding and dropping range partitions

[kudu-CR] WIP [java client] Support add/remove partition

2016-07-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP [java client] Support add/remove partition .. Patch Set 1: (2 comments)

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 1)

2016-07-24 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3736 to review the following change. Change subject: [java-client] repackage to org.apache.kudu (Part 1)

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 3)

2016-07-24 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3738 to review the following change. Change subject: [java-client] repackage to org.apache.kudu (Part 3)

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: Thinking about this more, the 20s clamp is probably OK. It means we could theoretically not make

[kudu-CR] alter table-randomized-test: increase write timeout

2016-08-01 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3829 to review the following change. Change subject: alter_table-randomized-test: increase write timeout ..

[kudu-CR] KUDU-1358 (part 3): new multi-master stress test

2016-08-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3611 To unsubscribe, visit

[kudu-CR] KUDU-1553: kudu-client crash

2016-08-11 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3945 to look at the new patch set (#2). Change subject: KUDU-1553: kudu-client crash .. KUDU-1553: kudu-client crash

[kudu-CR] KUDU-1553: kudu-client crash

2016-08-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1553: kudu-client crash .. Patch Set 2: Thanks for the patch, Bruce! I suspected there may be even more issues lurking here, so I wrote up a bunch of test

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3871/2//COMMIT_MSG Commit Message: Line 19: The

[kudu-CR] KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

2016-08-11 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3945 to look at the new patch set (#3). Change subject: KUDU-1553: Crash when specifying multiple unbounded range predicates on a column

[kudu-CR] Reorganize range partition client API

2016-08-10 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3882 to look at the new patch set (#2). Change subject: Reorganize range partition client API .. Reorganize range

[kudu-CR] Reorganize range partition client API

2016-08-10 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3882 to look at the new patch set (#3). Change subject: Reorganize range partition client API .. Reorganize range

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 1: (6 comments)

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-09 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3859 to look at the new patch set (#2). Change subject: Add table id to AlterTableResponsePB .. Add table id to

[kudu-CR] [java client] Support add/remove partition

2016-08-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Support add/remove partition .. Patch Set 1: (10 comments)

[kudu-CR] [java client] Support add/remove partition

2016-08-09 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [java client] Support add/remove partition .. [java client] Support add/remove partition This also sneaks a fix into catalog manager to change the status

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add table id to AlterTableResponsePB .. Patch Set 3: (1 comment)

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-09 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3859 to look at the new patch set (#4). Change subject: Add table id to AlterTableResponsePB .. Add table

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-09 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3859 to look at the new patch set (#3). Change subject: Add table id to AlterTableResponsePB ..

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add table id to AlterTableResponsePB .. Patch Set 2: (4 comments)

[kudu-CR] Fix bug in partition key debug printing

2016-08-09 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3879 to look at the new patch set (#2). Change subject: Fix bug in partition key debug printing .. Fix bug

[kudu-CR] Fix bug in partition key debug printing

2016-08-09 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3879 to review the following change. Change subject: Fix bug in partition key debug printing .. Fix bug in

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-10 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Add table id to AlterTableResponsePB .. Add table id to AlterTableResponsePB This also changes the Java client to take advantage of the ID to selectively

[kudu-CR] env posix: improve error message on short writes

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: env_posix: improve error message on short writes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3959 To unsubscribe, visit

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 2: (8 comments) This is looking great. Sorry I've been so slow on reviews. I'd love to get this in for

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 4: (3 comments) Looking really good now, sorry I sent you down a rabbit hole with the CreatableRelation

[kudu-CR] Reorganize range partition client API

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Reorganize range partition client API .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3882/4/src/kudu/client/client.h File

[kudu-CR] [java-client] Reorganize range partition client API

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/3958 Change subject: [java-client] Reorganize range partition client API .. [java-client] Reorganize range partition client API Equivalient to

[kudu-CR] Reorganize range partition client API

2016-08-12 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3882 to look at the new patch set (#4). Change subject: Reorganize range partition client API .. Reorganize range

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3871 To unsubscribe, visit

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. KUDU-1533 Spark Kudu Rdd/Dataframe upsert This patch improves the Kudu SparkSQL integration in two ways: 1)

[kudu-CR] KUDU-1533 Spark Kudu Rdd/Dataframe upsert

2016-08-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert .. Patch Set 6: Thanks, Will! -- To view, visit http://gerrit.cloudera.org:8080/3871 To unsubscribe, visit

[kudu-CR] Reorganize range partition client API

2016-08-10 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/3882 Change subject: Reorganize range partition client API .. Reorganize range partition client API This commit redesigns the client APIs

[kudu-CR] KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 2: (1 comment)

[kudu-CR] docs: Add missing DISTRIBUTE to quickstart

2016-08-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: docs: Add missing DISTRIBUTE to quickstart .. Patch Set 1: Code-Review+2 LGTM. The DISTRIBUTE BY does go before the table properties

[kudu-CR] Fix remaining instance of kududb package in docs

2016-08-05 Thread Dan Burkert (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3844 to review the following change. Change subject: Fix remaining instance of kududb package in docs .. Fix

[kudu-CR] [flume] fix import of shaded guava class

2016-08-05 Thread Dan Burkert (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3845 to review the following change. Change subject: [flume] fix import of shaded guava class .. [flume] fix import of

[kudu-CR] Fix remaining instance of kududb package in docs

2016-08-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Fix remaining instance of kududb package in docs .. Fix remaining instance of kududb package in docs Change-Id: Ia829fa9a2b8de7621ccf40ab3b6aef1ff14f4c61

[kudu-CR] [flume] fix import of shaded guava class

2016-08-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [flume] fix import of shaded guava class .. [flume] fix import of shaded guava class Change-Id: Id5e290446e8d67e1899d36e68d45c413fdb08cff Reviewed-on:

[kudu-CR] WIP: add to JD's WIP add/drop range partition work for java client

2016-08-05 Thread Dan Burkert (Code Review)
Dan Burkert has abandoned this change. Change subject: WIP: add to JD's WIP add/drop range partition work for java client .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/3735 To unsubscribe, visit

[kudu-CR] WIP [java client] Support add/remove partition

2016-08-05 Thread Dan Burkert (Code Review)
Dan Burkert has abandoned this change. Change subject: WIP [java client] Support add/remove partition .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/3731 To unsubscribe, visit

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add table id to AlterTableResponsePB .. Patch Set 1: I'm using it in the rust client. There are a couple of cases where the field could be used in the C++ and

[kudu-CR] [java client] Upgrade hadoop-client to 2.7.2

2016-08-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Upgrade hadoop-client to 2.7.2 .. Patch Set 1: Code-Review+2 Thanks, I was hitting this as well. -- To view, visit

[kudu-CR] [java client] Support add/remove partition

2016-08-05 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3854 to review the following change. Change subject: [java client] Support add/remove partition .. [java

[kudu-CR] catalog manager: cleanup status messages

2016-08-07 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3858 to review the following change. Change subject: catalog manager: cleanup status messages .. catalog

[kudu-CR] Add table id to AlterTableResponsePB

2016-08-07 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3859 to review the following change. Change subject: Add table id to AlterTableResponsePB .. Add table id to

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3809/2/src/kudu/client/client-internal.cc File

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3828/1//COMMIT_MSG Commit Message: Line 7: make

[kudu-CR] make election timeout jitter more aggressive

2016-08-01 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3828 to review the following change. Change subject: make election timeout jitter more aggressive .. make

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3828/1//COMMIT_MSG Commit Message: Line 7: make

[kudu-CR] [java client] Support add/remove partition

2016-08-09 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3854 to look at the new patch set (#2). Change subject: [java client] Support add/remove partition .. [java client]

[kudu-CR] [java client] Support add/remove partition

2016-08-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Support add/remove partition .. Patch Set 2: (17 comments)

[kudu-CR] Add docs for non-covering range partitioning

2016-08-15 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3796 to look at the new patch set (#4). Change subject: Add docs for non-covering range partitioning .. Add docs for

[kudu-CR] Fix ScanToken generation with non-covering range partitions

2016-08-16 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Will Berkeley, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4007 to review the following change. Change subject: Fix ScanToken generation with non-covering range partitions

[kudu-CR] [c++-client] fix KuduScanTokenBuilder token generation bugs

2016-08-16 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4007 to look at the new patch set (#2). Change subject: [c++-client] fix KuduScanTokenBuilder token generation bugs

[kudu-CR] [c++-client] fix KuduScanTokenBuilder token generation bugs

2016-08-16 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4007 to look at the new patch set (#3). Change subject: [c++-client] fix KuduScanTokenBuilder token generation bugs

[kudu-CR](gh-pages) new range partitioning features blog post

2016-08-16 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/4012 Change subject: new range partitioning features blog post .. new range partitioning features blog post Change-Id:

[kudu-CR] [c++-client] fix KuduScanTokenBuilder token generation bugs

2016-08-16 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [c++-client] fix KuduScanTokenBuilder token generation bugs .. [c++-client] fix KuduScanTokenBuilder token generation bugs This commit fixes two critical

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/3952/6/src/kudu/client/client.cc File

[kudu-CR] [spark] Add insert-ignore, update, and delete as write options

2016-08-17 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4016 to review the following change. Change subject: [spark] Add insert-ignore, update, and delete as write options

[kudu-CR] Bump Squeasel version

2017-02-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Bump Squeasel version .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh File

[kudu-CR] Bump Squeasel version

2017-02-01 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5855 to look at the new patch set (#2). Change subject: Bump Squeasel version .. Bump

[kudu-CR] Add security-test dependency on security

2017-02-01 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5862 to review the following change. Change subject: Add security-test dependency on security .. Add security-test

[kudu-CR] [security] adjust TLS certificate verification

2017-02-02 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5865 to look at the new patch set (#3). Change subject: [security] adjust TLS certificate verification ..

[kudu-CR] [security] adjust TLS certificate verification

2017-02-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] adjust TLS certificate verification .. Patch Set 2: (1 comment) OK - I think the thing to do here is implement mutual cert authentication, then merge

[kudu-CR] [security] add channel binding to krpc

2017-02-03 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5884 to look at the new patch set (#6). Change subject: [security] add channel binding to krpc

[kudu-CR] [security] add channel binding to krpc

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] add channel binding to krpc .. Patch Set 6: Latest changes are just a rebase against todd's recently landed patches. -- To view, visit

[kudu-CR] [security] Simplify MakeSignature and VerifySignature impls

2017-02-02 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5880 to review the following change. Change subject: [security] Simplify MakeSignature and VerifySignature impls

[kudu-CR] [security] adjust TLS certificate verification

2017-02-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] adjust TLS certificate verification .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5865/3/src/kudu/rpc/sasl_common.h File

[kudu-CR] [security] Simplify MakeSignature and VerifySignature impls

2017-02-02 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [security] Simplify MakeSignature and VerifySignature impls .. [security] Simplify MakeSignature and VerifySignature impls Change-Id:

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

2017-02-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: client: rename various function calls and classes to ConnectToCluster .. Patch Set 2: (1 comment)

[kudu-CR] [security] add channel binding to krpc

2017-02-02 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5884 to review the following change. Change subject: [security] add channel binding to krpc .. [security]

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: uh oh... checkout

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: woops that was the ASAN docs. Interesting, though. I didn't think ASAN was

[kudu-CR] [security] add channel binding to krpc

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [security] add channel binding to krpc .. [security] add channel binding to krpc Channel binding prevents a MITM attack when using unauthenticated TLS

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5894 To

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: OK I was misremembering - ASAN has always worked on macOS (at least as far back

[kudu-CR] [thirdparty] Avoid building tsan on macOS on specific dep builds

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [thirdparty] Avoid building tsan on macOS on specific dep builds .. Patch Set 1: What command is failing for you? I remember in the past that something like

[kudu-CR] [security] adjust TLS certificate verification

2017-02-01 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5865 to look at the new patch set (#2). Change subject: [security] adjust TLS certificate verification ..

[kudu-CR] [security] Add negotiation test with TLS + GSSAPI

2017-02-01 Thread Dan Burkert (Code Review)
Dan Burkert has abandoned this change. Change subject: [security] Add negotiation test with TLS + GSSAPI .. Abandoned Rolled into https://gerrit.cloudera.org/#/c/5865/ -- To view, visit http://gerrit.cloudera.org:8080/5849

[kudu-CR] Add security-test dependency on security

2017-02-01 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Add security-test dependency on security .. Add security-test dependency on security Change-Id: I341de3a46af75ed9716eb81f22b0ef7e92029338 Reviewed-on:

[kudu-CR] [security] adjust TLS certificate verification

2017-02-01 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5865 to review the following change. Change subject: [security] adjust TLS certificate verification ..

[kudu-CR] master: issue authentication tokens and CA certs to clients

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: master: issue authentication tokens and CA certs to clients .. Patch Set 4: Code-Review+1 (2 comments)

[kudu-CR] master: issue authentication tokens and CA certs to clients

2017-02-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: master: issue authentication tokens and CA certs to clients .. Patch Set 4: (1 comment)

[kudu-CR] [security] add channel binding to krpc

2017-02-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] add channel binding to krpc .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5884/3/src/kudu/security/cert.cc File

[kudu-CR] Allow configuring TlsContext with key wrappers

2017-02-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Allow configuring TlsContext with key wrappers .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5845 To unsubscribe, visit

[kudu-CR] [security] Add negotiation test with TLS + GSSAPI

2017-01-31 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5849 to review the following change. Change subject: [security] Add negotiation test with TLS + GSSAPI .. [security] Add

[kudu-CR] [security] avoid crashing when importing invalid TSKs

2017-01-31 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5843 to review the following change. Change subject: [security] avoid crashing when importing invalid TSKs

[kudu-CR] [security] avoid crashing when importing invalid TSKs

2017-01-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] avoid crashing when importing invalid TSKs .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5843/1/src/kudu/security/token-test.cc

[kudu-CR] [security] sign/verify data using RSA key pair

2017-01-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] sign/verify data using RSA key pair .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/5805/13//COMMIT_MSG Commit Message: PS13, Line

[kudu-CR] [security] do actual token signing/verification

2017-01-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc

[kudu-CR] [security] method to extract public part of an RSA key

2017-01-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] method to extract public part of an RSA key .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5783 To unsubscribe,

[kudu-CR] [security] introduced crypto-test

2017-01-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] introduced crypto-test .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5798 To unsubscribe, visit

[kudu-CR] [security] sign/verify data using RSA key pair

2017-01-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] sign/verify data using RSA key pair .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5805 To unsubscribe, visit

  1   2   3   4   5   6   7   8   9   10   >