[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch

2016-07-22 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Update the docs webpages to reflect the master branch .. Patch Set 1: Sounds good Todd, if the consensus is to generate the docs after the release, I will

[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch

2016-07-22 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has abandoned this change. Change subject: Update the docs webpages to reflect the master branch .. Abandoned Abandoning this patch as this is outdated now, and we are gonna publish web pages aligned with release

[kudu-CR] Fix flakiness in RaftConsensusITest.TestReplaceChangeConfigOperation

2016-07-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix flakiness in RaftConsensusITest.TestReplaceChangeConfigOperation .. Patch Set 2: -Code-Review (1 comment)

[kudu-CR] Fix flakiness in RaftConsensusITest.TestReplaceChangeConfigOperation

2016-07-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix flakiness in RaftConsensusITest.TestReplaceChangeConfigOperation .. Patch Set 2: Code-Review+1 (1 comment) Thanks for quickly patching this Mike. Not your

[kudu-CR] KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata

2016-07-31 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has uploaded a new patch set (#2). Change subject: KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata .. KUDU-1500: Fix the data race during

[kudu-CR] Add docs for non-covering range partitioning

2016-08-03 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Add docs for non-covering range partitioning .. Patch Set 1: Also, please correct a typo in our FAQ along with this change: "partitioning is efficient when there

[kudu-CR] fs tool: improve format for dumping a rowset

2016-08-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: fs_tool: improve format for dumping a rowset .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3946 To unsubscribe, visit

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-13 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 8: (2 comments) TFTR Dan, addressed both comments with responses inline...

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-13 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#8). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has abandoned this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Abandoned abandoning due to duplicate links. original review is under

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has abandoned this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Abandoned abandoning due to duplicate links. original review is under

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has abandoned this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Abandoned abandoning due to duplicate links. original review is under

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-12 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#7). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-08 Thread Dinesh Bhat (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#3). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] rev 2

2016-08-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has uploaded a new change for review. http://gerrit.cloudera.org:8080/3870 Change subject: rev 2 .. rev 2 Change-Id: I779f00d3562484fb79dd7ff822d9c4b8939831c2 --- M src/kudu/tserver/tablet_service.cc 1 file

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-09 Thread Dinesh Bhat (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#6). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] catalog manager: avoid more races between Init() and GetTabletPeer()

2016-08-16 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: catalog_manager: avoid more races between Init() and GetTabletPeer() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3997/1//COMMIT_MSG Commit

[kudu-CR](gh-pages) Add weekly update for 8/16

2016-08-16 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Add weekly update for 8/16 .. Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/4008/1/_posts/2016-08-16-weekly-update.md File

[kudu-CR] [tools] Add missing help text from few tools

2017-02-02 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5885 to review the following change. Change subject: [tools] Add missing help text from few tools .. [tools]

[kudu-CR] tool: remove dead code

2017-01-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: remove dead code .. Patch Set 1: Code-Review+1 It's good you noticed them Adar. Ship it from my side. -- To view, visit

[kudu-CR] WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-02-17 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6066 to review the following change. Change subject: WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

[kudu-CR] [consensus] KUDU-1613: Fix replica eviction failure for WRONG SERVER UUID

2017-01-17 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID .. Patch Set 7: (6 comments) TFTR Mike, I will be adding one more test which changes

[kudu-CR] [consensus] KUDU-1613: Fix replica eviction failure for WRONG SERVER UUID

2017-01-17 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5111 to look at the new patch set (#8). Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID

[kudu-CR] [util] fixed env-test on OS X

2017-01-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] fixed env-test on OS X .. Patch Set 2: (2 comments) I am not seeing radio buttons on gerrit, perhaps some browser plugin issue I am facing at the moment,

[kudu-CR] WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-02-28 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6066 to look at the new patch set (#2). Change subject: WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-22 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 19: (17 comments) Hi Alexey, went through this patch more from knowledge point of view, so feel

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-24 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#9). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-24 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 8: (12 comments) TFTR MIke, addressed all the comments, and also re-ran the

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-24 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#10). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#4). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 4: (14 comments) TFTR Adar/Alexey, updated the patch after addressing rev comments.

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#5). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] tool: port log-dump

2016-08-31 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 3: (4 comments) Hi Adar, sorry I missed the train here, but these are more of curious questions than review comments as such so

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-08-31 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 3: Code-Review+1 (6 comments) Few nits, otherwise LGTM.

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-02 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4305 to review the following change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP) ..

[kudu-CR] tool: port log-dump

2016-09-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 3: > (3 comments) Thank you for the responses here. -- To view, visit http://gerrit.cloudera.org:8080/4167 To unsubscribe,

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: (6 comments) Consider +1 from me, except one Qn about REMOVE_SERVER below.

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-09-02 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4180/3/src/kudu/tools/tool_action_cluster.cc File

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-06 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP) .. Patch Set 1: (7 comments) TFTR Adar, updated the patch, please re-review, also added some more tests. I

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-06 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#2). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP)

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-06 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#3). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP)

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#8). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#9). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#10). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#11). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/10/src/kudu/tools/kudu-ts-cli-test.cc

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-09-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 10: (13 comments) TFTR folks, updated the diffs after a round of testing again. This addresses

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-08 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#4). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP)

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#6). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#5). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/2/src/kudu/tools/ts-cli.cc File

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-30 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3823 to look at the new patch set (#17). Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 17: (2 comments) TFTRs Mike/Dan/Adar, updated the patch to reflect the

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#7). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 7: > Subprocess::Call has optional out-parameters for stdout/stderr so > you can capture it

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-30 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: > Code change looks good, but how about a test in kudu-ts-cli-test? Yess, thought about

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-09-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 17: > Do you guys think we should pull this in for 1.0 even though we > don't

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list

2016-09-11 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list .. Patch Set 7: (1 comment) Thanks, please take a look at updated patch.

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-11 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#8). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-11 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#9). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-11 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 8: (35 comments) Thank you again Adar, addressed rev comments below, please see responses too

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list

2016-09-10 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#6). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#12). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 11: (6 comments)

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 11: (1 comment)

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#11). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 13: (2 comments)

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: Line

[kudu-CR] tool: port ts-cli

2016-09-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port ts-cli .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4373 To unsubscribe, visit

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#13). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool

[kudu-CR] tool: port kudu-admin to 'kudu table' and 'kudu tablet'

2016-09-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu table' and 'kudu tablet' .. Patch Set 6: Code-Review+1 (3 comments) LGTM, few nits and Qs as usual from my side.

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool .. Patch Set 9: (12 comments)

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list, fs tool

2016-09-12 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#10). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list, fs_tool

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-23 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4533 to review the following change. Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

2016-09-26 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has abandoned this change. Change subject: [tools]: Keep the verbosity of CLI at FATAL and above .. Abandoned Since we decided to keep the INFO level logs with these tools, this patch is not relevant anymore. Idea

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-29 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#5). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 3: (3 comments)

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-29 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#4). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 8: (1 comment)

[kudu-CR] [util] Fix a minor bug in AssertEventually()

2016-09-29 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4566 to review the following change. Change subject: [util] Fix a minor bug in AssertEventually()

[kudu-CR] [util] Fix a minor bug in AssertEventually()

2016-09-29 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4566 to look at the new patch set (#2). Change subject: [util] Fix a minor bug in AssertEventually()

[kudu-CR] [util] Fix a minor bug in AssertEventually()

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4566/1/src/kudu/common/column_predicate.cc File

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-05 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 3: (5 comments) TFTR Alexey,

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-05 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4594 to look at the new patch set (#4). Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-04 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4594 to look at the new patch set (#3). Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-04 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 2: (1 comment)

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-10-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 13: (1 comment)

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-10-07 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#13). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-10-07 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#12). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] delete table-test: fix flakiness with table creation timeout

2016-10-05 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: delete_table-test: fix flakiness with table creation timeout .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4632 To unsubscribe,

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-04 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 2: (1 comment)

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-16 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4440 to look at the new patch set (#2). Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-16 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 2: (2 comments) > (2 comments) > > Would be nice to get a little coverage of the

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-16 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4440/1//COMMIT_MSG Commit

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4440 to look at the new patch set (#5). Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 5: (1 comment)

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4440 to look at the new patch set (#3). Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'

[kudu-CR] [tools]: Keep the verbosity of CLI at WARNING and above

2016-09-19 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4447 to review the following change. Change subject: [tools]: Keep the verbosity of CLI at WARNING and above

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-19 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 3: > > Also on an ortho topic of making the output to machine-readable > by > >

  1   2   3   4   >