[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Fix a race involving the read timeout .. [java client] Fix a race involving the read timeout The ReadTimeoutHandler isn't something

[kudu-CR](gh-pages) Add weekly update for 07/25

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add weekly update for 07/25 .. Patch Set 1: Rendering: http://jdcryans.github.io/kudu/2016/07/26/weekly-update.html -- To view, visit

[kudu-CR](gh-pages) Add weekly update for 07/25

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3763 Change subject: Add weekly update for 07/25 .. Add weekly update for 07/25 Change-Id: I95de597ca5e33c05ec4f820315952310f07983a0

[kudu-CR](gh-pages) Add weekly update for 07/25

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add weekly update for 07/25 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3763/1/_posts/2016-07-26-weekly-update.md File

[kudu-CR](gh-pages) Add weekly update for 07/25

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new patch set (#2). Change subject: Add weekly update for 07/25 .. Add weekly update for 07/25 Change-Id: I95de597ca5e33c05ec4f820315952310f07983a0 --- A _posts/2016-07-26-weekly-update.md 1

[kudu-CR](gh-pages) Add weekly update for 07/25

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Hello Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3763 to look at the new patch set (#4). Change subject: Add weekly update for 07/25 .. Add weekly update for 07/25

[kudu-CR] KUDU-1542: in some cases apply will hang.

2016-07-26 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1542: in some cases apply will hang. .. Patch Set 2: (1 comment)

[kudu-CR] ksck: improve output for long-running ksck checksums

2016-07-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: ksck: improve output for long-running ksck checksums .. ksck: improve output for long-running ksck checksums Checksumming a large (multi-TB) table

[kudu-CR] KUDU-1516 ksck should check for more raft-related status issues (partial)

2016-07-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1516 ksck should check for more raft-related status issues (partial) .. KUDU-1516 ksck should check for more raft-related status issues

[kudu-CR] ksck: also print info about the good replicas for a bad tablet

2016-07-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: ksck: also print info about the good replicas for a bad tablet .. ksck: also print info about the good replicas for a bad tablet In the case that

[kudu-CR] ksck: improve filtering capability

2016-07-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: ksck: improve filtering capability .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3716 To unsubscribe, visit

[kudu-CR](gh-pages) Blog post for the graduation

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Blog post for the graduation .. Patch Set 1: > Thanks for pushing. Looks like we're missing line breaks on the > section headers like "Availability and

[kudu-CR](gh-pages) Blog post for the graduation

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new patch set (#2). Change subject: Blog post for the graduation .. Blog post for the graduation This is just a reblog with the appropriate markdown syntax. Change-Id:

[kudu-CR](gh-pages) Blog post for the graduation

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Blog post for the graduation .. Patch Set 1: Also refreshed the rendering. -- To view, visit http://gerrit.cloudera.org:8080/3741 To unsubscribe, visit

[kudu-CR](gh-pages) www: Redirect kudu.i.a.o to kudu.a.o

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: www: Redirect kudu.i.a.o to kudu.a.o .. Patch Set 1: Been years since I wrote htaccess stuff, so I'll trust you on that one :) -- To view, visit

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Fix a race involving the read timeout .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3724/1//COMMIT_MSG Commit Message:

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3724 to look at the new patch set (#2). Change subject: [java client] Fix a race involving the read timeout .. [java

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Fix a race involving the read timeout .. Patch Set 1: > (1 comment) > > It would be nice to see a test that hits this too. Generally >

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3724 Change subject: [java client] Fix a race involving the read timeout .. [java client] Fix a race involving the read timeout The

[kudu-CR] build-and-test: also clean up old failsafe reports

2016-07-28 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: build-and-test: also clean up old failsafe reports .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3812 To unsubscribe,

[kudu-CR](gh-pages) Blog post for the graduation

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3741 Change subject: Blog post for the graduation .. Blog post for the graduation This is just a reblog with the appropriate markdown

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 2)

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] repackage to org.apache.kudu (Part 2) .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3737 To unsubscribe,

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 1)

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java-client] repackage to org.apache.kudu (Part 1) .. [java-client] repackage to org.apache.kudu (Part 1) Move all org.kududb directories to

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 2)

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java-client] repackage to org.apache.kudu (Part 2) .. [java-client] repackage to org.apache.kudu (Part 2) Find/replace org.kududb with

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 1)

2016-07-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] repackage to org.apache.kudu (Part 1) .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3736 To unsubscribe,

[kudu-CR] Update Impala docs for Impala 2.8 release

2017-02-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Update Impala docs for Impala 2.8 release .. Patch Set 3: Verified+1 Unrelated flake. -- To view, visit http://gerrit.cloudera.org:8080/5733 To

[kudu-CR] Update Impala docs for Impala 2.8 release

2017-02-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Update Impala docs for Impala 2.8 release .. Update Impala docs for Impala 2.8 release * No longer needs to document the special 'IMPALA_KUDU'

[kudu-CR] Update Impala docs for Impala 2.8 release

2017-02-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Update Impala docs for Impala 2.8 release .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5733 To unsubscribe, visit

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder .. Patch Set 1: (2 comments) Good on you for addressing this. I'd be curious to see how it

[kudu-CR] java: remove unused parts of SecureRpcHelper

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: remove unused parts of SecureRpcHelper .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5925 To unsubscribe, visit

[kudu-CR] Make SecureRpcHelper a Netty pipeline stage

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Make SecureRpcHelper a Netty pipeline stage .. Patch Set 1: (1 comment)

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 1: Worth adding a test? -- To view, visit http://gerrit.cloudera.org:8080/5919 To

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 7: (2 comments) Two nits and please add a comment regarding string

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] java: fix ability to connect to a real Kerberized cluster

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix ability to connect to a real Kerberized cluster .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5922 To

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5926 To

[kudu-CR] java: remove unused parts of SecureRpcHelper

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: remove unused parts of SecureRpcHelper .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5925 To unsubscribe, visit

[kudu-CR] Rename SecureRpcHelper to Negotiator

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Rename SecureRpcHelper to Negotiator .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5944 To unsubscribe, visit

[kudu-CR] Make SecureRpcHelper a Netty pipeline stage

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Make SecureRpcHelper a Netty pipeline stage .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5927 To unsubscribe, visit

[kudu-CR] Use an outbound Encoder, add a test for Negotiator

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Use an outbound Encoder, add a test for Negotiator .. Patch Set 1: (4 comments)

[kudu-CR] java: use an outbound Encoder, add a test for Negotiator

2017-02-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use an outbound Encoder, add a test for Negotiator .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5947 To

[kudu-CR] java: fix ability to connect to a real Kerberized cluster

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix ability to connect to a real Kerberized cluster .. Patch Set 3: (4 comments)

[kudu-CR] java: use a netty frame decoder instead of replaying decoder

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder .. Patch Set 2: (1 comment)

[kudu-CR] compaction: Add additional validation in DeltaTracker

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: compaction: Add additional validation in DeltaTracker .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5919 To unsubscribe,

[kudu-CR] tablet: Include peer uuid in log prefix

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: tablet: Include peer uuid in log prefix .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5918 To unsubscribe, visit

[kudu-CR] tablet: Include peer uuid in log prefix

2017-02-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: tablet: Include peer uuid in log prefix .. tablet: Include peer uuid in log prefix Also, add LogPrefix() to the tablet mm op. Change-Id:

[kudu-CR] KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera

2017-01-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera .. KUDU-1854 Fixed broken links to Cloudera's Kudu

[kudu-CR] KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera

2017-01-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1854 Fixed broken links to Cloudera's Kudu documentation and archive.cloudera .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Fix flakiness of TestConnectionCache .. Fix flakiness of TestConnectionCache This test would fail if one of the masters was a bit slow in

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-23 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 2: -Code-Review (1 comment) Jun, what motivated you to

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-30 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5803 to look at the new patch set (#2). Change subject: Fix flakiness of TestConnectionCache .. Fix flakiness of

[kudu-CR] Fix flakiness of TestConnectionCache

2017-01-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix flakiness of TestConnectionCache .. Patch Set 1: Todd, since you're out sick I pushed a new rev over yours. Your variable naming was very C++ and not

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5750 To unsubscribe, visit

[kudu-CR](gh-pages) Change links for old releases to Apache archive

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Change links for old releases to Apache archive .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5751 To unsubscribe, visit

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Bump version in branch to 1.2.1-SNAPSHOT Change-Id: Ide4527df249f91fe60c19f7a0a7be18a0cb012d5

[kudu-CR](branch-1.2.x) Bump version in branch to 1.2.1-SNAPSHOT

2017-01-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump version in branch to 1.2.1-SNAPSHOT .. Patch Set 1: Need to also change python/setup.py -- To view, visit http://gerrit.cloudera.org:8080/5750 To

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. KUDU-1831. Java client does not check if the primary key

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 3: (1 comment) I'm good with the change, just one

[kudu-CR] [KUDU-1880] Prevent eager ignoring of NULLs

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [KUDU-1880] Prevent eager ignoring of NULLs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6029/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] java: further cleanup of ConnectToCluster

2017-02-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: further cleanup of ConnectToCluster .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6053 To unsubscribe, visit

[kudu-CR] block manager: reduce file cache to 40% of total fds

2017-02-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: block manager: reduce file cache to 40% of total fds .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6094 To unsubscribe,

[kudu-CR] KUDU-1402. Ensure session.flush() returns an empty list

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1402. Ensure session.flush() returns an empty list .. KUDU-1402. Ensure session.flush() returns an empty list Adds a test to ensure that

[kudu-CR] KUDU-1402. Ensure session.flush() returns an empty list

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1402. Ensure session.flush() returns an empty list .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6061 To

[kudu-CR] Fix checkstyle suppressions in submodule builds

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix checkstyle suppressions in submodule builds .. Patch Set 3: Verified+1 Todd fixed the test that failed. -- To view, visit

[kudu-CR] java: fix a missing lock in TabletClient

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix a missing lock in TabletClient .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1888. java: fix handling of RPCs which fail before they are sent

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1888. java: fix handling of RPCs which fail before they are sent .. Patch Set 2: (1 comment)

[kudu-CR] java: refactor logic for fanning out master connection into a class

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: refactor logic for fanning out master connection into a class .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6028

[kudu-CR] java: use new ConnectToMaster RPC with fallback

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use new ConnectToMaster RPC with fallback .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6035 To unsubscribe, visit

[kudu-CR] KUDU-1888. java: fix handling of RPCs which fail before they are sent

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1888. java: fix handling of RPCs which fail before they are sent .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] java: use new ConnectToMaster RPC with fallback

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use new ConnectToMaster RPC with fallback .. Patch Set 1: (1 comment)

[kudu-CR] [java client] Fix TestMiniKuduCluster flakiness

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6058 to review the following change. Change subject: [java client] Fix TestMiniKuduCluster flakiness .. [java client] Fix

[kudu-CR] Minor updates to the installation from source docs

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Minor updates to the installation from source docs .. Minor updates to the installation from source docs A few small changes for the various

[kudu-CR] java: set max status error length to 32KB

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: java: set max status error length to 32KB .. java: set max status error length to 32KB The 256 byte error max made the error strings for traces

[kudu-CR] Minor updates to the installation from source docs

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Minor updates to the installation from source docs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6041 To unsubscribe,

[kudu-CR] Fix checkstlye suppressions in submodule builds

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix checkstlye suppressions in submodule builds .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6060/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] Fix checkstyle suppressions in submodule builds

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix checkstyle suppressions in submodule builds .. Patch Set 3: On Slack there was a concern that this might break Eclipse, have you had a chance to test

[kudu-CR] [docs] fixed some typos

2017-02-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] fixed some typos .. Patch Set 1: Code-Review+2 How did you even find all of those typos??? You must have quite the the keen eye! -- To view,

[kudu-CR] [docs] added info on TSK an CA entries in systable

2017-02-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] added info on TSK an CA entries in systable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6111/1/docs/design-docs/master.md File

[kudu-CR] [docs] added info on TSK an CA entries in systable

2017-02-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] added info on TSK an CA entries in systable .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6111/1/docs/design-docs/master.md File

[kudu-CR] Fix checkstyle suppressions in submodule builds

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix checkstyle suppressions in submodule builds .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6060 To unsubscribe, visit

[kudu-CR] java: further cleanup of ConnectToCluster

2017-02-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: further cleanup of ConnectToCluster .. Patch Set 5: (2 comments)

[kudu-CR] java: fix a missing lock in TabletClient

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix a missing lock in TabletClient .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6050 To unsubscribe, visit

[kudu-CR] KUDU-1888. java: fix handling of RPCs which fail before they are sent

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1888. java: fix handling of RPCs which fail before they are sent .. KUDU-1888. java: fix handling of RPCs which fail before they are sent As

[kudu-CR](gh-pages) Add a blog post for 1.2.0 release

2017-02-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add a blog post for 1.2.0 release .. Patch Set 1: Code-Review+2 I trust you double checked the rendering. -- To view, visit

[kudu-CR] [java client] Limit the message size in Status

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5956 to look at the new patch set (#2). Change subject: [java client] Limit the message size in Status .. [java client]

[kudu-CR] [docs] Update encodings section

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5966 to review the following change. Change subject: [docs] Update encodings section .. [docs] Update encodings section

[kudu-CR] [java client] Limit the message size in Status

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Limit the message size in Status .. [java client] Limit the message size in Status We've seen cases where RPC traces that are

[kudu-CR] [java client] Limit the message size in Status

2017-02-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Limit the message size in Status .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5956/1//COMMIT_MSG Commit Message: Line

[kudu-CR] csd: remove from repo

2017-02-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: csd: remove from repo .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5973 To unsubscribe, visit

[kudu-CR] [docs] Update encodings section

2017-02-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Update encodings section .. [docs] Update encodings section With KUDU-100 and KUDU-1751 we need to update our encodings docs. Change-Id:

[kudu-CR] [client] retry operation in case of ServiceUnavailable

2017-02-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [client] retry operation in case of ServiceUnavailable .. Patch Set 5: (1 comment)

[kudu-CR] Refactor HybridClock and add a local clock mode

2017-02-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Refactor HybridClock and add a local clock mode .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5982/1/src/kudu/server/hybrid_clock.cc

[kudu-CR] java: redo locking and simplify TabletClient

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: redo locking and simplify TabletClient .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6017 To unsubscribe, visit

[kudu-CR] java: set max status error length to 32KB

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: set max status error length to 32KB .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] java: refactor logic for fanning out master connection into a class

2017-02-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: refactor logic for fanning out master connection into a class .. Patch Set 1: (2 comments)

[kudu-CR] WIP: java: use new ConnectToMaster RPC with fallback

2017-02-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP: java: use new ConnectToMaster RPC with fallback .. Patch Set 1: (2 comments)

[kudu-CR] java: refactor logic for fanning out master connection into a class

2017-02-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: refactor logic for fanning out master connection into a class .. Patch Set 2: (1 comment)

[kudu-CR] [java client] Fix javadoc in ServerInfo

2017-02-16 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6039 to review the following change. Change subject: [java client] Fix javadoc in ServerInfo .. [java client] Fix javadoc

[kudu-CR] WIP: Delete ancient UNDO delta blocks in the background

2017-02-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP: Delete ancient UNDO delta blocks in the background .. Patch Set 2: (7 comments)

  1   2   3   4   5   6   7   8   9   >