[kudu-CR](branch-1.6.x) KUDU-1097. master: strip health reports from cstate before persisting
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8737 ) Change subject: KUDU-1097. master: strip health reports from cstate before persisting .. KUDU-1097. master: strip health reports from cstate before persisting The master should not persist configs with health reports in them because the health reports are inherently transient information. This patch strips the health reports from the cstate included in each leader tablet report before persisting them and adds a couple of DCHECKS in random places to enforce that. Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 Reviewed-on: http://gerrit.cloudera.org:8080/8683 Reviewed-by: Alexey SerbinTested-by: Kudu Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/8737 --- M src/kudu/master/catalog_manager.cc 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8737 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: merged Gerrit-Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 Gerrit-Change-Number: 8737 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR](branch-1.6.x) KUDU-1097. master: strip health reports from cstate before persisting
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8737 ) Change subject: KUDU-1097. master: strip health reports from cstate before persisting .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8737 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: comment Gerrit-Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 Gerrit-Change-Number: 8737 Gerrit-PatchSet: 1 Gerrit-Owner: Mike PercyGerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sat, 02 Dec 2017 04:01:56 + Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) KUDU-1097. master: strip health reports from cstate before persisting
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8737 to review the following change. Change subject: KUDU-1097. master: strip health reports from cstate before persisting .. KUDU-1097. master: strip health reports from cstate before persisting The master should not persist configs with health reports in them because the health reports are inherently transient information. This patch strips the health reports from the cstate included in each leader tablet report before persisting them and adds a couple of DCHECKS in random places to enforce that. Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 Reviewed-on: http://gerrit.cloudera.org:8080/8683 Reviewed-by: Alexey SerbinTested-by: Kudu Jenkins --- M src/kudu/master/catalog_manager.cc 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/8737/1 -- To view, visit http://gerrit.cloudera.org:8080/8737 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: newchange Gerrit-Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 Gerrit-Change-Number: 8737 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins