[kudu-CR](branch-1.6.x) KUDU-2238. DMS not flush under memory pressure.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9323 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: comment Gerrit-Change-Id: I0c04d76aa0e3888352dc56eeb493a5437ef47e42 Gerrit-Change-Number: 9323 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Reviewer: zhen.zhang Gerrit-Comment-Date: Thu, 22 Feb 2018 21:23:12 + Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) KUDU-2238. DMS not flush under memory pressure.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9323 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. KUDU-2238. DMS not flush under memory pressure. When we choose DMS to flush, now we always pick the DMS with highest log retention. However, as KUDU-2238 shows, in some cases DMS with highest log retention may only consume little memory, and other DMSs may consume much more memory, but get no chance to be flushed, even under memory pressure. This patch gives the ability to take memory consumption into consideration when we choose DMS. Change-Id: I0c04d76aa0e3888352dc56eeb493a5437ef47e42 Reviewed-on: http://gerrit.cloudera.org:8080/8904 Reviewed-by: Todd Lipcon Tested-by: Kudu Jenkins (cherry picked from commit f8d18693546cd518c8873b7a5f4c08579f85199a) Reviewed-on: http://gerrit.cloudera.org:8080/9323 Reviewed-by: Will Berkeley --- M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_replica_mm_ops.cc 3 files changed, 18 insertions(+), 8 deletions(-) Approvals: Kudu Jenkins: Verified Will Berkeley: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: merged Gerrit-Change-Id: I0c04d76aa0e3888352dc56eeb493a5437ef47e42 Gerrit-Change-Number: 9323 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Reviewer: zhen.zhang
[kudu-CR](branch-1.6.x) KUDU-2238. DMS not flush under memory pressure.
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9323 Change subject: KUDU-2238. DMS not flush under memory pressure. .. KUDU-2238. DMS not flush under memory pressure. When we choose DMS to flush, now we always pick the DMS with highest log retention. However, as KUDU-2238 shows, in some cases DMS with highest log retention may only consume little memory, and other DMSs may consume much more memory, but get no chance to be flushed, even under memory pressure. This patch gives the ability to take memory consumption into consideration when we choose DMS. Change-Id: I0c04d76aa0e3888352dc56eeb493a5437ef47e42 Reviewed-on: http://gerrit.cloudera.org:8080/8904 Reviewed-by: Todd Lipcon Tested-by: Kudu Jenkins (cherry picked from commit f8d18693546cd518c8873b7a5f4c08579f85199a) --- M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_replica_mm_ops.cc 3 files changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/9323/1 -- To view, visit http://gerrit.cloudera.org:8080/9323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: newchange Gerrit-Change-Id: I0c04d76aa0e3888352dc56eeb493a5437ef47e42 Gerrit-Change-Number: 9323 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley Gerrit-Reviewer: zhen.zhang
