[kudu-CR](branch-1.6.x) util: move ListFilesInDir to env util
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9437 ) Change subject: util: move ListFilesInDir to env_util .. util: move ListFilesInDir to env_util ListFilesInDir() is useful outside of just inspecting external mini clusters. This patch moves it into env_util. Change-Id: I8372c13b28c3c3058322fc96b656ef71aa18fc0a Reviewed-on: http://gerrit.cloudera.org:8080/9166 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves Reviewed-on: http://gerrit.cloudera.org:8080/9437 --- M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc M src/kudu/integration-tests/external_mini_cluster_fs_inspector.h M src/kudu/integration-tests/multidir_cluster-itest.cc M src/kudu/util/env_util.cc M src/kudu/util/env_util.h 5 files changed, 32 insertions(+), 26 deletions(-) Approvals: Kudu Jenkins: Verified David Ribeiro Alves: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: merged Gerrit-Change-Id: I8372c13b28c3c3058322fc96b656ef71aa18fc0a Gerrit-Change-Number: 9437 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.6.x) util: move ListFilesInDir to env util
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9437 ) Change subject: util: move ListFilesInDir to env_util .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: comment Gerrit-Change-Id: I8372c13b28c3c3058322fc96b656ef71aa18fc0a Gerrit-Change-Number: 9437 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sat, 24 Feb 2018 00:25:27 + Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) util: move ListFilesInDir to env util
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9437 to review the following change. Change subject: util: move ListFilesInDir to env_util .. util: move ListFilesInDir to env_util ListFilesInDir() is useful outside of just inspecting external mini clusters. This patch moves it into env_util. Change-Id: I8372c13b28c3c3058322fc96b656ef71aa18fc0a Reviewed-on: http://gerrit.cloudera.org:8080/9166 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves --- M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc M src/kudu/integration-tests/external_mini_cluster_fs_inspector.h M src/kudu/integration-tests/multidir_cluster-itest.cc M src/kudu/util/env_util.cc M src/kudu/util/env_util.h 5 files changed, 32 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/9437/1 -- To view, visit http://gerrit.cloudera.org:8080/9437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: newchange Gerrit-Change-Id: I8372c13b28c3c3058322fc96b656ef71aa18fc0a Gerrit-Change-Number: 9437 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
